ric-pro:p1-gs - Branch - shotover/shotover-proxy

Ungraceful Shutdown of Old Shotover Instances

#1947Merged

Comparing

ric-pro:p1-gs

(

54fdddc

) with

main

(

6ef42d8

)

Untouched: 38

Benchmarks

Passed

encode_all

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+3%

18.7 µs18.1 µs

encode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

+3%

13.6 µs13.2 µs

decode_request_metadata_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+2%

8.9 µs8.8 µs

encode_request_metadata

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+2%

10.5 µs10.4 µs

decode_request_list_offsets_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

10.3 µs10.1 µs

decode_request_produce_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

10.8 µs10.6 µs

decode_request_produce_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

3.4 µs3.4 µs

decode_request_fetch_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

11.6 µs11.5 µs

encode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

26 µs25.9 µs

decode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

53.9 µs53.7 µs

decode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

44.6 µs44.5 µs

query_counter_pre_used

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

10.5 µs10.4 µs

encode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

14.6 µs14.5 µs

decode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

55.6 µs55.5 µs

decode_system.local_result_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

12.4 µs12.4 µs

decode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

53.9 µs53.8 µs

encode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

202.5 µs202.5 µs

encode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

92.6 µs92.6 µs

cassandra_request_throttling_unparsed

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

12.5 µs12.5 µs

query_counter_fresh

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

15.3 µs15.3 µs

loopback

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

6.4 µs6.4 µs

decode_request_list_offsets_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

3.3 µs3.3 µs

valkey_cluster_ports_rewrite

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

17.1 µs17.1 µs

decode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

12.4 µs12.4 µs

cassandra_protect_unprotected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

40.8 µs40.8 µs

decode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

55.4 µs55.4 µs

valkey_filter

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

20.2 µs20.2 µs

cassandra_rewrite_peers_passthrough

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

79.3 µs79.3 µs

encode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

205.4 µs205.6 µs

encode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

13.4 µs13.4 µs

encode_request_produce

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

8 µs8 µs

nullsink

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

13.4 µs13.5 µs

encode_request_list_offsets

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

11.3 µs11.3 µs

cassandra_protect_protected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

-1%

70.6 µs71 µs

decode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-1%

44.4 µs44.7 µs

decode_request_fetch_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

-1%

3.5 µs3.6 µs

encode_request_fetch

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

-5%

11.4 µs12.1 µs

decode_request_metadata_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

-8%

2.6 µs2.8 µs

Commits

Click on a commit to change the comparison range

Base

main

6ef42d8

+0.13%

Lint errors fixed

053dcf1

24 days ago

by ric-pro

-0.25%

test issues fixed

1fa90d8

24 days ago

by ric-pro

-0.1%

logic bug error?

65a8865

24 days ago

by ric-pro

+0.17%

automatic shutdown request

959ff38

24 days ago

by ric-pro

-0.18%

shutdown request made after shot_new is fully functional

664024e

24 days ago

by ric-pro

-0.02%

linux only

6ef17fb

24 days ago

by ric-pro

+0.05%

test will only run in linux, complies in every environment

c05c822

24 days ago

by ric-pro

feedback addressed v1

54cd9b6

22 days ago

by ric-pro

+0.16%

wrapped hotreload_socket_from_socket and added the fns as methods

428c320

22 days ago

by ric-pro

-0.02%

feedbacked resolved

54fdddc

21 days ago

by ric-pro

Home Terms Privacy Docs