ric-pro:gradual-shutdown - Branch - shotover/shotover-proxy

Gradual Connection Draining

#1952Merged

Comparing

ric-pro:gradual-shutdown

(

16d4ae5

) with

main

(

512a4a0

)

Untouched: 38

Benchmarks

Passed

decode_request_list_offsets_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

10.3 µs10.1 µs

encode_request_produce

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

8 µs7.9 µs

decode_request_metadata_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

8.9 µs8.8 µs

encode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

+1%

14.7 µs14.5 µs

decode_request_metadata_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

2.8 µs2.8 µs

encode_request_list_offsets

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

11.3 µs11.2 µs

decode_request_produce_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

10.8 µs10.7 µs

encode_request_metadata

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

10.4 µs10.3 µs

encode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

+1%

13.3 µs13.2 µs

decode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

+1%

53.9 µs53.6 µs

decode_request_fetch_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

11.5 µs11.5 µs

encode_request_fetch

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

12.1 µs12 µs

query_counter_fresh

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

15.3 µs15.2 µs

query_counter_pre_used

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

10.4 µs10.4 µs

encode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

202.2 µs201.8 µs

encode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

205.6 µs205.3 µs

cassandra_protect_protected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

71 µs70.9 µs

encode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

92.6 µs92.6 µs

cassandra_request_throttling_unparsed

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

12.5 µs12.5 µs

cassandra_protect_unprotected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

40.8 µs40.8 µs

valkey_cluster_ports_rewrite

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

17.1 µs17.1 µs

valkey_filter

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

20.2 µs20.2 µs

loopback

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

6.4 µs6.4 µs

decode_system.local_result_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

12.4 µs12.4 µs

nullsink

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

13.4 µs13.4 µs

decode_request_list_offsets_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

3.3 µs3.3 µs

decode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

53.6 µs53.6 µs

decode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

44.4 µs44.4 µs

encode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

13.4 µs13.5 µs

cassandra_rewrite_peers_passthrough

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

79.2 µs79.2 µs

decode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

55.5 µs55.5 µs

encode_all

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

18.2 µs18.2 µs

decode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

44.5 µs44.6 µs

decode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

12.4 µs12.4 µs

encode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-1%

25.9 µs26.1 µs

decode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-1%

55.3 µs55.6 µs

decode_request_fetch_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

-1%

3.5 µs3.5 µs

decode_request_produce_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

-2%

3.4 µs3.4 µs

Commits

Click on a commit to change the comparison range

Base

main

512a4a0

+0.08%

Gradual Connection Draining

700ff77

1 month ago

by ric-pro

-0.18%

removed pending().await

eaa785f

1 month ago

by ric-pro

+0.49%

made accept branch conditional

e2273d1

1 month ago

by ric-pro

-0.4%

removed return

4b1d892

1 month ago

by ric-pro

+0.13%

added return

6832be9

1 month ago

by ric-pro

-0.36%

timeout fixed?

a2fcfd9

1 month ago

by ric-pro

+0.25%

flags after processing a connection

d731778

1 month ago

by ric-pro

+0.24%

fixed timeout

15a4890

1 month ago

by ric-pro

-0.54%

logging

dcd0480

1 month ago

by ric-pro

+0.24%

fix1

5f3d22a

1 month ago

by ric-pro

+0.01%

workflow

e6a721f

1 month ago

by ric-pro

+0.09%

logs?

7046573

1 month ago

by ric-pro

-0.04%

removed manual shutdown of hot reload server

eb15ddf

1 month ago

by ric-pro

-0.07%

workflow

9cb520c

1 month ago

by ric-pro

+0.07%

gradual-shutdown

0a6dd71

1 month ago

by ric-pro

-0.15%

Removed complex fields, moved drain logic to grad shutdown handler

f0697ef

1 month ago

by ric-pro

+0.16%

moved socket handoff check to start

08d25fc

1 month ago

by ric-pro

+0.16%

removed outdated logs

82754c5

1 month ago

by ric-pro

-0.22%

passing the iterator directly to join_all

e56f6ec

1 month ago

by ric-pro

+0.16%

workflow

6c06443

1 month ago

by ric-pro

-0.08%

pending()

d9016b7

1 month ago

by ric-pro

-0.08%

reduntant retain call removed

89120da

1 month ago

by ric-pro

removed return chan

25417c0

1 month ago

by ric-pro

+0.35%

indentation fixed

4b92670

1 month ago

by ric-pro

-0.38%

increasing the number of connections to old shotover

c61d9ca

1 month ago

by ric-pro

+0.16%

zero connections

8dd0dcf

1 month ago

by ric-pro

-0.08%

ci hack removed

3dd137e

1 month ago

by ric-pro

+0.41%

reverting workflow

2bfb701

28 days ago

by ric-pro

-0.44%

timinig issue fixed

9b05a6b

28 days ago

by ric-pro

+0.19%

reverted ci hack

16d4ae5

28 days ago

by ric-pro

Home Terms Privacy Docs