justinweng-instaclustr:1687-kafka-consumers-seeing-not_coordinator-warnings - Branch - shotover/shotover-proxy

Fix NOT_COORDINATOR warnings for Kafka consumer offset commit requests

#1693Merged

Comparing

justinweng-instaclustr:1687-kafka-consumers-seeing-not_coordinator-warnings

(

9fef022

) with

main

(

6ec2022

)

Untouched: 39

Benchmarks

Passed

encode_request_list_offsets

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_list_offsets

+4%

13 µs12.5 µs

encode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v5_no_compression

+3%

15.3 µs14.8 µs

encode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v4_lz4_compression

+2%

14.3 µs14 µs

encode_all

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_all

+2%

23.4 µs23 µs

decode_request_list_offsets_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_list_offsets_create

+1%

10.9 µs10.8 µs

query_counter_pre_used

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::query_counter_pre_used

+1%

11.9 µs11.8 µs

encode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v4_no_compression

+1%

14.2 µs14.1 µs

decode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v4_no_compression

+1%

55.4 µs55 µs

encode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v5_lz4_compression

+1%

202.4 µs201.3 µs

decode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v4_lz4_compression

55.2 µs55 µs

encode_request_produce

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_produce

9.7 µs9.7 µs

decode_request_metadata_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_metadata_create

9.7 µs9.7 µs

encode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v4_no_compression

93 µs92.9 µs

query_counter_fresh

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::query_counter_fresh

15.4 µs15.4 µs

redis_filter

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::redis_filter

22.2 µs22.2 µs

decode_request_fetch_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_fetch_create

12 µs12 µs

loopback

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::loopback

6.4 µs6.4 µs

decode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v4_no_compression

14.7 µs14.7 µs

decode_request_metadata_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_metadata_drop

3.3 µs3.3 µs

encode_system.local_result_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v5_no_compression

93 µs93 µs

decode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v4_lz4_compression

44.8 µs44.8 µs

encode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v4_lz4_compression

202.4 µs202.4 µs

cassandra_rewrite_peers_passthrough

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_rewrite_peers_passthrough

82.3 µs82.3 µs

encode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v5_lz4_compression

26.2 µs26.2 µs

cassandra_protect_unprotected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_protect_unprotected

43 µs43 µs

decode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v5_lz4_compression

44.6 µs44.7 µs

decode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v5_lz4_compression

57 µs57.1 µs

decode_request_produce_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_produce_create

13.7 µs13.7 µs

redis_cluster_ports_rewrite

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::redis_cluster_ports_rewrite

18.9 µs18.9 µs

cassandra_request_throttling_unparsed

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_request_throttling_unparsed

14.6 µs14.7 µs

nullsink

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::nullsink

14 µs14.1 µs

cassandra_protect_protected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_protect_protected

74 µs74.4 µs

decode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v5_no_compression

56.9 µs57.2 µs

decode_system.local_result_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v5_no_compression

-1%

14.7 µs14.8 µs

decode_request_produce_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_produce_drop

-1%

4.1 µs4.1 µs

decode_request_fetch_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_fetch_drop

-1%

4.1 µs4.1 µs

encode_request_metadata

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_metadata

-1%

13.2 µs13.3 µs

encode_request_fetch

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_fetch

-1%

13.8 µs13.9 µs

decode_request_list_offsets_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_list_offsets_drop

-1%

3.9 µs3.9 µs

Commits

Click on a commit to change the comparison range

Base

main

6ec2022

-0.06%

add int test to reproduce not_coordinator error

4e51925

1 year ago

by justinweng-instaclustr

+0.39%

commit specified offset

3b6d637

1 year ago

by justinweng-instaclustr

-0.46%

add cpp driver implementation

3634e6d

1 year ago

by justinweng-instaclustr

-0.03%

route offset commit request to coordinator

5cb7a4a

1 year ago

by justinweng-instaclustr

+0.01%

Merge branch 'shotover:main' into 1687-kafka-consumers-seeing-not_coordinator-warnings

c07e2de

1 year ago

by justinweng-instaclustr

+0.37%

cleanup

6b3dbce

1 year ago

by justinweng-instaclustr

-0.22%

cleanup unused lifetime annotation

b35c760

1 year ago

by justinweng-instaclustr

+0.17%

address comments

a9677a0

1 year ago

by justinweng-instaclustr

+0.01%

Merge branch 'main' into 1687-kafka-consumers-seeing-not_coordinator-warnings

9fef022

1 year ago

by justinweng-instaclustr

Home Terms Privacy Docs