INS-38586-kafkasink-innaccessible-peers-metric - Branch - shotover/shotover-proxy

Ins 38586 kafkasink innaccessible peers metric

#1964Merged

Comparing

INS-38586-kafkasink-innaccessible-peers-metric

(

ac47914

) with

main

(

bd89a7d

)

Untouched: 38

Benchmarks

Passed

encode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

+1%

25.8 µs25.5 µs

decode_system.local_result_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

+1%

12.4 µs12.3 µs

decode_request_metadata_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

2.9 µs2.8 µs

loopback

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

+1%

6.2 µs6.1 µs

decode_request_list_offsets_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

3.2 µs3.1 µs

decode_request_fetch_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

3.4 µs3.4 µs

decode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

+1%

55.8 µs55.4 µs

encode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

+1%

201 µs199.6 µs

decode_request_fetch_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

11 µs11 µs

valkey_cluster_ports_rewrite

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

+1%

16.9 µs16.9 µs

decode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

12.4 µs12.3 µs

query_counter_fresh

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

15.4 µs15.4 µs

decode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

55.7 µs55.6 µs

decode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

43.8 µs43.7 µs

cassandra_protect_unprotected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

40.6 µs40.5 µs

cassandra_request_throttling_unparsed

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

12.2 µs12.2 µs

cassandra_protect_protected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

70.9 µs70.7 µs

nullsink

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

13.2 µs13.2 µs

decode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

53.9 µs53.7 µs

valkey_filter

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

20 µs19.9 µs

cassandra_rewrite_peers_passthrough

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

79.5 µs79.5 µs

encode_request_produce

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

7.6 µs7.5 µs

encode_request_metadata

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

10 µs9.9 µs

encode_request_fetch

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

11.5 µs11.5 µs

decode_request_produce_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

10.2 µs10.2 µs

decode_request_metadata_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

8.4 µs8.4 µs

decode_request_list_offsets_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

9.7 µs9.7 µs

encode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

92.3 µs92.3 µs

decode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

43.7 µs43.8 µs

encode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

203.3 µs203.5 µs

encode_all

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

17.2 µs17.3 µs

encode_request_list_offsets

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

10.6 µs10.7 µs

query_counter_pre_used

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

10.3 µs10.3 µs

decode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-1%

54 µs54.4 µs

decode_request_produce_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

-1%

3.4 µs3.4 µs

encode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-1%

14.2 µs14.4 µs

encode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-2%

13.4 µs13.7 µs

encode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-3%

12.9 µs13.2 µs

Commits

Click on a commit to change the comparison range

Base

main

bd89a7d

-0.04%

forgot to ask clippy how they felt, they were unhappy with my understanding of String and str

a409230

11 days ago

-0.01%

made callouts to metric check more consistent

34f9bc0

11 days ago

+0.14%

codereview: use u16 for port, remove unnecessary clone chain_name

ac47914

11 days ago

Home Terms Privacy Docs