Avatar for the seddonym user
seddonym
grimp
Instrumentation
Wall Time
BlogDocsChangelog

Don't reinstantiate package_modules within each loop

#218Merged
Comparing
optimize-is-external
(
9148ccb
) with
master
(
37eaec4
)
CodSpeed Performance Gauge
+1%
Improvements
0
Regressions
0
Untouched
22
New
0
Dropped
0
Ignored
0

Benchmarks

Passed

test_build_django_from_cache_no_misses
tests/benchmarking/test_benchmarking.py::test_build_django_from_cache_no_misses
CodSpeed Performance Gauge
+4%
130.6 ms
125.3 ms
test_build_django_from_cache_a_few_misses[2]
tests/benchmarking/test_benchmarking.py::test_build_django_from_cache_a_few_misses[2]
CodSpeed Performance Gauge
+4%
137.9 ms
132.5 ms
test_build_django_uncached
tests/benchmarking/test_benchmarking.py::test_build_django_uncached
CodSpeed Performance Gauge
+4%
150.5 ms
145.3 ms
test_build_django_from_cache_a_few_misses[15]
tests/benchmarking/test_benchmarking.py::test_build_django_from_cache_a_few_misses[15]
CodSpeed Performance Gauge
+4%
161.1 ms
155.6 ms
test_build_django_from_cache_a_few_misses[350]
tests/benchmarking/test_benchmarking.py::test_build_django_from_cache_a_few_misses[350]
CodSpeed Performance Gauge
+3%
306.7 ms
298.8 ms
test_chain_found
tests/benchmarking/test_benchmarking.py::TestFindShortestChain::test_chain_found
CodSpeed Performance Gauge
0%
63.1 µs
62.8 µs
test_top_level_large_graph_kept
tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers::test_top_level_large_graph_kept
CodSpeed Performance Gauge
0%
47.7 ms
47.6 ms
test_chains_found
tests/benchmarking/test_benchmarking.py::TestFindShortestChains::test_chains_found
CodSpeed Performance Gauge
0%
84.7 µs
84.5 µs
test_find_matching_direct_imports
tests/benchmarking/test_benchmarking.py::test_find_matching_direct_imports
CodSpeed Performance Gauge
0%
35.6 ms
35.6 ms
test_get_import_details
tests/benchmarking/test_benchmarking.py::test_get_import_details
CodSpeed Performance Gauge
0%
249.3 µs
249.2 µs
test_find_downstream_modules
tests/benchmarking/test_benchmarking.py::test_find_downstream_modules
CodSpeed Performance Gauge
0%
171.9 µs
171.9 µs
test_find_upstream_modules
tests/benchmarking/test_benchmarking.py::test_find_upstream_modules
CodSpeed Performance Gauge
0%
3.4 ms
3.4 ms
test_no_chains
tests/benchmarking/test_benchmarking.py::TestFindShortestChains::test_no_chains
CodSpeed Performance Gauge
0%
1.2 ms
1.2 ms
test_no_chain
tests/benchmarking/test_benchmarking.py::TestFindShortestChain::test_no_chain
CodSpeed Performance Gauge
0%
1.2 ms
1.2 ms
test_copy_graph
tests/benchmarking/test_benchmarking.py::test_copy_graph
CodSpeed Performance Gauge
0%
55.3 ms
55.3 ms
test_modules_property_many_accesses
tests/benchmarking/test_benchmarking.py::test_modules_property_many_accesses
CodSpeed Performance Gauge
0%
34.1 ms
34.1 ms
test_modules_property_first_access
tests/benchmarking/test_benchmarking.py::test_modules_property_first_access
CodSpeed Performance Gauge
0%
33.5 ms
33.5 ms
test_find_matching_modules
tests/benchmarking/test_benchmarking.py::test_find_matching_modules
CodSpeed Performance Gauge
0%
9.1 ms
9.1 ms
test_find_descendants
tests/benchmarking/test_benchmarking.py::test_find_descendants
CodSpeed Performance Gauge
0%
35.2 ms
35.3 ms
test_deep_layers_large_graph_violated
tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers::test_deep_layers_large_graph_violated
CodSpeed Performance Gauge
0%
11.6 ms
11.6 ms
test_top_level_large_graph_violated
tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers::test_top_level_large_graph_violated
CodSpeed Performance Gauge
-1%
232.5 ms
234.1 ms
test_deep_layers_large_graph_kept
tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers::test_deep_layers_large_graph_kept
CodSpeed Performance Gauge
-4%
19.2 ms
20 ms

Commits

Click on a commit to change the comparison range
Base
master
37eaec4
+1%
Don't reinstantiate package_modules within each loop From profiling, the _is_external call is surprisingly expensive. This is a quick win to avoid recalculating the package_modules each time we loop.
9148ccb
4 days ago
by seddonym
© 2025 CodSpeed Technology
Home Terms PrivacyDocs