welf:fix-clippy-double-parens-warnings - Branch - salsa-rs/salsa

Fix clippy::double_parens warnings in unexpected_cycle_recovery and unexpected_cycle_initial macros

#1005

Comparing

welf:fix-clippy-double-parens-warnings

(

c280c5e

) with

master

(

8b0831f

)

-6%

Improvements: 1

Regressions: 1

Untouched: 11

Benchmarks

Failed

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs

Regression

-6%

2.1 µs2.3 µs

Improved

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs

+4%

3 µs2.9 µs

Passed

amortized[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs

+1%

2.1 µs2.1 µs

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs

15.6 µs15.5 µs

accumulator

benches/accumulator.rs::benches::accumulator

3.3 ms3.3 ms

converge_diverge

benches/dataflow.rs::benches::dataflow

125.4 µs125.4 µs

converge_diverge_nested

benches/dataflow.rs::benches::nested

200.8 µs201.1 µs

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs

-1%

4.3 µs4.3 µs

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs

-1%

8.9 µs9.1 µs

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs

-1%

9.6 µs9.7 µs

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

-2%

14.5 µs14.7 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

-2%

14.3 µs14.6 µs

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

-2%

13.6 µs13.9 µs

Commits

Click on a commit to change the comparison range

Base

master

8b0831f

-0.62%

Fix clippy::double_parens warnings in unexpected_cycle_recovery and unexpected_cycle_initial macros

a0a997b

2 days ago

by welf

-5.79%

Add tests to verify problematic behavior

25200fc

2 days ago

by welf

Add inventory gate to tracked functions test

d5275ae

1 day ago

by welf

Make the test a warnings test

c280c5e

1 day ago

by MichaReiser

Home Terms Privacy Docs