ibraheemdev:ibraheem/unchecked-memo-table - Branch - salsa-rs/salsa

Remove extra bounds checks from memo table hot-paths

#938Merged

Comparing

ibraheemdev:ibraheem/unchecked-memo-table

(

be3c4db

) with

master

(

dba66f1

)

+1%

Untouched: 12

Benchmarks

Passed

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[10]

+2%

13.5 µs13.2 µs

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::new[Input]

+2%

9.3 µs9.1 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[20]

+2%

13.6 µs13.4 µs

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[30]

+2%

13.7 µs13.5 µs

accumulator

benches/accumulator.rs::benches::accumulator::accumulator

+2%

3.4 ms3.3 ms

amortized[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[InternedInput]

+1%

2.7 µs2.7 µs

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[SupertypeInput]

+1%

15.5 µs15.3 µs

converge_diverge

benches/dataflow.rs::benches::dataflow::converge_diverge

131.7 µs131.3 µs

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[SupertypeInput]

3.3 µs3.3 µs

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs::many_tracked_structs

32.4 µs32.4 µs

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[InternedInput]

-2%

4.7 µs4.7 µs

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[Input]

-2%

2.7 µs2.7 µs

Commits

Click on a commit to change the comparison range

Base

master

dba66f1

+0.75%

remove extra bounds checks from memo table hot-paths

be3c4db

2 months ago

by ibraheemdev

Home Terms Privacy Docs