Comparing
Veykril:veykril/push-koslsspqvosw
(c85e300
) withmaster
(5ee3bdd
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 12
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
amortized[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs::amortized[SupertypeInput]+1%
4.1 µs
4 µs
new[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs::new[InternedInput]+1%
5.8 µs
5.7 µs
mutating[10]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[10]0%
12.9 µs
12.8 µs
mutating[20]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[20]0%
13 µs
13 µs
mutating[30]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[30]0%
13.2 µs
13.1 µs
converge_diverge
benches/dataflow.rs::benches::dataflow::converge_diverge0%
135.9 µs
135.9 µs
accumulator
benches/accumulator.rs::benches::accumulator::accumulator0%
4.3 ms
4.3 ms
new[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs::new[SupertypeInput]0%
15.6 µs
15.6 µs
new[Input]
benches/compare.rs::benches::inputs::Mutating Inputs::new[Input]0%
9.7 µs
9.7 µs
many_tracked_structs
benches/incremental.rs::benches::many_tracked_structs::many_tracked_structs0%
36.3 µs
36.4 µs
amortized[Input]
benches/compare.rs::benches::inputs::Mutating Inputs::amortized[Input]-1%
3.4 µs
3.4 µs
amortized[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs::amortized[InternedInput]-2%
3.4 µs
3.4 µs
Commits
Click on a commit to change the comparison rangeBase
master
5ee3bdd
0%
fix: Use `changed_at` revision when updating fields
Setting the field's revision to `current_revision` when updating is not technically wrong, but its pessimizing.
If all previous reads only observed a change of up to `changed_at`, then it's fine for us to do the same as nothing
we derive from has read from `current_revision`.
c85e300
8 days ago
by Veykril