MichaReiser:untracked-read-cycle-tracked-struct - Branch - salsa-rs/salsa

fix: Access to tracked-struct that was freed during fixpoint

#817Merged

Comparing

MichaReiser:untracked-read-cycle-tracked-struct

(

c9dd58f

) with

master

(

0cbe7f8

)

Untouched: 12

Benchmarks

Passed

converge_diverge

benches/dataflow.rs::benches::dataflow::converge_diverge

+1%

129.3 µs128.3 µs

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[SupertypeInput]

+1%

3.9 µs3.9 µs

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[SupertypeInput]

16.3 µs16.3 µs

accumulator

benches/accumulator.rs::benches::accumulator::accumulator

3.9 ms3.9 ms

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[30]

13.6 µs13.6 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[20]

13.5 µs13.5 µs

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[10]

13.3 µs13.3 µs

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs::many_tracked_structs

36.9 µs36.9 µs

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::new[Input]

9.7 µs9.7 µs

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[Input]

-1%

3.2 µs3.3 µs

amortized[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[InternedInput]

-2%

3.2 µs3.3 µs

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[InternedInput]

-3%

5.4 µs5.5 µs

Commits

Click on a commit to change the comparison range

Base

master

0cbe7f8

-4.37%

Cleanup

b4497d9

5 months ago

by MichaReiser

+4%

Append outputs only once

c9dd58f

5 months ago

by MichaReiser

Home Terms Privacy Docs