MichaReiser:store-tracked-struct-ids-only-once - Branch - salsa-rs/salsa

refactor: Remove tracked structs from query outputs

#969Merged

Comparing

MichaReiser:store-tracked-struct-ids-only-once

(

6a63bff

) with

master

(

a2cd1b8

)

×3.4

Improvements: 1

Untouched: 11

Benchmarks

Improved

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs::many_tracked_structs

×3.4

31.8 µs9.2 µs

Passed

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[Input]

+4%

2.4 µs2.3 µs

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[30]

14.8 µs14.8 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[20]

14.7 µs14.7 µs

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[10]

13.9 µs13.9 µs

accumulator

benches/accumulator.rs::benches::accumulator::accumulator

-1%

3.3 ms3.4 ms

converge_diverge

benches/dataflow.rs::benches::dataflow::converge_diverge

-1%

124.2 µs125.6 µs

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[InternedInput]

-1%

4.6 µs4.7 µs

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::new[Input]

-2%

9.9 µs10.2 µs

amortized[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[InternedInput]

-3%

2.2 µs2.3 µs

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[SupertypeInput]

-3%

15.8 µs16.2 µs

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[SupertypeInput]

-4%

2.9 µs3.1 µs

Commits

Click on a commit to change the comparison range

Base

master

a2cd1b8

×3.4

Pass CompletedQuery to diff_outputs

6a63bff

1 month ago

by MichaReiser

Home Terms Privacy Docs