MichaReiser:fixpoint-maybe-changed-after-run-away - Branch - salsa-rs/salsa

fix: Runaway for unchanged queries participating in cycle

#981Merged

Comparing

MichaReiser:fixpoint-maybe-changed-after-run-away

(

f39e194

) with

master

(

fb4cb24

)

+7%

Improvements: 2

Untouched: 10

Benchmarks

Improved

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[SupertypeInput]

+7%

3 µs2.8 µs

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[Input]

+5%

2.4 µs2.3 µs

Passed

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[InternedInput]

+3%

4.7 µs4.5 µs

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs::many_tracked_structs

+3%

9.4 µs9.2 µs

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[SupertypeInput]

+2%

16 µs15.7 µs

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::new[Input]

+1%

10 µs9.9 µs

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[10]

14.2 µs14.1 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[20]

14.9 µs14.9 µs

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[30]

15.1 µs15 µs

amortized[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[InternedInput]

2.3 µs2.3 µs

accumulator

benches/accumulator.rs::benches::accumulator::accumulator

3.3 ms3.3 ms

converge_diverge

benches/dataflow.rs::benches::dataflow::converge_diverge

-1%

127.2 µs128.5 µs

Commits

Click on a commit to change the comparison range

Base

master

fb4cb24

-0.44%

Another regression test

6d31c9d

28 days ago

by MichaReiser

-7.31%

Fix runaway situation

4dda9c6

28 days ago

by MichaReiser

+1.23%

Undo tracing changes

7636063

28 days ago

by MichaReiser

-0.55%

Move accumulated write outside of non-cycle branch

759f115

28 days ago

by MichaReiser

+6.35%

Inline

6e43ecd

28 days ago

by MichaReiser

Update expected test output

5e7fecf

28 days ago

by MichaReiser

-0.23%

Fix double execution

246daf0

27 days ago

by MichaReiser

+0.61%

Simplify check in `validate_same_iteration`

c1b5384

27 days ago

by MichaReiser

+0.05%

Some more inline

545b0e3

27 days ago

by MichaReiser

+7.51%

Pass references

f39e194

27 days ago

by MichaReiser

Home Terms Privacy Docs