MichaReiser:fix-missing-iteration-inputs - Branch - salsa-rs/salsa

fix: change detection for fixpoint queries

#836Merged

Comparing

MichaReiser:fix-missing-iteration-inputs

(

f702cd5

) with

master

(

2c04176

)

-10%

Regressions: 1
(
1
)

Untouched: 11

Benchmarks

Passed

amortized[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[InternedInput]

+2%

3.2 µs3.2 µs

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[SupertypeInput]

16.3 µs16.3 µs

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[SupertypeInput]

3.9 µs3.9 µs

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs::many_tracked_structs

36.7 µs36.8 µs

accumulator

benches/accumulator.rs::benches::accumulator::accumulator

3.9 ms3.9 ms

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[Input]

-1%

3.2 µs3.3 µs

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::new[Input]

-1%

9.7 µs9.7 µs

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[InternedInput]

-2%

5.4 µs5.5 µs

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[30]

-2%

13.6 µs13.9 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[20]

-2%

13.5 µs13.8 µs

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[10]

-2%

13.2 µs13.6 µs

converge_divergeRegression

benches/dataflow.rs::benches::dataflow::converge_diverge

-10%

129.8 µs144.9 µs

Commits

Click on a commit to change the comparison range

Base

master

2c04176

-11.1%

Pass provisional as old memo to `execute_query` during fixpoint

22a383b

5 months ago

by MichaReiser

+0.07%

Remove `provisional` from remove stale output

8304576

5 months ago

by MichaReiser

+0.48%

Revert debug code

4326d49

5 months ago

by MichaReiser

Clean up tests

3db05ed

5 months ago

by MichaReiser

+0.04%

Fix for direct enclosing query

f268ef0

5 months ago

by MichaReiser

+4.53%

Format

79b9317

5 months ago

by MichaReiser

More comment fiddling

dce29e3

5 months ago

by MichaReiser

-4.53%

Revert copy only outputs change

ecf8d8e

5 months ago

by MichaReiser

Revert `fixpoint_initial` start revision change (worth its own PR)

d8ca6f3

5 months ago

by MichaReiser

+0.02%

Align fixpoint handling with Derived

7185ef3

5 months ago

by MichaReiser

+0.03%

Preserve cycle heads when returning fixpoint initial

af695e1

5 months ago

by MichaReiser

-0.09%

Always return changed for `Fixpoint::Initial`

03198bf

5 months ago

by MichaReiser

+0.1%

Keep returning unchanged in some cases

f702cd5

5 months ago

by MichaReiser

Home Terms Privacy Docs