MichaReiser:diff-tracked-structs-cycle - Branch - salsa-rs/salsa

fix: Delete not re-created tracked structs after fixpoint iteration

#979Merged

Comparing

MichaReiser:diff-tracked-structs-cycle

(

8b7e3b9

) with

master

(

411f844

)

+5%

Improvements: 2

Untouched: 10

Benchmarks

Improved

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs

+5%

2.4 µs2.3 µs

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs

+5%

3 µs2.9 µs

Passed

amortized[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs

+1%

2.3 µs2.3 µs

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs

+1%

10.2 µs10.1 µs

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs

9.4 µs9.3 µs

accumulator

benches/accumulator.rs::benches::accumulator

3.3 ms3.3 ms

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs

16.1 µs16.1 µs

converge_diverge

benches/dataflow.rs::benches::dataflow

-1%

126.1 µs127.7 µs

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

-2%

14.9 µs15.1 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

-2%

14.7 µs15 µs

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs

-2%

4.7 µs4.7 µs

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

-2%

14 µs14.2 µs

Commits

Click on a commit to change the comparison range

Base

master

411f844

-0.45%

Fix tracked structs diffing in cycles

c14ef57

4 months ago

by MichaReiser

-0.03%

Proper fix

909cf80

4 months ago

by MichaReiser

Clippy

0d7b44b

4 months ago

by MichaReiser

+0.4%

Add regression test

17e5a91

4 months ago

by MichaReiser

+0.05%

Discard changes to src/function/maybe_changed_after.rs

5561444

4 months ago

by MichaReiser

Improve comemnt

3051106

4 months ago

by MichaReiser

+5.2%

Suppress clippy error in position where I don't control the types

8b7e3b9

4 months ago

by MichaReiser

Home Terms Privacy Docs