MichaReiser:avoid-panic-in-backtrace-capture - Branch - salsa-rs/salsa

bug: Avoid panic in `Backtrace::catpure` if `query_stack` is already mutably borrowed

#835Merged

Comparing

MichaReiser:avoid-panic-in-backtrace-capture

(

c46f2e7

) with

master

(

5b5e982

)

Improvements: 0

Regressions: 0

Untouched: 12

New: 0

Dropped: 0

Ignored: 0

Benchmarks

Passed

amortized[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[InternedInput]

+3%

3.2 µs

3.1 µs

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[SupertypeInput]

+1%

16.4 µs

16.2 µs

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::new[Input]

+1%

9.7 µs

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs::many_tracked_structs

36.7 µs

36.6 µs

accumulator

benches/accumulator.rs::benches::accumulator::accumulator

3.9 ms

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[InternedInput]

5.4 µs

converge_diverge

benches/dataflow.rs::benches::dataflow::converge_diverge

129.5 µs

129.7 µs

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[30]

13.5 µs

13.6 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[20]

13.4 µs

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[10]

13.2 µs

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[Input]

-1%

3.2 µs

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[SupertypeInput]

-2%

3.8 µs

3.9 µs

Commits

Click on a commit to change the comparison range

Base

master

5b5e982

bug: Avoid panic in `Backtrace::capture` if `query_stack` is already borrowed

c46f2e7

2 months ago

by MichaReiser

Home Terms Privacy Docs