ChayimFriedman2:update-interned - Branch - salsa-rs/salsa

Require interned structs' fields to be `Update`

#1036Merged

Comparing

ChayimFriedman2:update-interned

(

0f5be17

) with

master

(

55e5e7d

)

Untouched: 13

Benchmarks

Passed

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs

+3%

4.5 µs4.4 µs

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs

+1%

2.2 µs2.2 µs

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

14.2 µs14.1 µs

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

14.7 µs14.7 µs

converge_diverge_nested

benches/dataflow.rs::benches::nested

116.5 µs116.1 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

14.9 µs14.8 µs

accumulator

benches/accumulator.rs::benches::accumulator

3.4 ms3.4 ms

amortized[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs

2.1 µs2.1 µs

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs

9 µs9 µs

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs

16.4 µs16.4 µs

converge_diverge

benches/dataflow.rs::benches::dataflow

-1%

151.6 µs152.4 µs

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs

-3%

10.3 µs10.5 µs

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs

-4%

2.9 µs3 µs

Commits

Click on a commit to change the comparison range

Base

master

55e5e7d

-0.1%

Require interned structs' fields to be `Update` To fix an unsoundness - #985. There are two breaking changes here: 1. Interned fields and interned function fields are required to be `Update` (or `'static`) 2. `unsafe(non_update_return_types)` in tracked fn options was renamed to `unsafe(non_update_types)` (and includes interned parameters as well now).

0f5be17

6 days ago

by ChayimFriedman2

Home Terms Privacy Docs