ChayimFriedman2:size-analysis-improved - Branch - salsa-rs/salsa

feat: Improve unstable size analysis support

#935Closed

Comparing

ChayimFriedman2:size-analysis-improved

(

d0ceeb4

) with

master

(

d28d66b

)

-6%

Regressions: 1

Untouched: 11

Benchmarks

Failed

amortized[InternedInput]Regression

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[InternedInput]

-6%

3.4 µs3.6 µs

Passed

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::new[Input]

+3%

10.5 µs10.2 µs

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[10]

+2%

14 µs13.7 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[20]

+2%

14.2 µs14 µs

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[30]

+2%

14.3 µs14 µs

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[SupertypeInput]

+1%

17.6 µs17.4 µs

converge_diverge

benches/dataflow.rs::benches::dataflow::converge_diverge

141.6 µs141.4 µs

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[Input]

3.5 µs3.5 µs

accumulator

benches/accumulator.rs::benches::accumulator::accumulator

3.8 ms3.8 ms

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs::many_tracked_structs

37.2 µs37.2 µs

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs::amortized[SupertypeInput]

-1%

4.1 µs4.2 µs

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs::new[InternedInput]

-2%

5.8 µs5.9 µs

Commits

Click on a commit to change the comparison range

Base

master

d28d66b

-5.56%

Improve unstable size analysis support 1. Include an option `panic_if_missing` that will panic if there is an ingredient with no `heap_size()` defined, to ensure coverage. 2. Add `heap_size()` to tracked structs, interneds an inputs.

d0ceeb4

2 months ago

by ChayimFriedman2

Home Terms Privacy Docs