ChayimFriedman2:deadlock - Branch - salsa-rs/salsa

Revert #958

#1039Merged

Comparing

ChayimFriedman2:deadlock

(

0f3b30a

) with

master

(

0a3eec6

)

+4%

Untouched: 13

Benchmarks

Passed

amortized[Input]

benches/compare.rs::benches::inputs::Mutating Inputs

+4%

2.2 µs2.1 µs

new[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs

+1%

4.3 µs4.3 µs

amortized[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs

+1%

3 µs2.9 µs

mutating[10]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

+1%

14.4 µs14.3 µs

mutating[30]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

+1%

14.9 µs14.9 µs

mutating[20]

benches/compare.rs::benches::mutating_inputs::Mutating Inputs

+1%

15.1 µs15 µs

new[Input]

benches/compare.rs::benches::inputs::Mutating Inputs

10.7 µs10.7 µs

new[SupertypeInput]

benches/compare.rs::benches::inputs::Mutating Inputs

16.4 µs16.4 µs

accumulator

benches/accumulator.rs::benches::accumulator

3.4 ms3.4 ms

amortized[InternedInput]

benches/compare.rs::benches::inputs::Mutating Inputs

2.1 µs2.1 µs

converge_diverge

benches/dataflow.rs::benches::dataflow

152.1 µs152.4 µs

converge_diverge_nested

benches/dataflow.rs::benches::nested

115.9 µs116.2 µs

many_tracked_structs

benches/incremental.rs::benches::many_tracked_structs

-2%

9 µs9.1 µs

Commits

Click on a commit to change the comparison range

Base

master

0a3eec6

+4.12%

Revert #958 This PR can create deadlocks - there is nothing synchronizing the mutex/condvar with the `Arc` of the `Zalsa`, therefore code may wake up by the `Condvar` but not see an updated refcount, go to sleep again, and never wake up.

0f3b30a

5 days ago

by ChayimFriedman2

Home Terms Privacy Docs