Add a third cycle mode, equivalent to old Salsa cycle behavior
#801Comparing
ChayimFriedman2:cycle-no-fixpoint
(5f6e95e
) withmaster
(ab7ecb4
)+4%
- Improvements
- 1
- Regressions
- 0
- Untouched
- 11
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Improved
amortized[Input]
benches/compare.rs::benches::inputs::Mutating Inputs::amortized[Input]+4%
3.5 µs
3.4 µs
Passed
new[Input]
benches/compare.rs::benches::inputs::Mutating Inputs::new[Input]+1%
10.4 µs
10.4 µs
new[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs::new[InternedInput]+1%
5.8 µs
5.8 µs
many_tracked_structs
benches/incremental.rs::benches::many_tracked_structs::many_tracked_structs0%
38.3 µs
38.2 µs
new[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs::new[SupertypeInput]0%
17 µs
17 µs
accumulator
benches/accumulator.rs::benches::accumulator::accumulator0%
4.3 ms
4.3 ms
amortized[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs::amortized[InternedInput]0%
3.4 µs
3.4 µs
converge_diverge
benches/dataflow.rs::benches::dataflow::converge_diverge0%
137.7 µs
137.7 µs
mutating[30]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[30]0%
14.1 µs
14.1 µs
mutating[20]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[20]0%
14 µs
14 µs
mutating[10]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[10]0%
13.8 µs
13.8 µs
amortized[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs::amortized[SupertypeInput]-4%
4 µs
4.1 µs
Commits
Click on a commit to change the comparison rangeBase
master
ab7ecb4
+4%
Add a third cycle mode, equivalent to old Salsa cycle behavior
That is, directly set a value for the cycle head, and ignore all other queries in the cycle.
Unlike old Salsa, we still need all cycle heads to be marked, and we still execute the queries to completion, but we throw their result.
5f6e95e
2 days ago
by ChayimFriedman2