Avatar for the salsa-rs user
salsa-rs
salsa
BlogDocsChangelog

Add a third cycle mode, equivalent to old Salsa cycle behavior

#801Merged
Comparing
ChayimFriedman2:cycle-no-fixpoint
(
f61f973
) with
master
(
3b84ac4
)
CodSpeed Performance Gauge
-6%
Regressions
1
(
1
)
Untouched
11

Benchmarks

Passed

amortized[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs::amortized[InternedInput]
CodSpeed Performance Gauge
+1%
3.3 µs3.3 µs
amortized[Input]
benches/compare.rs::benches::inputs::Mutating Inputs::amortized[Input]
CodSpeed Performance Gauge
+1%
3.4 µs3.3 µs
new[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs::new[InternedInput]
CodSpeed Performance Gauge
+1%
5.6 µs5.5 µs
accumulator
benches/accumulator.rs::benches::accumulator::accumulator
CodSpeed Performance Gauge
0%
4.3 ms4.3 ms
converge_diverge
benches/dataflow.rs::benches::dataflow::converge_diverge
CodSpeed Performance Gauge
0%
132.6 µs132.6 µs
mutating[30]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[30]
CodSpeed Performance Gauge
0%
13.8 µs13.8 µs
mutating[20]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[20]
CodSpeed Performance Gauge
0%
13.6 µs13.6 µs
mutating[10]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs::mutating[10]
CodSpeed Performance Gauge
0%
13.5 µs13.5 µs
many_tracked_structs
benches/incremental.rs::benches::many_tracked_structs::many_tracked_structs
CodSpeed Performance Gauge
-1%
36.7 µs37 µs
new[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs::new[SupertypeInput]
CodSpeed Performance Gauge
-1%
16.3 µs16.5 µs
new[Input]
benches/compare.rs::benches::inputs::Mutating Inputs::new[Input]
CodSpeed Performance Gauge
-2%
10 µs10.1 µs
amortized[SupertypeInput]Regression
benches/compare.rs::benches::inputs::Mutating Inputs::amortized[SupertypeInput]
CodSpeed Performance Gauge
-6%
3.8 µs4 µs

Commits

Click on a commit to change the comparison range
Base
master
3b84ac4
-5.79%
Add a third cycle mode, equivalent to old Salsa cycle behavior That is, directly set a value for all queries that have fallbacks, and ignore all other queries in the cycle. Unlike old Salsa, we still need all cycle heads to be marked, and we still execute the queries to completion, but we throw their result.
f61f973
5 months ago
by ChayimFriedman2
© 2025 CodSpeed Technology
Home Terms Privacy Docs