masenf/flaky-ensure-task-limit-window-passed - Branch - reflex-dev/reflex

Flaky test test_ensure_task_limit_window_passed

#5959

Comparing

masenf/flaky-ensure-task-limit-window-passed

(

ef625bf

) with

main

(

fd6e111

)

+1%

Untouched: 8

Benchmarks

Passed

test_get_all_imports[_stateful_page]

tests/benchmarks/test_compilation.py

+2%

3.1 ms3 ms

test_get_all_imports[_complicated_page]

tests/benchmarks/test_compilation.py

+2%

22.8 ms22.5 ms

test_compile_page[_stateful_page]

tests/benchmarks/test_compilation.py

+1%

10.5 ms10.4 ms

test_compile_page[_complicated_page]

tests/benchmarks/test_compilation.py

+1%

88.8 ms88.2 ms

test_evaluate_page[_stateful_page]

tests/benchmarks/test_evaluate.py

6.5 ms6.5 ms

test_evaluate_page[_complicated_page]

tests/benchmarks/test_evaluate.py

46.3 ms46.2 ms

test_compile_stateful[_stateful_page]

tests/benchmarks/test_compilation.py

151.7 µs151.8 µs

test_compile_stateful[_complicated_page]

tests/benchmarks/test_compilation.py

582.8 µs583.5 µs

Commits

Click on a commit to change the comparison range

Base

main

fd6e111

+0.66%

Flaky test test_ensure_task_limit_window_passed Try to make the test less flaky by making the iteration wait time equal to the exception_limit_window and reducing the exception_limit from 3 to 2. This should still catch the case in question, but be less timing dependent.

ef625bf

2 days ago

by masenf

Home Terms Privacy Docs