masenf/fetch-missing-substates-oplock - Branch - reflex-dev/reflex

ENG-8388: refetch cached state when missing substates

#5991Merged

Comparing

masenf/fetch-missing-substates-oplock

(

08745be

) with

main

(

a987437

)

Untouched: 8

Benchmarks

Passed

test_get_all_imports[_stateful_page]

tests/benchmarks/test_compilation.py

3.1 ms3 ms

test_compile_page[_stateful_page]

tests/benchmarks/test_compilation.py

10.4 ms10.4 ms

test_evaluate_page[_complicated_page]

tests/benchmarks/test_evaluate.py

46.1 ms46.1 ms

test_compile_page[_complicated_page]

tests/benchmarks/test_compilation.py

88 ms88 ms

test_get_all_imports[_complicated_page]

tests/benchmarks/test_compilation.py

22.4 ms22.4 ms

test_evaluate_page[_stateful_page]

tests/benchmarks/test_evaluate.py

6.5 ms6.5 ms

test_compile_stateful[_complicated_page]

tests/benchmarks/test_compilation.py

593.9 µs595.1 µs

test_compile_stateful[_stateful_page]

tests/benchmarks/test_compilation.py

147 µs147.7 µs

Commits

Click on a commit to change the comparison range

Base

main

a987437

+0.01%

ENG-8388: refetch cached state when missing substates Avoid issue where hydrate operates on a subset of the tree because the Root state was requested, but it didn't have all its substates cached, so it doesn't return the full dict.

08745be

2 months ago

by masenf

Home Terms Privacy Docs