masenf/dep-tracker-limit-import-scope - Branch - reflex-dev/reflex

DependencyTracker: only handle STORE_FAST for the GETTING_IMPORT status

#6058

Comparing

masenf/dep-tracker-limit-import-scope

(

6d38f3b

) with

main

(

488a388

)

Untouched: 8

Benchmarks

Passed

test_compile_stateful[_complicated_page]

tests/benchmarks/test_compilation.py

604.1 µs603.6 µs

test_compile_page[_complicated_page]

tests/benchmarks/test_compilation.py

91.4 ms91.4 ms

test_evaluate_page[_complicated_page]

tests/benchmarks/test_evaluate.py

47.6 ms47.5 ms

test_compile_page[_stateful_page]

tests/benchmarks/test_compilation.py

10.8 ms10.8 ms

test_compile_stateful[_stateful_page]

tests/benchmarks/test_compilation.py

151.1 µs151.3 µs

test_evaluate_page[_stateful_page]

tests/benchmarks/test_evaluate.py

6.5 ms6.5 ms

test_get_all_imports[_complicated_page]

tests/benchmarks/test_compilation.py

22.9 ms23 ms

test_get_all_imports[_stateful_page]

tests/benchmarks/test_compilation.py

-1%

3.1 ms3.1 ms

Commits

Click on a commit to change the comparison range

Base

main

488a388

-0.16%

DependencyTracker: only handle STORE_FAST for the GETTING_IMPORT status STORE_FAST handling is not generally correct outside of the specific case of dealing with imports. So avoid resetting the stack or other issues when we're not importing.

6d38f3b

11 hours ago

by masenf

Home Terms Privacy Docs