masenf/async-with-self-rebind - Branch - reflex-dev/reflex

ENG-8507: rebind MutableProxy when it is linked to an old _self_state reference

#6048Merged

Comparing

masenf/async-with-self-rebind

(

3023661

) with

main

(

bd1f7c6

)

Untouched: 8

Benchmarks

Passed

test_get_all_imports[_complicated_page]

tests/benchmarks/test_compilation.py

+1%

22.9 ms22.7 ms

test_compile_stateful[_stateful_page]

tests/benchmarks/test_compilation.py

+1%

151.5 µs150.8 µs

test_compile_page[_complicated_page]

tests/benchmarks/test_compilation.py

91.2 ms91 ms

test_evaluate_page[_stateful_page]

tests/benchmarks/test_evaluate.py

6.5 ms6.5 ms

test_get_all_imports[_stateful_page]

tests/benchmarks/test_compilation.py

3.1 ms3.1 ms

test_compile_stateful[_complicated_page]

tests/benchmarks/test_compilation.py

605.1 µs605.5 µs

test_evaluate_page[_complicated_page]

tests/benchmarks/test_evaluate.py

47.3 ms47.3 ms

test_compile_page[_stateful_page]

tests/benchmarks/test_compilation.py

10.8 ms10.8 ms

Commits

Click on a commit to change the comparison range

Base

main

bd1f7c6

-0.44%

ENG-8507: rebind MutableProxy when it is linked to an old _self_state reference Avoids an issue where MutableProxy references are saved in the state, then when accessing them again, they reference the wrong StateProxy. So even though the code enters `async with self`, the StateProxy that is marked mutable is NOT the StateProxy associated with the value. With this change, anytime a MutableProxy is accessed through a StateProxy, its state reference is reset to the current StateProxy before returning it.

2480363

26 days ago

by masenf

+0.61%

fix test for oplock enabled

3023661

25 days ago

by masenf

Home Terms Privacy Docs