don't use reserve words for variable names
#5251Comparing
khaleel/eng-5649-foreach-with-var-name-that-shadows-js-keyword-blows-up
(cf0cc12
) withmain
(96ff0b5
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 8
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
test_compile_stateful[_stateful_page]
tests/benchmarks/test_compilation.py::test_compile_stateful[_stateful_page]+1%
343.1 µs
340.6 µs
test_compile_page[_stateful_page]
tests/benchmarks/test_compilation.py::test_compile_page[_stateful_page]0%
15 ms
15 ms
test_get_all_imports[_stateful_page]
tests/benchmarks/test_compilation.py::test_get_all_imports[_stateful_page]0%
3.8 ms
3.8 ms
test_evaluate_page[_complicated_page]
tests/benchmarks/test_evaluate.py::test_evaluate_page[_complicated_page]0%
55.3 ms
55.3 ms
test_compile_stateful[_complicated_page]
tests/benchmarks/test_compilation.py::test_compile_stateful[_complicated_page]0%
1 ms
1 ms
test_compile_page[_complicated_page]
tests/benchmarks/test_compilation.py::test_compile_page[_complicated_page]0%
111.8 ms
112 ms
test_evaluate_page[_stateful_page]
tests/benchmarks/test_evaluate.py::test_evaluate_page[_stateful_page]0%
8.3 ms
8.3 ms
test_get_all_imports[_complicated_page]
tests/benchmarks/test_compilation.py::test_get_all_imports[_complicated_page]-1%
28.8 ms
29.1 ms
Commits
Click on a commit to change the comparison rangeBase
main
96ff0b5
0%
don't use reserve words for variable names
9a7d317
9 days ago
by adhami3310-1%
use underscore suffix instead
4fe0fe0
9 days ago
by adhami33100%
fix various places that got the wrong name
9473762
9 days ago
by adhami33100%
fix the test
4b5899d
9 days ago
by adhami3310-1%
fix unit tests
97d15b3
9 days ago
by adhami3310+1%
fix dynamic components
449c00c
9 days ago
by adhami33100%
i don't know how to do inheritance
826c5d3
9 days ago
by adhami33100%
maybe
c3c4181
9 days ago
by adhami33100%
remove that suffix
ac29df2
9 days ago
by adhami33100%
ok we can't do that
bc8cc41
9 days ago
by adhami33100%
add something to update vars internal
af74e9f
9 days ago
by adhami33100%
fix dynamic route
db4aa45
8 days ago
by adhami33100%
Merge branch 'main' into khaleel/eng-5649-foreach-with-var-name-that-shadows-js-keyword-blows-up
02f60a5
4 days ago
by adhami33100%
fix unit tests
ec07336
4 days ago
by adhami33100%
fix is hydrated
cf0cc12
4 days ago
by adhami3310