Peter554:cache-write-data-map-file - Branch - python-grimp/grimp

Cache: Write data map file from rust

#259Merged

Comparing

Peter554:cache-write-data-map-file

(

6e854ec

) with

main

(

558fc35

)

-13%

Regressions: 1

Untouched: 25

Skipped: 23

Benchmarks

Skipped (23)

These benchmarks were skipped, so their baseline results are used instead. If they were deleted in your codebase, archive them to remove them from the performance reports.
Learn more about archiving benchmarks

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_deep_layers_large_graph_violated

tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers

Skipped

12.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_deep_layers_large_graph_kept

tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers

Skipped

20.3 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_top_level_large_graph_violated

tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers

Skipped

233.9 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_top_level_large_graph_kept

tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers

Skipped

48.7 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_copy_graph

tests/benchmarking/test_benchmarking.py

Skipped

54.9 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_chain_found

tests/benchmarking/test_benchmarking.py::TestFindShortestChain

Skipped

61.4 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_chains_found

tests/benchmarking/test_benchmarking.py::TestFindShortestChains

Skipped

178 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_find_matching_direct_imports

tests/benchmarking/test_benchmarking.py

Skipped

34.9 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_find_matching_modules

tests/benchmarking/test_benchmarking.py

Skipped

9.1 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_find_upstream_modules

tests/benchmarking/test_benchmarking.py

Skipped

3.4 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_get_import_details

tests/benchmarking/test_benchmarking.py

Skipped

233.7 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_modules_property_first_access

tests/benchmarking/test_benchmarking.py

Skipped

33.5 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_build_django_from_cache_a_few_misses[15]

tests/benchmarking/test_benchmarking.py

Skipped

129.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_chains_found_sparse_imports

tests/benchmarking/test_benchmarking.py::TestFindShortestChains

Skipped

366.2 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_no_chain

tests/benchmarking/test_benchmarking.py::TestFindShortestChain

Skipped

1.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_no_chains

tests/benchmarking/test_benchmarking.py::TestFindShortestChains

Skipped

1.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_find_descendants

tests/benchmarking/test_benchmarking.py

Skipped

35.1 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_build_django_from_cache_a_few_misses[350]

tests/benchmarking/test_benchmarking.py

Skipped

227 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_modules_property_many_accesses

tests/benchmarking/test_benchmarking.py

Skipped

33.9 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_find_downstream_modules

tests/benchmarking/test_benchmarking.py

Skipped

173.5 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_build_django_from_cache_a_few_misses[2]

tests/benchmarking/test_benchmarking.py

Skipped

125.4 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_build_django_uncached

tests/benchmarking/test_benchmarking.py

Skipped

548 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

test_build_django_from_cache_no_misses

tests/benchmarking/test_benchmarking.py

Skipped

124.9 ms*

Failed

Uses the Wall Time instrument
to collect wall time performance metrics.

test_get_import_details

tests/benchmarking/test_benchmarking.py

Regression

-13%

153.6 µs177.1 µs

Passed

Uses the Wall Time instrument
to collect wall time performance metrics.

test_chain_found

tests/benchmarking/test_benchmarking.py::TestFindShortestChain

+2%

16.8 µs16.6 µs

Uses the Wall Time instrument
to collect wall time performance metrics.

test_nominate_cycle_breakers_django

tests/benchmarking/test_benchmarking.py

+1%

7.7 ms7.7 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_no_chains

tests/benchmarking/test_benchmarking.py::TestFindShortestChains

682.6 µs680.1 µs

Uses the Wall Time instrument
to collect wall time performance metrics.

test_no_chain

tests/benchmarking/test_benchmarking.py::TestFindShortestChain

680.8 µs678.9 µs

Uses the Wall Time instrument
to collect wall time performance metrics.

test_deep_layers_large_graph_kept

tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers

1.6 ms1.6 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_nominate_cycle_breakers_large_graph_root

tests/benchmarking/test_benchmarking.py

413 ms413.1 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_copy_graph

tests/benchmarking/test_benchmarking.py

79.9 ms80 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_top_level_large_graph_kept

tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers

17.7 ms17.8 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_top_level_large_graph_violated

tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers

171.6 ms172.3 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_nominate_cycle_breakers_large_graph_subpackage

tests/benchmarking/test_benchmarking.py

181.9 ms182.8 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_deep_layers_large_graph_violated

tests/benchmarking/test_benchmarking.py::TestFindIllegalDependenciesForLayers

-1%

1.6 ms1.6 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_chains_found

tests/benchmarking/test_benchmarking.py::TestFindShortestChains

-1%

86.5 µs87.3 µs

Uses the Wall Time instrument
to collect wall time performance metrics.

test_build_django_uncached

tests/benchmarking/test_benchmarking.py

-1%

154.3 ms155.8 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_find_downstream_modules

tests/benchmarking/test_benchmarking.py

-2%

78.4 µs80 µs

Uses the Wall Time instrument
to collect wall time performance metrics.

test_chains_found_sparse_imports

tests/benchmarking/test_benchmarking.py::TestFindShortestChains

-3%

217.7 µs224 µs

Uses the Wall Time instrument
to collect wall time performance metrics.

test_find_matching_modules

tests/benchmarking/test_benchmarking.py

-3%

6.1 ms6.3 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_find_matching_direct_imports

tests/benchmarking/test_benchmarking.py

-3%

27.4 ms28.3 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_find_descendants

tests/benchmarking/test_benchmarking.py

-3%

38 ms39.3 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_modules_property_many_accesses

tests/benchmarking/test_benchmarking.py

-4%

29.8 ms30.9 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_modules_property_first_access

tests/benchmarking/test_benchmarking.py

-4%

29.4 ms30.6 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_build_django_from_cache_a_few_misses[350]

tests/benchmarking/test_benchmarking.py

-5%

267.8 ms281.3 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_build_django_from_cache_no_misses

tests/benchmarking/test_benchmarking.py

-5%

135.6 ms142.6 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_find_upstream_modules

tests/benchmarking/test_benchmarking.py

-5%

2.5 ms2.7 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_build_django_from_cache_a_few_misses[2]

tests/benchmarking/test_benchmarking.py

-6%

140.2 ms148.3 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

test_build_django_from_cache_a_few_misses[15]

tests/benchmarking/test_benchmarking.py

-6%

145.2 ms154 ms

Commits

Click on a commit to change the comparison range

Base

main

558fc35

-14.08%

Remove eprint! statements Pretty sure these were just added for debugging.

23f35b1

2 months ago

by Peter554

-0.34%

Simplify write method by chaining operations Combine File::create() and write_all() into a single chained expression without intermediate variables, and use map_err for error conversion. This results in more concise and idiomatic Rust code. Addresses PR comment: https://github.com/python-grimp/grimp/pull/259#discussion_r2486635845 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

a25e6df

2 months ago

by Peter554

+2.27%

Implement FromPyObject for ImportsByModule Replace the imports_by_module_to_rust helper function with a more idiomatic Rust approach by implementing FromPyObject trait for an ImportsByModule newtype wrapper. This allows using .extract() directly, making the code more ergonomic and following Rust best practices similar to DirectImport. The new ImportsByModule wrapper encapsulates HashMap<Module, HashSet<DirectImport>> and provides automatic conversion from Python dict objects. Addresses PR comment: https://github.com/python-grimp/grimp/pull/259#discussion_r2486413276 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

c8e353a

2 months ago

by Peter554

-1.08%

Make internal types and functions private Make implementation details private to reduce the public API surface: In filesystem.rs: - RealBasicFileSystem and FakeBasicFileSystem structs - Their inner fields - parse_indented_file_system_string function In import_scanning.rs: - py_found_packages_to_rust function - get_modules_from_found_packages function - scan_for_imports_no_py function - to_py_direct_imports function Only the Python-facing wrapper structs (PyRealBasicFileSystem, PyFakeBasicFileSystem) and the exported Python functions remain public. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

6e854ec

2 months ago

by Peter554

Home Terms Privacy Docs