lukapeschke:fix-union-of-unions-serializer - Branch - pydantic/pydantic-core

fix(union_serializer): do not raise warnings in nested unions

#1513Merged

Comparing

lukapeschke:fix-union-of-unions-serializer

(

5506e1f

) with

main

(

4cb82bf

)

Untouched: 155

Benchmarks

Passed

test_strict_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+7%

17.3 µs16.1 µs

test_dict_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

+4%

1.4 ms1.4 ms

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+4%

31.5 µs30.2 µs

test_build_schema

tests/benchmarks/test_complete_benchmark.py

+2%

744.8 µs729.5 µs

test_date_from_datetime_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+2%

18 µs17.8 µs

test_tagged_union_int_keys_json

tests/benchmarks/test_micro_benchmarks.py

+1%

24.7 µs24.3 µs

test_int_range_json

tests/benchmarks/test_micro_benchmarks.py

+1%

15.5 µs15.3 µs

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

13.6 µs13.4 µs

test_core_model_json

tests/benchmarks/test_serialization_micro.py

+1%

25.1 µs24.8 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

17.9 µs17.7 µs

test_validate_literal[json-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

+1%

18.1 µs17.9 µs

test_validate_literal[python-few_ints]

tests/benchmarks/test_micro_benchmarks.py

+1%

14.3 µs14.1 µs

test_chain_list

tests/benchmarks/test_micro_benchmarks.py

+1%

24.4 µs24.2 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

18.5 µs18.3 µs

test_validate_literal[json-many_ints]

tests/benchmarks/test_micro_benchmarks.py

+1%

15.2 µs15.1 µs

test_generator_python

tests/benchmarks/test_micro_benchmarks.py

+1%

22.4 µs22.2 µs

test_date_from_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

15.7 µs15.6 µs

test_validate_literal[python-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

+1%

16.5 µs16.4 µs

test_many_models_core_dict

tests/benchmarks/test_micro_benchmarks.py

+1%

957.7 µs949.5 µs

test_date_format_function_no_info

tests/benchmarks/test_serialization_micro.py

+1%

50.9 µs50.4 µs

test_decimal_from_string_limit

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

+1%

18.2 µs18.1 µs

test_validate_literal[json-few_ints]

tests/benchmarks/test_micro_benchmarks.py

+1%

15.3 µs15.2 µs

test_validate_literal[json-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

+1%

19.8 µs19.6 µs

test_dataclass_serialization_json

tests/benchmarks/test_serialization_micro.py

+1%

24.3 µs24.1 µs

test_model_instance_abc

tests/benchmarks/test_micro_benchmarks.py

+1%

28.5 µs28.3 µs

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

42.1 µs41.8 µs

test_dont_raise_error_no_info

tests/benchmarks/test_micro_benchmarks.py

+1%

17 µs16.9 µs

test_set_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

+1%

885.9 µs880.1 µs

test_core_json

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

+1%

79.9 µs79.4 µs

test_to_string_direct

tests/benchmarks/test_serialization_micro.py

+1%

18.2 µs18 µs

test_isinstance_json

tests/benchmarks/test_micro_benchmarks.py

+1%

17.6 µs17.5 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

18.1 µs18 µs

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

+1%

105.7 µs105 µs

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

13.8 µs13.7 µs

test_smart_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

15.5 µs15.4 µs

test_set_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

+1%

718.3 µs714.4 µs

test_validate_literal[json-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

15.7 µs15.6 µs

test_list_of_dict_models_core

tests/benchmarks/test_micro_benchmarks.py

+1%

91.9 µs91.4 µs

test_list_of_ints_core_py

tests/benchmarks/test_micro_benchmarks.py

+1%

511.7 µs509 µs

test_to_string_format

tests/benchmarks/test_serialization_micro.py

+1%

22.4 µs22.2 µs

test_json_any_list_str

tests/benchmarks/test_serialization_micro.py

+1%

229.1 µs228 µs

test_set_of_ints_core_length

tests/benchmarks/test_micro_benchmarks.py

+1%

731.8 µs728.1 µs

test_small_class_core_dict

tests/benchmarks/test_micro_benchmarks.py

18.3 µs18.2 µs

test_small_class_core_model

tests/benchmarks/test_micro_benchmarks.py

26.4 µs26.2 µs

test_list_of_strs_json_uncached

tests/benchmarks/test_micro_benchmarks.py

409 µs407.2 µs

test_core_string_strict

tests/benchmarks/test_micro_benchmarks.py

13.3 µs13.2 µs

test_core_string_lax

tests/benchmarks/test_micro_benchmarks.py

13.3 µs13.2 µs

test_list_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

741.3 µs738 µs

test_isinstance_string_lax_true

tests/benchmarks/test_micro_benchmarks.py

13.4 µs13.4 µs

test_uuid_from_uuid_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

13.6 µs13.5 µs

test_complete_core_serializer_to_json

tests/benchmarks/test_complete_benchmark.py

292.1 µs290.9 µs

test_to_json_list_of_lists

tests/benchmarks/test_serialization_micro.py

1.7 ms1.7 ms

test_bool_core

tests/benchmarks/test_micro_benchmarks.py

22.6 µs22.5 µs

test_date_from_datetime

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

21.5 µs21.4 µs

test_json_direct_list_str

tests/benchmarks/test_serialization_micro.py

163.4 µs162.8 µs

test_json_direct_list_int

tests/benchmarks/test_serialization_micro.py

134.6 µs134.1 µs

test_smart_union_coerce_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

17.1 µs17.1 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

16.5 µs16.5 µs

test_arguments

tests/benchmarks/test_micro_benchmarks.py

22.3 µs22.2 µs

test_list_of_nullable_core

tests/benchmarks/test_micro_benchmarks.py

102.3 µs102 µs

test_dataclass_serialization_python

tests/benchmarks/test_serialization_micro.py

21.3 µs21.2 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

25.5 µs25.4 µs

test_model_list_core_json

tests/benchmarks/test_serialization_micro.py

154.2 µs153.8 µs

test_chain_two_functions

tests/benchmarks/test_micro_benchmarks.py

27.9 µs27.9 µs

test_decimal_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

23.3 µs23.2 µs

test_list_of_any_core_py

tests/benchmarks/test_micro_benchmarks.py

98.6 µs98.3 µs

test_json_any_list_int

tests/benchmarks/test_serialization_micro.py

195.6 µs195.2 µs

test_core_model_json_extra

tests/benchmarks/test_serialization_micro.py

28.7 µs28.6 µs

test_date_from_date

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

13.7 µs13.7 µs

test_validate_literal[python-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

14.3 µs14.3 µs

test_list_of_strs_json_cached

tests/benchmarks/test_micro_benchmarks.py

298.2 µs297.6 µs

test_validate_literal[python-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

14.9 µs14.9 µs

test_dict_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

1 ms1 ms

test_complete_core_serializer_to_python

tests/benchmarks/test_complete_benchmark.py

260.3 µs259.8 µs

test_isinstance_string_strict_false

tests/benchmarks/test_micro_benchmarks.py

14.8 µs14.7 µs

test_complete_core_json

tests/benchmarks/test_complete_benchmark.py

439.6 µs438.9 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

128.7 µs128.5 µs

test_validate_literal[json-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

15.7 µs15.7 µs

test_validate_literal[json-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

15.8 µs15.8 µs

test_core_python_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

68.3 µs68.1 µs

test_chain_nested_functions

tests/benchmarks/test_micro_benchmarks.py

28.1 µs28 µs

test_dont_raise_error

tests/benchmarks/test_micro_benchmarks.py

19.2 µs19.2 µs

test_datetime

tests/benchmarks/test_serialization_micro.py

26.7 µs26.6 µs

test_uuid_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

47.7 µs47.7 µs

test_enum_str_python

tests/benchmarks/test_micro_benchmarks.py

23.2 µs23.2 µs

test_nested_schema_using_defs

tests/benchmarks/test_nested_benchmark.py

15.4 ms15.4 ms

test_uuid

tests/benchmarks/test_serialization_micro.py

22.9 µs22.9 µs

test_with_default

tests/benchmarks/test_micro_benchmarks.py

22.3 µs22.3 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

26.2 µs26.1 µs

test_chain_function

tests/benchmarks/test_micro_benchmarks.py

24.1 µs24.1 µs

test_frozenset_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

244.4 µs244.2 µs

test_nested_schema_inlined

tests/benchmarks/test_nested_benchmark.py

16 ms16 ms

test_set_of_ints_core_duplicates

tests/benchmarks/test_micro_benchmarks.py

348.3 µs348.1 µs

test_list_of_strs_py_cached

tests/benchmarks/test_micro_benchmarks.py

120.8 µs120.7 µs

test_frozenset_of_ints_duplicates_core

tests/benchmarks/test_micro_benchmarks.py

170.8 µs170.7 µs

test_python_json_list_none

tests/benchmarks/test_serialization_micro.py

121.1 µs121.1 µs

test_python_json_list_str

tests/benchmarks/test_serialization_micro.py

154.6 µs154.6 µs

test_validate_literal[python-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

14.3 µs14.3 µs

test_int_error

tests/benchmarks/test_micro_benchmarks.py

40 µs40 µs

test_complete_core_strict

tests/benchmarks/test_complete_benchmark.py

250.4 µs250.4 µs

test_enum_int_python

tests/benchmarks/test_micro_benchmarks.py

23.4 µs23.4 µs

test_bytes_core

tests/benchmarks/test_micro_benchmarks.py

13.3 µs13.3 µs

test_strict_int

tests/benchmarks/test_micro_benchmarks.py

13.2 µs13.2 µs

test_enum_int_core

tests/benchmarks/test_micro_benchmarks.py

15 µs15 µs

test_dict_of_any_core

tests/benchmarks/test_micro_benchmarks.py

712.6 µs712.6 µs

test_ser_list_of_lists

tests/benchmarks/test_serialization_micro.py

1.2 ms1.2 ms

test_date_format_function

tests/benchmarks/test_serialization_micro.py

52.2 µs52.2 µs

test_int_range

tests/benchmarks/test_micro_benchmarks.py

14.3 µs14.3 µs

test_definition_out_of_tree

tests/benchmarks/test_micro_benchmarks.py

989 µs989.1 µs

test_enum_str_core

tests/benchmarks/test_micro_benchmarks.py

14.7 µs14.7 µs

test_raise_error_custom

tests/benchmarks/test_micro_benchmarks.py

37.1 µs37.1 µs

test_definition_in_tree

tests/benchmarks/test_micro_benchmarks.py

726.7 µs726.9 µs

test_core_model_py_extra

tests/benchmarks/test_serialization_micro.py

29.4 µs29.4 µs

test_python_json_list_int

tests/benchmarks/test_serialization_micro.py

148.1 µs148.3 µs

test_raise_error_value_error

tests/benchmarks/test_micro_benchmarks.py

36 µs36 µs

test_filter

tests/benchmarks/test_serialization_micro.py

41.4 µs41.5 µs

test_dataclass_to_json

tests/benchmarks/test_serialization_micro.py

38.2 µs38.3 µs

test_core_string_strict_wrong_str_e

tests/benchmarks/test_micro_benchmarks.py

39.6 µs39.7 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

32.3 µs32.3 µs

test_definition_model_core

tests/benchmarks/test_micro_benchmarks.py

1.1 ms1.1 ms

test_complete_core_lax

tests/benchmarks/test_complete_benchmark.py

272.7 µs273.2 µs

test_validate_literal[python-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

14.4 µs14.5 µs

test_core_dict_filter

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

78 µs78.1 µs

test_isinstance_string_lax_false

tests/benchmarks/test_micro_benchmarks.py

15.1 µs15.1 µs

test_validate_literal[python-many_ints]

tests/benchmarks/test_micro_benchmarks.py

14.2 µs14.3 µs

test_core_string_lax_wrong

tests/benchmarks/test_micro_benchmarks.py

27 µs27.1 µs

test_model_instance

tests/benchmarks/test_micro_benchmarks.py

27.9 µs28 µs

test_strict_int_fails

tests/benchmarks/test_micro_benchmarks.py

26.6 µs26.6 µs

test_uuid_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

32.3 µs32.4 µs

test_core_dict

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

72.1 µs72.3 µs

test_set_of_ints_core_json_duplicates

tests/benchmarks/test_micro_benchmarks.py

434.6 µs435.9 µs

test_validate_literal[json-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

15.8 µs15.9 µs

test_core_string_strict_wrong

tests/benchmarks/test_micro_benchmarks.py

26.8 µs26.9 µs

test_tuple_many_positional

tests/benchmarks/test_micro_benchmarks.py

17.4 µs17.4 µs

test_core_model_py

tests/benchmarks/test_serialization_micro.py

25.8 µs25.9 µs

test_model_exclude_unset_false

tests/benchmarks/test_serialization_micro.py

29 µs29.2 µs

test_uuid_from_uuid_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

14.3 µs14.4 µs

test_tagged_union_int_keys_python

tests/benchmarks/test_micro_benchmarks.py

20.1 µs20.2 µs

test_isinstance_string_strict_true

tests/benchmarks/test_micro_benchmarks.py

13.4 µs13.4 µs

test_decimal_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

31.9 µs32.1 µs

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

143.7 µs144.4 µs

test_variable_tuple

tests/benchmarks/test_micro_benchmarks.py

17.7 µs17.8 µs

test_core_root_model

tests/benchmarks/test_micro_benchmarks.py

-1%

34.6 µs34.8 µs

test_date_format

tests/benchmarks/test_serialization_micro.py

-1%

51.9 µs52.2 µs

test_positional_tuple

tests/benchmarks/test_micro_benchmarks.py

-1%

17.8 µs17.9 µs

test_tuple_many_variable

tests/benchmarks/test_micro_benchmarks.py

-1%

17.4 µs17.5 µs

test_strict_union_error_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

-1%

31.5 µs31.7 µs

test_model_exclude_unset_true

tests/benchmarks/test_serialization_micro.py

-1%

35.2 µs35.5 µs

test_generator_rust

tests/benchmarks/test_micro_benchmarks.py

-1%

18.2 µs18.4 µs

test_validate_literal[python-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

-1%

14.5 µs14.7 µs

test_field_function_validator

tests/benchmarks/test_micro_benchmarks.py

-2%

358.3 µs365.5 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

-4%

25.7 µs26.6 µs

test_complete_core_isinstance

tests/benchmarks/test_complete_benchmark.py

-4%

1.7 ms1.8 ms

test_complete_core_error

tests/benchmarks/test_complete_benchmark.py

-4%

1.8 ms1.8 ms

test_many_models_core_model

tests/benchmarks/test_micro_benchmarks.py

-5%

2.3 ms2.4 ms

Commits

Click on a commit to change the comparison range

Base

main

4cb82bf

+0.31%

fix(union_serializer): do not raise warnings in nested unions In case unions of unions are used, this will bubble-up the errors rather than warning immediately. If no solution is found among all serializers by the top-level union, it will warn as before. Signed-off-by: Luka Peschke <mail@lukapeschke.com>

5c38506

1 year ago

by lukapeschke

-0.12%

feat: apply same logic to serde_serialize and add non-regression test Signed-off-by: Luka Peschke <mail@lukapeschke.com>

5506e1f

1 year ago

by lukapeschke

Home Terms Privacy Docs