fix-for-hash-bubble-error - Branch - pydantic/pydantic-core

Avoid using `?` with `get_item` to handle unhashable inputs properly

#1089Merged

Comparing

fix-for-hash-bubble-error

(

60c2c35

) with

main

(

a7739ec

)

Untouched: 140

Benchmarks

Passed

test_validate_literal[json-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

+4%

19.8 µs19.1 µs

test_tuple_many_variable

tests/benchmarks/test_micro_benchmarks.py

+4%

21 µs20.3 µs

test_decimal_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

+4%

34.6 µs33.5 µs

test_chain_function

tests/benchmarks/test_micro_benchmarks.py

+4%

24.9 µs24.1 µs

test_variable_tuple

tests/benchmarks/test_micro_benchmarks.py

+3%

21 µs20.3 µs

test_validate_literal[python-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

+3%

18.5 µs17.9 µs

test_chain_two_functions

tests/benchmarks/test_micro_benchmarks.py

+3%

30 µs29 µs

test_validate_literal[python-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

+3%

17.4 µs16.9 µs

test_with_default

tests/benchmarks/test_micro_benchmarks.py

+3%

24.8 µs24.1 µs

test_validate_literal[json-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

+3%

22.2 µs21.6 µs

test_positional_tuple

tests/benchmarks/test_micro_benchmarks.py

+3%

20.6 µs20.1 µs

test_tuple_many_positional

tests/benchmarks/test_micro_benchmarks.py

+2%

20.5 µs20 µs

test_validate_literal[python-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

+2%

14.9 µs14.6 µs

test_decimal_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

+2%

24.6 µs24.1 µs

test_raise_error_value_error

tests/benchmarks/test_micro_benchmarks.py

+2%

38 µs37.3 µs

test_isinstance_json

tests/benchmarks/test_micro_benchmarks.py

+2%

22.6 µs22.2 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+2%

28.5 µs28 µs

test_smart_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

15.8 µs15.6 µs

test_model_instance_abc

tests/benchmarks/test_micro_benchmarks.py

+1%

34.3 µs33.9 µs

test_validate_literal[json-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

16.8 µs16.6 µs

test_generator_python

tests/benchmarks/test_micro_benchmarks.py

+1%

27.6 µs27.3 µs

test_date_from_datetime

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

23.7 µs23.4 µs

test_bool_core

tests/benchmarks/test_micro_benchmarks.py

+1%

23.8 µs23.5 µs

test_model_instance

tests/benchmarks/test_micro_benchmarks.py

+1%

34 µs33.6 µs

test_strict_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

16.2 µs16 µs

test_date_from_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

18.3 µs18.1 µs

test_to_string_format

tests/benchmarks/test_serialization_micro.py

+1%

26.3 µs26 µs

test_dont_raise_error_no_info

tests/benchmarks/test_micro_benchmarks.py

+1%

17.9 µs17.7 µs

test_generator_rust

tests/benchmarks/test_micro_benchmarks.py

+1%

21.5 µs21.3 µs

test_dont_raise_error

tests/benchmarks/test_micro_benchmarks.py

+1%

20.1 µs19.9 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

18.4 µs18.2 µs

test_core_string_strict

tests/benchmarks/test_micro_benchmarks.py

+1%

13.6 µs13.5 µs

test_uuid_from_uuid_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

13.7 µs13.6 µs

test_smart_union_coerce_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

17.5 µs17.4 µs

test_chain_list

tests/benchmarks/test_micro_benchmarks.py

+1%

27.1 µs26.8 µs

test_date_from_datetime_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

20.1 µs20 µs

test_core_string_strict_wrong_str_e

tests/benchmarks/test_micro_benchmarks.py

+1%

43.1 µs42.8 µs

test_raise_error_custom

tests/benchmarks/test_micro_benchmarks.py

+1%

38.7 µs38.4 µs

test_strict_union_error_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

32.7 µs32.5 µs

test_date_from_date

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

13.7 µs13.6 µs

test_validate_literal[python-many_ints]

tests/benchmarks/test_micro_benchmarks.py

+1%

14.4 µs14.3 µs

test_int_error

tests/benchmarks/test_micro_benchmarks.py

+1%

45.1 µs44.8 µs

test_core_string_strict_wrong

tests/benchmarks/test_micro_benchmarks.py

+1%

26.5 µs26.3 µs

test_core_root_model

tests/benchmarks/test_micro_benchmarks.py

+1%

41.1 µs40.9 µs

test_validate_literal[json-many_ints]

tests/benchmarks/test_micro_benchmarks.py

+1%

15.1 µs15.1 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

35.9 µs35.7 µs

test_date_format_function_no_info

tests/benchmarks/test_serialization_micro.py

+1%

51.6 µs51.4 µs

test_complete_core_json

tests/benchmarks/test_complete_benchmark.py

+1%

648.7 µs645.4 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

19.8 µs19.7 µs

test_uuid_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

36.7 µs36.5 µs

test_bytes_core

tests/benchmarks/test_micro_benchmarks.py

13.5 µs13.4 µs

test_date_format

tests/benchmarks/test_serialization_micro.py

51.3 µs51.1 µs

test_list_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

1.1 ms1.1 ms

test_set_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

753.3 µs750.4 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

30.9 µs30.7 µs

test_set_of_ints_core_length

tests/benchmarks/test_micro_benchmarks.py

764.5 µs761.6 µs

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

39.7 µs39.6 µs

test_int_range_json

tests/benchmarks/test_micro_benchmarks.py

15.2 µs15.2 µs

test_arguments

tests/benchmarks/test_micro_benchmarks.py

27.4 µs27.3 µs

test_core_string_lax_wrong

tests/benchmarks/test_micro_benchmarks.py

26.8 µs26.7 µs

test_complete_core_lax

tests/benchmarks/test_complete_benchmark.py

308.8 µs308 µs

test_nested_schema_inlined

tests/benchmarks/test_nested_benchmark.py

21 ms20.9 ms

test_list_of_nullable_core

tests/benchmarks/test_micro_benchmarks.py

125.1 µs124.8 µs

test_uuid_from_uuid_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

14.4 µs14.4 µs

test_validate_literal[python-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

14.4 µs14.4 µs

test_frozenset_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

264.7 µs264.2 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

145.7 µs145.4 µs

test_nested_schema_using_defs

tests/benchmarks/test_nested_benchmark.py

20.4 ms20.4 ms

test_small_class_core_dict

tests/benchmarks/test_micro_benchmarks.py

21.9 µs21.9 µs

test_validate_literal[json-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

16.9 µs16.9 µs

test_validate_literal[json-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

16.9 µs16.9 µs

test_validate_literal[json-few_ints]

tests/benchmarks/test_micro_benchmarks.py

15 µs15 µs

test_complete_core_strict

tests/benchmarks/test_complete_benchmark.py

281.8 µs281.4 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

21.6 µs21.6 µs

test_set_of_ints_core_json_duplicates

tests/benchmarks/test_micro_benchmarks.py

762.1 µs761 µs

test_list_of_ints_core_py

tests/benchmarks/test_micro_benchmarks.py

536 µs535.3 µs

test_field_function_validator

tests/benchmarks/test_micro_benchmarks.py

397.5 µs397.1 µs

test_set_of_ints_core_duplicates

tests/benchmarks/test_micro_benchmarks.py

335.3 µs335 µs

test_set_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

1.2 ms1.2 ms

test_json_any_list_int

tests/benchmarks/test_serialization_micro.py

271.3 µs271.1 µs

test_json_direct_list_int

tests/benchmarks/test_serialization_micro.py

172.7 µs172.5 µs

test_model_list_core_json

tests/benchmarks/test_serialization_micro.py

190.4 µs190.3 µs

test_validate_literal[json-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

16.7 µs16.7 µs

test_dict_of_any_core

tests/benchmarks/test_micro_benchmarks.py

780 µs779.7 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

21.3 µs21.3 µs

test_python_json_list_none

tests/benchmarks/test_serialization_micro.py

127.8 µs127.7 µs

test_definition_out_of_tree

tests/benchmarks/test_micro_benchmarks.py

1.3 ms1.3 ms

test_dict_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

1.1 ms1.1 ms

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

13.6 µs13.6 µs

test_validate_literal[python-few_ints]

tests/benchmarks/test_micro_benchmarks.py

14.4 µs14.4 µs

test_strict_int

tests/benchmarks/test_micro_benchmarks.py

13.5 µs13.5 µs

test_int_range

tests/benchmarks/test_micro_benchmarks.py

14.6 µs14.6 µs

test_definition_in_tree

tests/benchmarks/test_micro_benchmarks.py

850.6 µs850.6 µs

test_frozenset_of_ints_duplicates_core

tests/benchmarks/test_micro_benchmarks.py

155.5 µs155.5 µs

test_core_json

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

85.4 µs85.4 µs

test_list_of_any_core_py

tests/benchmarks/test_micro_benchmarks.py

101.2 µs101.2 µs

test_definition_model_core

tests/benchmarks/test_micro_benchmarks.py

1.2 ms1.2 ms

test_core_model_json

tests/benchmarks/test_serialization_micro.py

27.9 µs27.9 µs

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

213 µs213.2 µs

test_datetime

tests/benchmarks/test_serialization_micro.py

29.3 µs29.4 µs

test_python_json_list_str

tests/benchmarks/test_serialization_micro.py

162.8 µs163 µs

test_python_json_list_int

tests/benchmarks/test_serialization_micro.py

155.1 µs155.3 µs

test_build_schema

tests/benchmarks/test_complete_benchmark.py

881.1 µs882.3 µs

test_decimal_from_string_limit

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

17.5 µs17.5 µs

test_json_any_list_str

tests/benchmarks/test_serialization_micro.py

275.4 µs275.8 µs

test_many_models_core_dict

tests/benchmarks/test_micro_benchmarks.py

1.2 ms1.2 ms

test_validate_literal[python-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

14.6 µs14.6 µs

test_core_string_lax

tests/benchmarks/test_micro_benchmarks.py

13.5 µs13.5 µs

test_tagged_union_int_keys_python

tests/benchmarks/test_micro_benchmarks.py

23.4 µs23.5 µs

test_many_models_core_model

tests/benchmarks/test_micro_benchmarks.py

3.2 ms3.2 ms

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

156.5 µs157 µs

test_date_format_function

tests/benchmarks/test_serialization_micro.py

52.8 µs52.9 µs

test_core_dict_filter

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

81.3 µs81.6 µs

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

51.7 µs51.9 µs

test_isinstance_string_lax_false

tests/benchmarks/test_micro_benchmarks.py

15.4 µs15.5 µs

test_isinstance_string_strict_true

tests/benchmarks/test_micro_benchmarks.py

13.7 µs13.8 µs

test_json_direct_list_str

tests/benchmarks/test_serialization_micro.py

176.1 µs176.9 µs

test_core_model_json_extra

tests/benchmarks/test_serialization_micro.py

-1%

32.2 µs32.3 µs

test_uuid_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

-1%

51.3 µs51.6 µs

test_chain_nested_functions

tests/benchmarks/test_micro_benchmarks.py

-1%

28.6 µs28.7 µs

test_dict_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

-1%

2.7 ms2.7 ms

test_isinstance_string_strict_false

tests/benchmarks/test_micro_benchmarks.py

-1%

15 µs15 µs

test_uuid

tests/benchmarks/test_serialization_micro.py

-1%

35.5 µs35.7 µs

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

-1%

13.7 µs13.8 µs

test_list_of_dict_models_core

tests/benchmarks/test_micro_benchmarks.py

-1%

138.3 µs139.2 µs

test_filter

tests/benchmarks/test_serialization_micro.py

-1%

46.1 µs46.4 µs

test_model_exclude_unset_true

tests/benchmarks/test_serialization_micro.py

-1%

36.9 µs37.2 µs

test_validate_literal[python-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

-1%

14.3 µs14.5 µs

test_core_python_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

-1%

80.3 µs81 µs

test_isinstance_string_lax_true

tests/benchmarks/test_micro_benchmarks.py

-1%

13.6 µs13.8 µs

test_core_model_py

tests/benchmarks/test_serialization_micro.py

-1%

28.7 µs29.1 µs

test_core_model_py_extra

tests/benchmarks/test_serialization_micro.py

-1%

32.7 µs33.1 µs

test_to_string_direct

tests/benchmarks/test_serialization_micro.py

-1%

20.9 µs21.2 µs

test_model_exclude_unset_false

tests/benchmarks/test_serialization_micro.py

-1%

30.4 µs30.8 µs

test_core_dict

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

-1%

78.1 µs79.2 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

-2%

30.5 µs31 µs

test_tagged_union_int_keys_json

tests/benchmarks/test_micro_benchmarks.py

-2%

30.9 µs31.6 µs

test_small_class_core_model

tests/benchmarks/test_micro_benchmarks.py

-2%

31.4 µs32.2 µs

test_complete_core_isinstance

tests/benchmarks/test_complete_benchmark.py

-4%

1.8 ms1.9 ms

test_complete_core_error

tests/benchmarks/test_complete_benchmark.py

-4%

1.8 ms1.9 ms

Commits

Click on a commit to change the comparison range

Base

main

a7739ec

-0.08%

avoid using ? with get item to handle unhashable inputs properly

03d3300

2 years ago

by sydney-runkle

-0.29%

test addition

7e2d37b

2 years ago

by sydney-runkle

+0.15%

updating comment

b9d6c8a

2 years ago

by sydney-runkle

+0.56%

tweak tests and comment

60c2c35

2 years ago

by samuelcolvin

Home Terms Privacy Docs