dh/extra-from-attributes - Branch - pydantic/pydantic-core

fix interaction between `extra != 'ignore'` and `from_attributes=True`

#1275Merged

Comparing

dh/extra-from-attributes

(

c150587

) with

main

(

91c3541

)

Regressions: 1
(
1
)

Untouched: 154

Benchmarks

Passed

test_generator_rust

tests/benchmarks/test_micro_benchmarks.py

+4%

20.1 µs19.3 µs

test_model_instance_abc

tests/benchmarks/test_micro_benchmarks.py

+3%

33.1 µs32.2 µs

test_list_of_dict_models_core

tests/benchmarks/test_micro_benchmarks.py

+2%

137.7 µs135.1 µs

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

+2%

125.4 µs123.2 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+2%

30.1 µs29.6 µs

test_decimal_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

+1%

23.9 µs23.5 µs

test_date_from_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

17.6 µs17.3 µs

test_core_python_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

+1%

74.1 µs73.4 µs

test_date_from_date

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

14.1 µs13.9 µs

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

13.9 µs13.7 µs

test_enum_int_python

tests/benchmarks/test_micro_benchmarks.py

+1%

24.1 µs23.9 µs

test_arguments

tests/benchmarks/test_micro_benchmarks.py

+1%

26 µs25.8 µs

test_core_string_strict_wrong_str_e

tests/benchmarks/test_micro_benchmarks.py

+1%

40.3 µs39.9 µs

test_smart_union_coerce_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

17.1 µs17 µs

test_filter

tests/benchmarks/test_serialization_micro.py

+1%

43 µs42.6 µs

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

14.1 µs14 µs

test_uuid_from_uuid_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

13.9 µs13.8 µs

test_list_of_any_core_py

tests/benchmarks/test_micro_benchmarks.py

+1%

99.2 µs98.4 µs

test_decimal_from_string_limit

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

+1%

17.9 µs17.8 µs

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

47.8 µs47.4 µs

test_smart_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

15.6 µs15.5 µs

test_strict_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

16.4 µs16.3 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

30.6 µs30.4 µs

test_uuid_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

33.7 µs33.5 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

17.4 µs17.3 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

17.7 µs17.6 µs

test_decimal_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

+1%

33 µs32.7 µs

test_isinstance_string_lax_true

tests/benchmarks/test_micro_benchmarks.py

+1%

13.9 µs13.8 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

33.8 µs33.5 µs

test_tuple_many_variable

tests/benchmarks/test_micro_benchmarks.py

+1%

19.1 µs19 µs

test_tagged_union_int_keys_json

tests/benchmarks/test_micro_benchmarks.py

+1%

26.2 µs26 µs

test_complete_core_isinstance

tests/benchmarks/test_complete_benchmark.py

+1%

1.8 ms1.8 ms

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

26 µs25.8 µs

test_small_class_core_model

tests/benchmarks/test_micro_benchmarks.py

+1%

30.9 µs30.7 µs

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

36.2 µs36.1 µs

test_enum_str_python

tests/benchmarks/test_micro_benchmarks.py

23.7 µs23.6 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

19.7 µs19.6 µs

test_core_string_lax_wrong

tests/benchmarks/test_micro_benchmarks.py

26.6 µs26.5 µs

test_isinstance_string_strict_true

tests/benchmarks/test_micro_benchmarks.py

13.9 µs13.8 µs

test_definition_model_core

tests/benchmarks/test_micro_benchmarks.py

1.2 ms1.2 ms

test_uuid_from_uuid_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

14.5 µs14.5 µs

test_isinstance_string_lax_false

tests/benchmarks/test_micro_benchmarks.py

15.4 µs15.4 µs

test_int_range_json

tests/benchmarks/test_micro_benchmarks.py

15.6 µs15.5 µs

test_complete_core_error

tests/benchmarks/test_complete_benchmark.py

1.8 ms1.8 ms

test_set_of_ints_core_json_duplicates

tests/benchmarks/test_micro_benchmarks.py

477.4 µs475.9 µs

test_raise_error_value_error

tests/benchmarks/test_micro_benchmarks.py

36.1 µs35.9 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

19.9 µs19.9 µs

test_raise_error_custom

tests/benchmarks/test_micro_benchmarks.py

37.9 µs37.8 µs

test_strict_int_fails

tests/benchmarks/test_micro_benchmarks.py

26.3 µs26.2 µs

test_python_json_list_none

tests/benchmarks/test_serialization_micro.py

124.5 µs124.2 µs

test_python_json_list_int

tests/benchmarks/test_serialization_micro.py

148.9 µs148.6 µs

test_generator_python

tests/benchmarks/test_micro_benchmarks.py

26.8 µs26.8 µs

test_complete_core_json

tests/benchmarks/test_complete_benchmark.py

492.6 µs491.6 µs

test_validate_literal[python-few_ints]

tests/benchmarks/test_micro_benchmarks.py

14.5 µs14.5 µs

test_complete_core_lax

tests/benchmarks/test_complete_benchmark.py

287 µs286.5 µs

test_set_of_ints_core_length

tests/benchmarks/test_micro_benchmarks.py

685.8 µs684.7 µs

test_isinstance_json

tests/benchmarks/test_micro_benchmarks.py

17.8 µs17.8 µs

test_positional_tuple

tests/benchmarks/test_micro_benchmarks.py

19.3 µs19.2 µs

test_date_from_datetime_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

18.4 µs18.4 µs

test_nested_schema_inlined

tests/benchmarks/test_nested_benchmark.py

20.8 ms20.7 ms

test_json_direct_list_str

tests/benchmarks/test_serialization_micro.py

158 µs157.8 µs

test_frozenset_of_ints_duplicates_core

tests/benchmarks/test_micro_benchmarks.py

143.3 µs143.1 µs

test_core_model_json

tests/benchmarks/test_serialization_micro.py

26.2 µs26.2 µs

test_chain_list

tests/benchmarks/test_micro_benchmarks.py

25.3 µs25.2 µs

test_model_list_core_json

tests/benchmarks/test_serialization_micro.py

153.1 µs152.9 µs

test_nested_schema_using_defs

tests/benchmarks/test_nested_benchmark.py

20.4 ms20.3 ms

test_build_schema

tests/benchmarks/test_complete_benchmark.py

813.9 µs813.1 µs

test_dict_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

1 ms1 ms

test_json_direct_list_int

tests/benchmarks/test_serialization_micro.py

134 µs133.8 µs

test_set_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

673.3 µs672.8 µs

test_json_any_list_int

tests/benchmarks/test_serialization_micro.py

194.2 µs194 µs

test_many_models_core_model

tests/benchmarks/test_micro_benchmarks.py

3.2 ms3.2 ms

test_json_any_list_str

tests/benchmarks/test_serialization_micro.py

225.7 µs225.6 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

140.3 µs140.2 µs

test_complete_core_serializer_to_json

tests/benchmarks/test_complete_benchmark.py

289.8 µs289.6 µs

test_model_instance

tests/benchmarks/test_micro_benchmarks.py

32.7 µs32.6 µs

test_ser_list_of_lists

tests/benchmarks/test_serialization_micro.py

1.3 ms1.3 ms

test_definition_in_tree

tests/benchmarks/test_micro_benchmarks.py

729.2 µs729.1 µs

test_with_default

tests/benchmarks/test_micro_benchmarks.py

22.1 µs22.1 µs

test_enum_int_core

tests/benchmarks/test_micro_benchmarks.py

15.3 µs15.3 µs

test_core_model_py

tests/benchmarks/test_serialization_micro.py

28 µs28 µs

test_to_string_format

tests/benchmarks/test_serialization_micro.py

24.3 µs24.3 µs

test_model_exclude_unset_true

tests/benchmarks/test_serialization_micro.py

36.2 µs36.2 µs

test_dont_raise_error_no_info

tests/benchmarks/test_micro_benchmarks.py

17.9 µs17.9 µs

test_complete_core_serializer_to_python

tests/benchmarks/test_complete_benchmark.py

266.7 µs266.8 µs

test_definition_out_of_tree

tests/benchmarks/test_micro_benchmarks.py

959.5 µs959.7 µs

test_python_json_list_str

tests/benchmarks/test_serialization_micro.py

158 µs158 µs

test_core_dict_filter

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

79.1 µs79.1 µs

test_list_of_ints_core_py

tests/benchmarks/test_micro_benchmarks.py

497.1 µs497.3 µs

test_frozenset_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

250.5 µs250.6 µs

test_chain_two_functions

tests/benchmarks/test_micro_benchmarks.py

28.5 µs28.6 µs

test_complete_core_strict

tests/benchmarks/test_complete_benchmark.py

263.7 µs263.9 µs

test_field_function_validator

tests/benchmarks/test_micro_benchmarks.py

375.1 µs375.4 µs

test_core_dict

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

76 µs76.1 µs

test_dict_of_any_core

tests/benchmarks/test_micro_benchmarks.py

719.4 µs720.1 µs

test_set_of_ints_core_duplicates

tests/benchmarks/test_micro_benchmarks.py

310.1 µs310.5 µs

test_date_format_function

tests/benchmarks/test_serialization_micro.py

51.9 µs52 µs

test_core_string_strict_wrong

tests/benchmarks/test_micro_benchmarks.py

26.3 µs26.3 µs

test_set_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

875.4 µs876.4 µs

test_core_model_json_extra

tests/benchmarks/test_serialization_micro.py

29.9 µs30 µs

test_date_from_datetime

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

21.6 µs21.6 µs

test_variable_tuple

tests/benchmarks/test_micro_benchmarks.py

19.1 µs19.2 µs

test_tuple_many_positional

tests/benchmarks/test_micro_benchmarks.py

19.1 µs19.1 µs

test_enum_str_core

tests/benchmarks/test_micro_benchmarks.py

14.9 µs14.9 µs

test_validate_literal[python-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

16.7 µs16.7 µs

test_validate_literal[json-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

15.9 µs15.9 µs

test_isinstance_string_strict_false

tests/benchmarks/test_micro_benchmarks.py

15.1 µs15.1 µs

test_many_models_core_dict

tests/benchmarks/test_micro_benchmarks.py

1.2 ms1.2 ms

test_validate_literal[python-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

14.7 µs14.7 µs

test_validate_literal[python-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

14.6 µs14.6 µs

test_model_exclude_unset_false

tests/benchmarks/test_serialization_micro.py

29.7 µs29.8 µs

test_validate_literal[python-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

15.1 µs15.2 µs

test_core_string_strict

tests/benchmarks/test_micro_benchmarks.py

13.6 µs13.6 µs

test_list_of_strs_json_cached

tests/benchmarks/test_micro_benchmarks.py

320 µs320.7 µs

test_list_of_strs_py_cached

tests/benchmarks/test_micro_benchmarks.py

122.9 µs123.2 µs

test_dataclass_serialization_json

tests/benchmarks/test_serialization_micro.py

24.9 µs25 µs

test_dont_raise_error

tests/benchmarks/test_micro_benchmarks.py

20 µs20.1 µs

test_list_of_nullable_core

tests/benchmarks/test_micro_benchmarks.py

103.2 µs103.6 µs

test_validate_literal[json-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

15.7 µs15.7 µs

test_validate_literal[json-many_ints]

tests/benchmarks/test_micro_benchmarks.py

15.4 µs15.4 µs

test_validate_literal[json-few_ints]

tests/benchmarks/test_micro_benchmarks.py

15.3 µs15.4 µs

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

159.6 µs160.2 µs

test_core_json

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

80.6 µs80.9 µs

test_list_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

780.6 µs783.6 µs

test_validate_literal[python-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

14.7 µs14.7 µs

test_date_format_function_no_info

tests/benchmarks/test_serialization_micro.py

-1%

50.4 µs50.7 µs

test_tagged_union_int_keys_python

tests/benchmarks/test_micro_benchmarks.py

-1%

21.2 µs21.3 µs

test_validate_literal[python-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

-1%

14.7 µs14.8 µs

test_validate_literal[python-many_ints]

tests/benchmarks/test_micro_benchmarks.py

-1%

14.4 µs14.5 µs

test_date_format

tests/benchmarks/test_serialization_micro.py

-1%

51.1 µs51.4 µs

test_core_string_lax

tests/benchmarks/test_micro_benchmarks.py

-1%

13.6 µs13.7 µs

test_bytes_core

tests/benchmarks/test_micro_benchmarks.py

-1%

13.6 µs13.7 µs

test_uuid

tests/benchmarks/test_serialization_micro.py

-1%

33.4 µs33.6 µs

test_core_root_model

tests/benchmarks/test_micro_benchmarks.py

-1%

36.5 µs36.8 µs

test_validate_literal[json-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

-1%

15.9 µs16 µs

test_validate_literal[json-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

-1%

15.7 µs15.8 µs

test_bool_core

tests/benchmarks/test_micro_benchmarks.py

-1%

23 µs23.2 µs

test_dataclass_serialization_python

tests/benchmarks/test_serialization_micro.py

-1%

23.3 µs23.4 µs

test_core_model_py_extra

tests/benchmarks/test_serialization_micro.py

-1%

31.2 µs31.4 µs

test_validate_literal[json-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

-1%

19.6 µs19.8 µs

test_small_class_core_dict

tests/benchmarks/test_micro_benchmarks.py

-1%

19.1 µs19.3 µs

test_dict_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

-1%

1.4 ms1.4 ms

test_validate_literal[json-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

-1%

18.3 µs18.4 µs

test_uuid_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

-1%

49.8 µs50.3 µs

test_strict_int

tests/benchmarks/test_micro_benchmarks.py

-1%

13.6 µs13.7 µs

test_to_json_list_of_lists

tests/benchmarks/test_serialization_micro.py

-1%

1.8 ms1.8 ms

test_int_range

tests/benchmarks/test_micro_benchmarks.py

-1%

14.6 µs14.7 µs

test_list_of_strs_json_uncached

tests/benchmarks/test_micro_benchmarks.py

-2%

455.9 µs463.9 µs

test_int_error

tests/benchmarks/test_micro_benchmarks.py

-2%

39.8 µs40.5 µs

test_chain_nested_functions

tests/benchmarks/test_micro_benchmarks.py

-3%

27.6 µs28.4 µs

test_dataclass_to_json

tests/benchmarks/test_serialization_micro.py

-3%

38.3 µs39.6 µs

test_datetime

tests/benchmarks/test_serialization_micro.py

-4%

26.9 µs28 µs

test_chain_function

tests/benchmarks/test_micro_benchmarks.py

-4%

24 µs25.2 µs

test_to_string_direct

tests/benchmarks/test_serialization_micro.py

-5%

18.7 µs19.7 µs

test_strict_union_error_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

Regression

-11%

33.4 µs37.6 µs

Commits

Click on a commit to change the comparison range

Base

main

91c3541

-0.1%

fix interaction between `extra != 'ignore'` and `from_attributes=True`

c150587

2 years ago

by davidhewitt

Home Terms Privacy Docs