astei:astei/pull-downcast-dt-td-up - Branch - pydantic/pydantic-core

Correct invalid serialization of `date`/`datetime`/`time`/`timedelta` by pulling downcast checks up

#1851Merged

Comparing

astei:astei/pull-downcast-dt-td-up

(

e5a373c

) with

main

(

396499c

)

+1%

Untouched: 163

Benchmarks

Passed

test_list_of_strs_json_cached

tests/benchmarks/test_micro_benchmarks.py

+8%

316.4 µs293.6 µs

test_list_of_strs_json_uncached

tests/benchmarks/test_micro_benchmarks.py

+5%

406.6 µs388.1 µs

test_list_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

+4%

760.2 µs730.3 µs

test_set_of_ints_core_json_duplicates

tests/benchmarks/test_micro_benchmarks.py

+4%

432.9 µs418 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

+3%

129.3 µs125.3 µs

test_validate_literal[python-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

+2%

15.3 µs14.9 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+2%

16.4 µs16.1 µs

test_core_string_strict_wrong_str_e

tests/benchmarks/test_micro_benchmarks.py

+2%

40.3 µs39.4 µs

test_validate_literal[json-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

+2%

16.2 µs15.9 µs

test_date_from_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+2%

16.3 µs16 µs

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+2%

13.9 µs13.7 µs

test_date_from_date

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+2%

14.2 µs14 µs

test_strict_int_fails

tests/benchmarks/test_micro_benchmarks.py

+2%

26.4 µs26 µs

test_set_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

+2%

874.4 µs858.6 µs

test_validate_literal[json-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

+2%

16.4 µs16.1 µs

test_decimal_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

+2%

23.8 µs23.4 µs

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

+2%

177.1 µs174 µs

test_core_string_strict

tests/benchmarks/test_micro_benchmarks.py

+2%

13.8 µs13.6 µs

test_core_python_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

+2%

70.4 µs69.3 µs

test_function_wrap_json

tests/benchmarks/test_serialization_micro.py

+2%

30.7 µs30.2 µs

test_chain_function

tests/benchmarks/test_micro_benchmarks.py

+2%

24.5 µs24.1 µs

test_enum_str_core

tests/benchmarks/test_micro_benchmarks.py

+2%

15.2 µs15 µs

test_core_dict_filter

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

+2%

80.3 µs79.1 µs

test_generator_rust

tests/benchmarks/test_micro_benchmarks.py

+2%

18.8 µs18.6 µs

test_strict_union_error_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+2%

32.1 µs31.6 µs

test_python_json_list_int

tests/benchmarks/test_serialization_micro.py

+2%

161.7 µs159.3 µs

test_int_range_json

tests/benchmarks/test_micro_benchmarks.py

+1%

15.9 µs15.7 µs

test_chain_nested_functions

tests/benchmarks/test_micro_benchmarks.py

+1%

28.5 µs28.1 µs

test_validate_literal[json-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

16.3 µs16.1 µs

test_to_string_direct

tests/benchmarks/test_serialization_micro.py

+1%

18.5 µs18.2 µs

test_core_dict

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

+1%

74.3 µs73.3 µs

test_core_string_lax_wrong

tests/benchmarks/test_micro_benchmarks.py

+1%

26.7 µs26.3 µs

test_python_json_list_str

tests/benchmarks/test_serialization_micro.py

+1%

167.5 µs165.3 µs

test_smart_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

15.9 µs15.7 µs

test_strict_int

tests/benchmarks/test_micro_benchmarks.py

+1%

13.7 µs13.5 µs

test_core_string_lax

tests/benchmarks/test_micro_benchmarks.py

+1%

13.8 µs13.6 µs

test_chain_two_functions

tests/benchmarks/test_micro_benchmarks.py

+1%

28.6 µs28.2 µs

test_uuid_from_uuid_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

13.9 µs13.7 µs

test_strict_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

16.5 µs16.3 µs

test_enum_str_python

tests/benchmarks/test_micro_benchmarks.py

+1%

23.7 µs23.4 µs

test_core_string_strict_wrong

tests/benchmarks/test_micro_benchmarks.py

+1%

26.4 µs26.1 µs

test_raise_error_value_error

tests/benchmarks/test_micro_benchmarks.py

+1%

35.9 µs35.5 µs

test_int_range

tests/benchmarks/test_micro_benchmarks.py

+1%

14.8 µs14.6 µs

test_validate_literal[python-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

15.1 µs14.9 µs

test_chain_list

tests/benchmarks/test_micro_benchmarks.py

+1%

24.8 µs24.5 µs

test_isinstance_string_strict_false

tests/benchmarks/test_micro_benchmarks.py

+1%

15.3 µs15.2 µs

test_tuple_many_variable

tests/benchmarks/test_micro_benchmarks.py

+1%

17.8 µs17.6 µs

test_tuple_many_positional

tests/benchmarks/test_micro_benchmarks.py

+1%

17.9 µs17.7 µs

test_validate_literal[json-many_ints]

tests/benchmarks/test_micro_benchmarks.py

+1%

15.8 µs15.6 µs

test_dataclass_to_json

tests/benchmarks/test_serialization_micro.py

+1%

39.8 µs39.4 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

18.8 µs18.6 µs

test_small_class_core_dict

tests/benchmarks/test_micro_benchmarks.py

+1%

18.8 µs18.6 µs

test_tagged_union_int_keys_json

tests/benchmarks/test_micro_benchmarks.py

+1%

24.8 µs24.5 µs

test_model_instance_abc

tests/benchmarks/test_micro_benchmarks.py

+1%

29.6 µs29.3 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

19.1 µs18.9 µs

test_date_from_datetime_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

19.3 µs19.1 µs

test_function_wrap_python

tests/benchmarks/test_serialization_micro.py

+1%

29.3 µs29.1 µs

test_python_json_list_none

tests/benchmarks/test_serialization_micro.py

+1%

133.6 µs132.3 µs

test_enum_int_core

tests/benchmarks/test_micro_benchmarks.py

+1%

14.7 µs14.5 µs

test_variable_tuple

tests/benchmarks/test_micro_benchmarks.py

+1%

18.3 µs18.1 µs

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

30.2 µs29.9 µs

test_validate_literal[json-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

16.1 µs16 µs

test_complete_core_serializer_to_python

tests/benchmarks/test_complete_benchmark.py

+1%

238.2 µs236 µs

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

+1%

108.2 µs107.3 µs

test_multi_host_url_core

tests/benchmarks/test_micro_benchmarks.py

+1%

33.5 µs33.3 µs

test_isinstance_string_strict_true

tests/benchmarks/test_micro_benchmarks.py

+1%

13.9 µs13.8 µs

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

14.2 µs14.1 µs

test_url_core

tests/benchmarks/test_micro_benchmarks.py

+1%

25.2 µs25 µs

test_validate_literal[python-many_ints]

tests/benchmarks/test_micro_benchmarks.py

+1%

14.5 µs14.4 µs

test_decimal_from_string_limit

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

+1%

18.9 µs18.7 µs

test_positional_tuple

tests/benchmarks/test_micro_benchmarks.py

+1%

18.6 µs18.5 µs

test_to_string_format

tests/benchmarks/test_serialization_micro.py

+1%

22.6 µs22.4 µs

test_validate_literal[python-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

14.9 µs14.8 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

26.5 µs26.3 µs

test_json_direct_list_int

tests/benchmarks/test_serialization_micro.py

+1%

153.1 µs152 µs

test_date_from_datetime

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

22 µs21.8 µs

test_smart_union_coerce_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

17.5 µs17.4 µs

test_validate_literal[python-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

14.9 µs14.8 µs

test_uuid_from_uuid_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

14.8 µs14.7 µs

test_validate_literal[json-few_ints]

tests/benchmarks/test_micro_benchmarks.py

+1%

15.7 µs15.6 µs

test_core_root_model

tests/benchmarks/test_micro_benchmarks.py

+1%

36.1 µs35.9 µs

test_isinstance_string_lax_false

tests/benchmarks/test_micro_benchmarks.py

+1%

15.6 µs15.5 µs

test_core_model_json

tests/benchmarks/test_serialization_micro.py

+1%

25.2 µs25 µs

test_generator_python

tests/benchmarks/test_micro_benchmarks.py

+1%

22.6 µs22.5 µs

test_validate_literal[python-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

16.8 µs16.7 µs

test_enum_int_python

tests/benchmarks/test_micro_benchmarks.py

23.9 µs23.8 µs

test_validate_literal[json-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

18.5 µs18.4 µs

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

41.3 µs41.1 µs

test_dataclass_serialization_python

tests/benchmarks/test_serialization_micro.py

21.8 µs21.7 µs

test_isinstance_string_lax_true

tests/benchmarks/test_micro_benchmarks.py

13.9 µs13.8 µs

test_int_error

tests/benchmarks/test_micro_benchmarks.py

40 µs39.9 µs

test_validate_literal[python-few_ints]

tests/benchmarks/test_micro_benchmarks.py

14.5 µs14.5 µs

test_decimal_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

32.3 µs32.2 µs

test_json_any_list_int

tests/benchmarks/test_serialization_micro.py

229.3 µs228.6 µs

test_many_models_core_dict

tests/benchmarks/test_micro_benchmarks.py

939.4 µs936.4 µs

test_uuid_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

32.2 µs32.1 µs

test_definition_model_core

tests/benchmarks/test_micro_benchmarks.py

1.1 ms1.1 ms

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

32.2 µs32.1 µs

test_set_of_ints_core_length

tests/benchmarks/test_micro_benchmarks.py

718.1 µs715.9 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

18.1 µs18.1 µs

test_list_of_nullable_core

tests/benchmarks/test_micro_benchmarks.py

104.7 µs104.4 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

25.8 µs25.7 µs

test_build_schema

tests/benchmarks/test_complete_benchmark.py

338.8 µs337.9 µs

test_raise_error_custom

tests/benchmarks/test_micro_benchmarks.py

37.1 µs37 µs

test_dataclass_serialization_json

tests/benchmarks/test_serialization_micro.py

24.4 µs24.4 µs

test_core_json

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

82.8 µs82.7 µs

test_list_of_strs_py_cached

tests/benchmarks/test_micro_benchmarks.py

121.8 µs121.6 µs

test_complete_core_lax

tests/benchmarks/test_complete_benchmark.py

272.2 µs271.7 µs

test_complete_core_serializer_to_json

tests/benchmarks/test_complete_benchmark.py

282.8 µs282.3 µs

test_bytes_core

tests/benchmarks/test_micro_benchmarks.py

13.7 µs13.6 µs

test_core_model_py_extra

tests/benchmarks/test_serialization_micro.py

29.6 µs29.6 µs

test_model_list_core_json

tests/benchmarks/test_serialization_micro.py

172.1 µs171.9 µs

test_nested_schema_inlined

tests/benchmarks/test_nested_benchmark.py

16.5 ms16.5 ms

test_many_models_core_model

tests/benchmarks/test_micro_benchmarks.py

2.2 ms2.2 ms

test_frozenset_of_ints_duplicates_core

tests/benchmarks/test_micro_benchmarks.py

155.3 µs155.1 µs

test_set_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

702.9 µs702.1 µs

test_model_exclude_unset_false

tests/benchmarks/test_serialization_micro.py

29.4 µs29.4 µs

test_ser_list_of_lists

tests/benchmarks/test_serialization_micro.py

1.4 ms1.4 ms

test_filter

tests/benchmarks/test_serialization_micro.py

40.9 µs40.9 µs

test_frozenset_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

236.2 µs236 µs

test_json_direct_list_str

tests/benchmarks/test_serialization_micro.py

182.1 µs181.9 µs

test_model_instance

tests/benchmarks/test_micro_benchmarks.py

29 µs29 µs

test_list_of_any_core_py

tests/benchmarks/test_micro_benchmarks.py

98.8 µs98.7 µs

test_definition_out_of_tree

tests/benchmarks/test_micro_benchmarks.py

991.4 µs991.1 µs

test_definition_in_tree

tests/benchmarks/test_micro_benchmarks.py

754.1 µs753.9 µs

test_to_json_list_of_lists

tests/benchmarks/test_serialization_micro.py

2.1 ms2.1 ms

test_validate_literal[python-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

15.3 µs15.3 µs

test_dict_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

1 ms1 ms

test_arguments

tests/benchmarks/test_micro_benchmarks.py

24.3 µs24.3 µs

test_json_any_list_str

tests/benchmarks/test_serialization_micro.py

263.2 µs263.3 µs

test_dict_of_any_core

tests/benchmarks/test_micro_benchmarks.py

700.6 µs700.7 µs

test_set_of_ints_core_duplicates

tests/benchmarks/test_micro_benchmarks.py

315.8 µs315.9 µs

test_field_function_validator

tests/benchmarks/test_micro_benchmarks.py

361.9 µs362.1 µs

test_isinstance_json

tests/benchmarks/test_micro_benchmarks.py

18.1 µs18.1 µs

test_small_class_core_model

tests/benchmarks/test_micro_benchmarks.py

26.6 µs26.6 µs

test_nested_schema_using_defs

tests/benchmarks/test_nested_benchmark.py

15.1 ms15.1 ms

test_list_of_ints_core_py

tests/benchmarks/test_micro_benchmarks.py

520.8 µs521.7 µs

test_with_default

tests/benchmarks/test_micro_benchmarks.py

22.5 µs22.6 µs

test_validate_literal[json-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

20.2 µs20.3 µs

test_date_format_function

tests/benchmarks/test_serialization_micro.py

51.7 µs51.8 µs

test_bool_core

tests/benchmarks/test_micro_benchmarks.py

22.9 µs23 µs

test_core_model_py

tests/benchmarks/test_serialization_micro.py

26.4 µs26.5 µs

test_list_of_dict_models_core

tests/benchmarks/test_micro_benchmarks.py

97.6 µs97.9 µs

test_tagged_union_int_keys_python

tests/benchmarks/test_micro_benchmarks.py

20.8 µs20.9 µs

test_core_model_json_extra

tests/benchmarks/test_serialization_micro.py

28.9 µs29 µs

test_datetime_milliseconds

tests/benchmarks/test_serialization_micro.py

24.7 µs24.8 µs

test_uuid

tests/benchmarks/test_serialization_micro.py

22.8 µs22.9 µs

test_complete_core_root

tests/benchmarks/test_complete_benchmark.py

273.6 µs274.9 µs

test_datetime

tests/benchmarks/test_serialization_micro.py

26.6 µs26.7 µs

test_datetime_seconds

tests/benchmarks/test_serialization_micro.py

-1%

24.5 µs24.7 µs

test_complete_core_strict

tests/benchmarks/test_complete_benchmark.py

-1%

248.5 µs249.8 µs

test_date_format_function_no_info

tests/benchmarks/test_serialization_micro.py

-1%

50.2 µs50.5 µs

test_model_exclude_unset_true

tests/benchmarks/test_serialization_micro.py

-1%

35.4 µs35.6 µs

test_complete_core_root_json

tests/benchmarks/test_complete_benchmark.py

-1%

430.1 µs432.7 µs

test_date_format

tests/benchmarks/test_serialization_micro.py

-1%

51.8 µs52.1 µs

test_dont_raise_error_no_info

tests/benchmarks/test_micro_benchmarks.py

-1%

17.1 µs17.2 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

-1%

25.8 µs26 µs

test_uuid_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

-1%

47.7 µs48.2 µs

test_dont_raise_error

tests/benchmarks/test_micro_benchmarks.py

-1%

19.2 µs19.3 µs

test_complete_core_json

tests/benchmarks/test_complete_benchmark.py

-1%

419 µs423.3 µs

test_complete_core_isinstance

tests/benchmarks/test_complete_benchmark.py

-1%

1.7 ms1.7 ms

test_complete_core_error

tests/benchmarks/test_complete_benchmark.py

-1%

1.7 ms1.7 ms

test_dict_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

-2%

1.4 ms1.4 ms

Commits

Click on a commit to change the comparison range

Base

main

396499c

+0.68%

Correct invalid serialization of `date`/`datetime`/`time`/`timedelta` by pulling downcast checks up

e5a373c

3 days ago

by astei

Home Terms Privacy Docs