K-dash:improve-float-multiple-of-validation - Branch - pydantic/pydantic-core

Fix float `multiple_of` validation for negative numbers

#1373Merged

Comparing

K-dash:improve-float-multiple-of-validation

(

cc53124

) with

main

(

562fad3

)

Untouched: 157

Benchmarks

Passed

test_date_format_function

tests/benchmarks/test_serialization_micro.py

+2%

53.4 µs52.3 µs

test_dataclass_to_json

tests/benchmarks/test_serialization_micro.py

+1%

42.3 µs41.7 µs

test_list_of_strs_json_uncached

tests/benchmarks/test_micro_benchmarks.py

+1%

475.3 µs469.9 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

18.7 µs18.5 µs

test_validate_literal[json-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

+1%

19.2 µs19 µs

test_validate_literal[json-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

17 µs16.8 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

19 µs18.8 µs

test_int_range_json

tests/benchmarks/test_micro_benchmarks.py

+1%

16.5 µs16.3 µs

test_set_of_ints_core_json_duplicates

tests/benchmarks/test_micro_benchmarks.py

+1%

440.9 µs437.4 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

18.7 µs18.6 µs

test_int_range

tests/benchmarks/test_micro_benchmarks.py

+1%

15.2 µs15.1 µs

test_tagged_union_int_keys_json

tests/benchmarks/test_micro_benchmarks.py

+1%

25.7 µs25.5 µs

test_date_from_date

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

14.6 µs14.5 µs

test_set_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

+1%

906.4 µs901.3 µs

test_list_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

+1%

773.7 µs769.4 µs

test_list_of_ints_core_py

tests/benchmarks/test_micro_benchmarks.py

+1%

534.9 µs532 µs

test_validate_literal[json-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

16.8 µs16.7 µs

test_validate_literal[json-many_ints]

tests/benchmarks/test_micro_benchmarks.py

+1%

16.3 µs16.2 µs

test_date_from_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

16.3 µs16.2 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

28 µs27.9 µs

test_json_any_list_str

tests/benchmarks/test_serialization_micro.py

260.5 µs259.3 µs

test_definition_model_core

tests/benchmarks/test_micro_benchmarks.py

1.1 ms1.1 ms

test_tuple_many_variable

tests/benchmarks/test_micro_benchmarks.py

18.2 µs18.1 µs

test_json_direct_list_str

tests/benchmarks/test_serialization_micro.py

178.7 µs177.8 µs

test_chain_list

tests/benchmarks/test_micro_benchmarks.py

25.4 µs25.2 µs

test_decimal_from_string_limit

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

19.3 µs19.3 µs

test_json_direct_list_int

tests/benchmarks/test_serialization_micro.py

148.1 µs147.5 µs

test_date_format

tests/benchmarks/test_serialization_micro.py

52.6 µs52.4 µs

test_uuid

tests/benchmarks/test_serialization_micro.py

23.7 µs23.6 µs

test_validate_literal[json-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

16.8 µs16.8 µs

test_validate_literal[json-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

16.9 µs16.8 µs

test_filter

tests/benchmarks/test_serialization_micro.py

42.7 µs42.6 µs

test_small_class_core_model

tests/benchmarks/test_micro_benchmarks.py

27 µs27 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

16.4 µs16.3 µs

test_tuple_many_positional

tests/benchmarks/test_micro_benchmarks.py

18.2 µs18.2 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

26.4 µs26.3 µs

test_chain_nested_functions

tests/benchmarks/test_micro_benchmarks.py

29 µs28.9 µs

test_generator_rust

tests/benchmarks/test_micro_benchmarks.py

18.9 µs18.8 µs

test_python_json_list_int

tests/benchmarks/test_serialization_micro.py

145.3 µs144.9 µs

test_date_from_datetime_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

19.3 µs19.2 µs

test_chain_function

tests/benchmarks/test_micro_benchmarks.py

24.8 µs24.7 µs

test_json_any_list_int

tests/benchmarks/test_serialization_micro.py

224.6 µs224.2 µs

test_complete_core_serializer_to_python

tests/benchmarks/test_complete_benchmark.py

249.6 µs249.2 µs

test_validate_literal[json-few_ints]

tests/benchmarks/test_micro_benchmarks.py

16.3 µs16.3 µs

test_uuid_from_uuid_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

15.2 µs15.2 µs

test_strict_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

17 µs17 µs

test_isinstance_json

tests/benchmarks/test_micro_benchmarks.py

19 µs18.9 µs

test_to_string_direct

tests/benchmarks/test_serialization_micro.py

18.9 µs18.9 µs

test_to_json_list_of_lists

tests/benchmarks/test_serialization_micro.py

2.1 ms2.1 ms

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

43.1 µs43.1 µs

test_date_from_datetime

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

22.3 µs22.3 µs

test_core_model_py

tests/benchmarks/test_serialization_micro.py

26.5 µs26.5 µs

test_python_json_list_none

tests/benchmarks/test_serialization_micro.py

117.8 µs117.7 µs

test_uuid_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

32.6 µs32.6 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

27 µs27 µs

test_complete_core_lax

tests/benchmarks/test_complete_benchmark.py

272.3 µs272.1 µs

test_dict_of_any_core

tests/benchmarks/test_micro_benchmarks.py

691.1 µs690.6 µs

test_model_list_core_json

tests/benchmarks/test_serialization_micro.py

166.5 µs166.4 µs

test_ser_list_of_lists

tests/benchmarks/test_serialization_micro.py

1.4 ms1.4 ms

test_list_of_any_core_py

tests/benchmarks/test_micro_benchmarks.py

99.4 µs99.4 µs

test_list_of_strs_json_cached

tests/benchmarks/test_micro_benchmarks.py

323.4 µs323.3 µs

test_python_json_list_str

tests/benchmarks/test_serialization_micro.py

151 µs150.9 µs

test_chain_two_functions

tests/benchmarks/test_micro_benchmarks.py

29 µs29 µs

test_definition_out_of_tree

tests/benchmarks/test_micro_benchmarks.py

1.1 ms1.1 ms

test_generator_python

tests/benchmarks/test_micro_benchmarks.py

23.5 µs23.5 µs

test_field_function_validator

tests/benchmarks/test_micro_benchmarks.py

391.7 µs391.8 µs

test_isinstance_string_lax_false

tests/benchmarks/test_micro_benchmarks.py

15.8 µs15.8 µs

test_validate_literal[python-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

15.3 µs15.3 µs

test_core_model_py_extra

tests/benchmarks/test_serialization_micro.py

29.8 µs29.8 µs

test_definition_in_tree

tests/benchmarks/test_micro_benchmarks.py

785.1 µs785.3 µs

test_isinstance_string_lax_true

tests/benchmarks/test_micro_benchmarks.py

14.1 µs14.1 µs

test_core_string_lax

tests/benchmarks/test_micro_benchmarks.py

14.1 µs14.1 µs

test_strict_int

tests/benchmarks/test_micro_benchmarks.py

14 µs14 µs

test_frozenset_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

246.5 µs246.6 µs

test_list_of_strs_py_cached

tests/benchmarks/test_micro_benchmarks.py

131.4 µs131.5 µs

test_model_exclude_unset_false

tests/benchmarks/test_serialization_micro.py

29.9 µs29.9 µs

test_set_of_ints_core_duplicates

tests/benchmarks/test_micro_benchmarks.py

315.7 µs315.9 µs

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

144.3 µs144.4 µs

test_decimal_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

33.1 µs33.1 µs

test_frozenset_of_ints_duplicates_core

tests/benchmarks/test_micro_benchmarks.py

171.1 µs171.3 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

32.6 µs32.6 µs

test_set_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

717.9 µs718.6 µs

test_datetime

tests/benchmarks/test_serialization_micro.py

27.4 µs27.4 µs

test_core_python_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

71.2 µs71.3 µs

test_complete_core_json

tests/benchmarks/test_complete_benchmark.py

439.6 µs440.4 µs

test_small_class_core_dict

tests/benchmarks/test_micro_benchmarks.py

19 µs19 µs

test_set_of_ints_core_length

tests/benchmarks/test_micro_benchmarks.py

730 µs731.3 µs

test_build_schema

tests/benchmarks/test_complete_benchmark.py

754.7 µs756 µs

test_validate_literal[python-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

17.2 µs17.2 µs

test_enum_str_core

tests/benchmarks/test_micro_benchmarks.py

15.3 µs15.3 µs

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

31.5 µs31.6 µs

test_validate_literal[python-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

15.6 µs15.6 µs

test_model_instance_abc

tests/benchmarks/test_micro_benchmarks.py

30.1 µs30.1 µs

test_validate_literal[python-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

15.3 µs15.3 µs

test_complete_core_strict

tests/benchmarks/test_complete_benchmark.py

248.5 µs249 µs

test_enum_int_core

tests/benchmarks/test_micro_benchmarks.py

15 µs15 µs

test_nested_schema_using_defs

tests/benchmarks/test_nested_benchmark.py

14.6 ms14.6 ms

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

14.3 µs14.3 µs

test_core_dict_filter

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

76.3 µs76.5 µs

test_uuid_from_uuid_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

14.2 µs14.3 µs

test_core_string_strict

tests/benchmarks/test_micro_benchmarks.py

14.1 µs14.1 µs

test_nested_schema_inlined

tests/benchmarks/test_nested_benchmark.py

15.7 ms15.7 ms

test_dict_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

1 ms1 ms

test_arguments

tests/benchmarks/test_micro_benchmarks.py

22.8 µs22.8 µs

test_decimal_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

23.7 µs23.7 µs

test_bool_core

tests/benchmarks/test_micro_benchmarks.py

23.7 µs23.7 µs

test_to_string_format

tests/benchmarks/test_serialization_micro.py

23.5 µs23.6 µs

test_model_exclude_unset_true

tests/benchmarks/test_serialization_micro.py

35.4 µs35.5 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

128.1 µs128.4 µs

test_complete_core_root

tests/benchmarks/test_complete_benchmark.py

274.6 µs275.4 µs

test_complete_core_root_json

tests/benchmarks/test_complete_benchmark.py

445.6 µs446.9 µs

test_core_model_json_extra

tests/benchmarks/test_serialization_micro.py

29.4 µs29.5 µs

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

109.9 µs110.3 µs

test_uuid_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

48.3 µs48.5 µs

test_validate_literal[python-many_ints]

tests/benchmarks/test_micro_benchmarks.py

14.9 µs15 µs

test_validate_literal[python-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

15.1 µs15.2 µs

test_validate_literal[json-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

20.6 µs20.7 µs

test_isinstance_string_strict_true

tests/benchmarks/test_micro_benchmarks.py

14.1 µs14.2 µs

test_validate_literal[python-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

15.2 µs15.2 µs

test_int_error

tests/benchmarks/test_micro_benchmarks.py

40.8 µs41 µs

test_smart_union_coerce_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

17.9 µs18 µs

test_model_instance

tests/benchmarks/test_micro_benchmarks.py

-1%

29.8 µs29.9 µs

test_dict_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

-1%

1.5 ms1.5 ms

test_raise_error_value_error

tests/benchmarks/test_micro_benchmarks.py

-1%

38 µs38.2 µs

test_dataclass_serialization_python

tests/benchmarks/test_serialization_micro.py

-1%

21.6 µs21.8 µs

test_many_models_core_dict

tests/benchmarks/test_micro_benchmarks.py

-1%

959.5 µs965 µs

test_isinstance_string_strict_false

tests/benchmarks/test_micro_benchmarks.py

-1%

15.5 µs15.6 µs

test_dont_raise_error

tests/benchmarks/test_micro_benchmarks.py

-1%

20.4 µs20.6 µs

test_core_json

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

-1%

83.1 µs83.5 µs

test_date_format_function_no_info

tests/benchmarks/test_serialization_micro.py

-1%

51.3 µs51.6 µs

test_complete_core_error

tests/benchmarks/test_complete_benchmark.py

-1%

1.8 ms1.8 ms

test_validate_literal[python-few_ints]

tests/benchmarks/test_micro_benchmarks.py

-1%

14.9 µs15 µs

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

-1%

14.5 µs14.6 µs

test_dont_raise_error_no_info

tests/benchmarks/test_micro_benchmarks.py

-1%

18.1 µs18.2 µs

test_complete_core_isinstance

tests/benchmarks/test_complete_benchmark.py

-1%

1.8 ms1.8 ms

test_bytes_core

tests/benchmarks/test_micro_benchmarks.py

-1%

14 µs14.1 µs

test_complete_core_serializer_to_json

tests/benchmarks/test_complete_benchmark.py

-1%

294.7 µs296.6 µs

test_list_of_nullable_core

tests/benchmarks/test_micro_benchmarks.py

-1%

104.1 µs104.8 µs

test_many_models_core_model

tests/benchmarks/test_micro_benchmarks.py

-1%

2.3 ms2.4 ms

test_core_model_json

tests/benchmarks/test_serialization_micro.py

-1%

25.7 µs25.8 µs

test_smart_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

-1%

16.4 µs16.5 µs

test_list_of_dict_models_core

tests/benchmarks/test_micro_benchmarks.py

-1%

91.2 µs91.9 µs

test_core_dict

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

-1%

70.1 µs70.6 µs

test_enum_int_python

tests/benchmarks/test_micro_benchmarks.py

-1%

24.2 µs24.4 µs

test_tagged_union_int_keys_python

tests/benchmarks/test_micro_benchmarks.py

-1%

21 µs21.1 µs

test_dataclass_serialization_json

tests/benchmarks/test_serialization_micro.py

-1%

24.7 µs24.9 µs

test_strict_union_error_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

-1%

32.5 µs32.8 µs

test_raise_error_custom

tests/benchmarks/test_micro_benchmarks.py

-1%

39.2 µs39.6 µs

test_enum_str_python

tests/benchmarks/test_micro_benchmarks.py

-1%

23.9 µs24.2 µs

test_positional_tuple

tests/benchmarks/test_micro_benchmarks.py

-1%

18.7 µs18.9 µs

test_strict_int_fails

tests/benchmarks/test_micro_benchmarks.py

-1%

26.4 µs26.7 µs

test_core_string_strict_wrong

tests/benchmarks/test_micro_benchmarks.py

-1%

26.4 µs26.7 µs

test_variable_tuple

tests/benchmarks/test_micro_benchmarks.py

-1%

18.6 µs18.8 µs

test_core_string_lax_wrong

tests/benchmarks/test_micro_benchmarks.py

-1%

26.6 µs26.9 µs

test_with_default

tests/benchmarks/test_micro_benchmarks.py

-2%

22.8 µs23.1 µs

test_core_string_strict_wrong_str_e

tests/benchmarks/test_micro_benchmarks.py

-2%

40.5 µs41.2 µs

test_core_root_model

tests/benchmarks/test_micro_benchmarks.py

-2%

35.6 µs36.3 µs

Commits

Click on a commit to change the comparison range

Base

main

562fad3

+0.01%

Improve precision of float multiple_of validation

3432e82

1 year ago

by K-dash

-0.17%

Add equivalent decimal tests for consistency

8e9b338

1 year ago

by K-dash

+0.06%

fix: resolve multiple_of validation bug for negative floats using round-based approach

cc53124

10 months ago

by K-dash

Home Terms Privacy Docs