DouweM:validator-reuse-field-name - Branch - pydantic/pydantic-core

Ensure `ValidationInfo.field_name` is correct on validator reuse

#1692Merged

Comparing

DouweM:validator-reuse-field-name

(

3d69981

) with

main

(

9a25aa6

)

Untouched: 157

Benchmarks

Passed

test_many_models_core_model

tests/benchmarks/test_micro_benchmarks.py

+4%

2.2 ms2.2 ms

test_complete_core_error

tests/benchmarks/test_complete_benchmark.py

+3%

1.8 ms1.7 ms

test_uuid_from_uuid_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+3%

14.3 µs14 µs

test_complete_core_isinstance

tests/benchmarks/test_complete_benchmark.py

+2%

1.7 ms1.7 ms

test_validate_literal[json-few_ints]

tests/benchmarks/test_micro_benchmarks.py

+2%

16.2 µs15.9 µs

test_validate_literal[json-many_ints]

tests/benchmarks/test_micro_benchmarks.py

+2%

16.1 µs15.8 µs

test_validate_literal[json-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

+2%

16.6 µs16.3 µs

test_validate_literal[json-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

+2%

16.8 µs16.5 µs

test_date_from_datetime_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+2%

19.4 µs19.1 µs

test_strict_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+2%

16.7 µs16.5 µs

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

14.2 µs14 µs

test_date_from_datetime

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

22.4 µs22.1 µs

test_validate_literal[json-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

16.8 µs16.5 µs

test_strict_int_fails

tests/benchmarks/test_micro_benchmarks.py

+1%

26.9 µs26.5 µs

test_date_from_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

16.3 µs16.1 µs

test_validate_literal[json-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

16.5 µs16.3 µs

test_uuid_from_uuid_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

+1%

15 µs14.8 µs

test_core_dict

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

+1%

70.2 µs69.4 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

16.5 µs16.3 µs

test_list_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

+1%

754.9 µs746.9 µs

test_chain_function

tests/benchmarks/test_micro_benchmarks.py

+1%

24.7 µs24.5 µs

test_core_dict_filter

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

+1%

76 µs75.3 µs

test_list_of_ints_core_py

tests/benchmarks/test_micro_benchmarks.py

+1%

516.5 µs511.8 µs

test_core_string_strict_wrong

tests/benchmarks/test_micro_benchmarks.py

+1%

26.8 µs26.6 µs

test_validate_literal[python-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

+1%

17 µs16.9 µs

test_smart_union_coerce_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

+1%

17.9 µs17.8 µs

test_core_raw

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

14.4 µs14.3 µs

test_bool_core

tests/benchmarks/test_micro_benchmarks.py

+1%

23.5 µs23.3 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

18.4 µs18.2 µs

test_core_future

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

+1%

26.2 µs26 µs

test_core_string_strict_wrong_str_e

tests/benchmarks/test_micro_benchmarks.py

+1%

40.6 µs40.3 µs

test_decimal_from_string_limit

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

+1%

19 µs18.9 µs

test_core_model_json_extra

tests/benchmarks/test_serialization_micro.py

+1%

29.5 µs29.3 µs

test_int_range_json

tests/benchmarks/test_micro_benchmarks.py

+1%

16.1 µs16 µs

test_dont_raise_error_no_info

tests/benchmarks/test_micro_benchmarks.py

+1%

18.3 µs18.2 µs

test_core_model_py_extra

tests/benchmarks/test_serialization_micro.py

+1%

29.9 µs29.7 µs

test_validate_literal[json-few_mixed]

tests/benchmarks/test_micro_benchmarks.py

+1%

18.8 µs18.6 µs

test_date_from_date

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateX

+1%

14.4 µs14.3 µs

test_validate_literal[python-many_large_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

15.1 µs15.1 µs

test_validate_literal[python-few_large_strings]

tests/benchmarks/test_micro_benchmarks.py

+1%

15.2 µs15.1 µs

test_validate_literal[python-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

+1%

15.3 µs15.2 µs

test_field_function_validator

tests/benchmarks/test_micro_benchmarks.py

+1%

400.1 µs397.9 µs

test_datetime

tests/benchmarks/test_serialization_micro.py

+1%

27.3 µs27.1 µs

test_decimal_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

23.8 µs23.7 µs

test_positional_tuple

tests/benchmarks/test_micro_benchmarks.py

18.8 µs18.7 µs

test_core_string_lax_wrong

tests/benchmarks/test_micro_benchmarks.py

27.1 µs26.9 µs

test_core_future_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

18.9 µs18.8 µs

test_raise_error_custom

tests/benchmarks/test_micro_benchmarks.py

37.9 µs37.7 µs

test_core_string_strict

tests/benchmarks/test_micro_benchmarks.py

14 µs13.9 µs

test_dont_raise_error

tests/benchmarks/test_micro_benchmarks.py

20.5 µs20.4 µs

test_validate_literal[python-few_ints]

tests/benchmarks/test_micro_benchmarks.py

15 µs14.9 µs

test_isinstance_string_strict_false

tests/benchmarks/test_micro_benchmarks.py

15.6 µs15.5 µs

test_tuple_many_variable

tests/benchmarks/test_micro_benchmarks.py

17.9 µs17.9 µs

test_tuple_many_positional

tests/benchmarks/test_micro_benchmarks.py

17.9 µs17.9 µs

test_set_of_ints_core_json_duplicates

tests/benchmarks/test_micro_benchmarks.py

422.4 µs421.1 µs

test_strict_union_error_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

32.6 µs32.5 µs

test_python_json_list_none

tests/benchmarks/test_serialization_micro.py

117.2 µs116.8 µs

test_date_format_function

tests/benchmarks/test_serialization_micro.py

52.1 µs52 µs

test_enum_int_python

tests/benchmarks/test_micro_benchmarks.py

24 µs23.9 µs

test_strict_int

tests/benchmarks/test_micro_benchmarks.py

13.9 µs13.9 µs

test_core_string_lax

tests/benchmarks/test_micro_benchmarks.py

14 µs14 µs

test_definition_out_of_tree

tests/benchmarks/test_micro_benchmarks.py

1 ms1 ms

test_list_of_nullable_core

tests/benchmarks/test_micro_benchmarks.py

104 µs103.8 µs

test_isinstance_json

tests/benchmarks/test_micro_benchmarks.py

18.7 µs18.6 µs

test_validate_literal[json-few_str_enum]

tests/benchmarks/test_micro_benchmarks.py

20.3 µs20.3 µs

test_date_format_function_no_info

tests/benchmarks/test_serialization_micro.py

51.5 µs51.4 µs

test_list_of_any_core_py

tests/benchmarks/test_micro_benchmarks.py

99 µs99 µs

test_tagged_union_int_keys_json

tests/benchmarks/test_micro_benchmarks.py

24.8 µs24.8 µs

test_frozenset_of_ints_duplicates_core

tests/benchmarks/test_micro_benchmarks.py

153.8 µs153.7 µs

test_dataclass_serialization_json

tests/benchmarks/test_serialization_micro.py

24.3 µs24.3 µs

test_list_of_strs_py_cached

tests/benchmarks/test_micro_benchmarks.py

130.9 µs130.9 µs

test_set_of_ints_core_duplicates

tests/benchmarks/test_micro_benchmarks.py

308.4 µs308.4 µs

test_uuid_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

47.9 µs47.9 µs

test_dict_of_any_core

tests/benchmarks/test_micro_benchmarks.py

690.3 µs690.2 µs

test_validate_literal[python-many_ints]

tests/benchmarks/test_micro_benchmarks.py

14.9 µs14.9 µs

test_smart_union_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUnion

16.1 µs16.1 µs

test_variable_tuple

tests/benchmarks/test_micro_benchmarks.py

18.5 µs18.5 µs

test_enum_int_core

tests/benchmarks/test_micro_benchmarks.py

15 µs15 µs

test_decimal_from_string_pyd

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDecimal

32.6 µs32.6 µs

test_definition_in_tree

tests/benchmarks/test_micro_benchmarks.py

742.3 µs742.3 µs

test_bytes_core

tests/benchmarks/test_micro_benchmarks.py

13.8 µs13.8 µs

test_isinstance_string_strict_true

tests/benchmarks/test_micro_benchmarks.py

14.1 µs14.1 µs

test_enum_str_python

tests/benchmarks/test_micro_benchmarks.py

23.8 µs23.8 µs

test_int_error

tests/benchmarks/test_micro_benchmarks.py

40.7 µs40.7 µs

test_complete_core_serializer_to_json

tests/benchmarks/test_complete_benchmark.py

279.6 µs279.6 µs

test_chain_list

tests/benchmarks/test_micro_benchmarks.py

25 µs25 µs

test_chain_nested_functions

tests/benchmarks/test_micro_benchmarks.py

28.7 µs28.7 µs

test_definition_model_core

tests/benchmarks/test_micro_benchmarks.py

1 ms1 ms

test_dataclass_to_json

tests/benchmarks/test_serialization_micro.py

40 µs40.1 µs

test_json_direct_list_int

tests/benchmarks/test_serialization_micro.py

146.1 µs146.2 µs

test_python_json_list_str

tests/benchmarks/test_serialization_micro.py

150.3 µs150.4 µs

test_filter

tests/benchmarks/test_serialization_micro.py

41.7 µs41.7 µs

test_model_exclude_unset_true

tests/benchmarks/test_serialization_micro.py

35.1 µs35.1 µs

test_python_json_list_int

tests/benchmarks/test_serialization_micro.py

143.5 µs143.7 µs

test_raise_error_value_error

tests/benchmarks/test_micro_benchmarks.py

36.6 µs36.6 µs

test_ser_list_of_lists

tests/benchmarks/test_serialization_micro.py

1.4 ms1.4 ms

test_frozenset_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

241.2 µs241.4 µs

test_model_exclude_unset_false

tests/benchmarks/test_serialization_micro.py

29.4 µs29.4 µs

test_json_any_list_int

tests/benchmarks/test_serialization_micro.py

222.6 µs222.8 µs

test_core_model_json

tests/benchmarks/test_serialization_micro.py

25.8 µs25.8 µs

test_chain_two_functions

tests/benchmarks/test_micro_benchmarks.py

28.7 µs28.7 µs

test_generator_rust

tests/benchmarks/test_micro_benchmarks.py

18.7 µs18.7 µs

test_core_python_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

69 µs69.1 µs

test_model_list_core_json

tests/benchmarks/test_serialization_micro.py

165.4 µs165.7 µs

test_isinstance_string_lax_false

tests/benchmarks/test_micro_benchmarks.py

15.9 µs15.9 µs

test_int_range

tests/benchmarks/test_micro_benchmarks.py

15.1 µs15.1 µs

test_core_json

tests/benchmarks/test_serialization_micro.py::TestBenchmarkSimpleModel

82.4 µs82.6 µs

test_list_of_strs_json_cached

tests/benchmarks/test_micro_benchmarks.py

311.5 µs312.1 µs

test_isinstance_string_lax_true

tests/benchmarks/test_micro_benchmarks.py

14 µs14.1 µs

test_date_format

tests/benchmarks/test_serialization_micro.py

52.1 µs52.2 µs

test_uuid_from_string_core

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

32.2 µs32.3 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

18.5 µs18.5 µs

test_validate_literal[python-few_small_strings]

tests/benchmarks/test_micro_benchmarks.py

15 µs15 µs

test_json_any_list_str

tests/benchmarks/test_serialization_micro.py

255.7 µs256.7 µs

test_enum_str_core

tests/benchmarks/test_micro_benchmarks.py

15.2 µs15.3 µs

test_generator_python

tests/benchmarks/test_micro_benchmarks.py

23.5 µs23.5 µs

test_uuid

tests/benchmarks/test_serialization_micro.py

23 µs23.1 µs

test_complete_core_lax

tests/benchmarks/test_complete_benchmark.py

271.4 µs272.5 µs

test_validate_literal[python-many_small_strings]

tests/benchmarks/test_micro_benchmarks.py

15.1 µs15.1 µs

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

29.9 µs30 µs

test_with_default

tests/benchmarks/test_micro_benchmarks.py

22.9 µs23 µs

test_dict_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

1.4 ms1.4 ms

test_core_model_py

tests/benchmarks/test_serialization_micro.py

26.5 µs26.6 µs

test_json_direct_list_str

tests/benchmarks/test_serialization_micro.py

173.4 µs174.2 µs

test_to_json_list_of_lists

tests/benchmarks/test_serialization_micro.py

2 ms2 ms

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkSimpleModel

-1%

106.3 µs106.9 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkDateTime

-1%

25.9 µs26.1 µs

test_dict_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

-1%

1 ms1 ms

test_complete_core_serializer_to_python

tests/benchmarks/test_complete_benchmark.py

-1%

231.2 µs232.6 µs

test_core_str

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

-1%

32.2 µs32.4 µs

test_to_string_direct

tests/benchmarks/test_serialization_micro.py

-1%

18.7 µs18.8 µs

test_to_string_format

tests/benchmarks/test_serialization_micro.py

-1%

23.5 µs23.7 µs

test_set_of_ints_core_length

tests/benchmarks/test_micro_benchmarks.py

-1%

697.3 µs702.2 µs

test_set_of_ints_core_json

tests/benchmarks/test_micro_benchmarks.py

-1%

840.7 µs846.7 µs

test_small_class_core_model

tests/benchmarks/test_micro_benchmarks.py

-1%

26.4 µs26.6 µs

test_dataclass_serialization_python

tests/benchmarks/test_serialization_micro.py

-1%

21.1 µs21.3 µs

test_set_of_ints_core

tests/benchmarks/test_micro_benchmarks.py

-1%

680.5 µs686.6 µs

test_model_core_json

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

-1%

41.2 µs41.6 µs

test_build_schema

tests/benchmarks/test_complete_benchmark.py

-1%

740.4 µs747.5 µs

test_complete_core_json

tests/benchmarks/test_complete_benchmark.py

-1%

411.2 µs415.4 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestBenchmarkUUID

-1%

25.5 µs25.7 µs

test_model_instance

tests/benchmarks/test_micro_benchmarks.py

-1%

28.7 µs29 µs

test_complete_core_strict

tests/benchmarks/test_complete_benchmark.py

-1%

247.4 µs250.4 µs

test_list_of_strs_json_uncached

tests/benchmarks/test_micro_benchmarks.py

-1%

395.7 µs401.1 µs

test_tagged_union_int_keys_python

tests/benchmarks/test_micro_benchmarks.py

-1%

20.7 µs21 µs

test_complete_core_root_json

tests/benchmarks/test_complete_benchmark.py

-1%

418.8 µs424.5 µs

test_small_class_core_dict

tests/benchmarks/test_micro_benchmarks.py

-2%

18.8 µs19.1 µs

test_core_json_fs

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

-2%

148.5 µs151.1 µs

test_complete_core_root

tests/benchmarks/test_complete_benchmark.py

-2%

270.5 µs275.5 µs

test_model_instance_abc

tests/benchmarks/test_micro_benchmarks.py

-2%

29 µs29.5 µs

test_core_root_model

tests/benchmarks/test_micro_benchmarks.py

-2%

35.2 µs35.9 µs

test_core_python

tests/benchmarks/test_micro_benchmarks.py::TestModelLarge

-2%

126.5 µs129.5 µs

test_list_of_dict_models_core

tests/benchmarks/test_micro_benchmarks.py

-5%

91 µs95.4 µs

test_many_models_core_dict

tests/benchmarks/test_micro_benchmarks.py

-5%

935.6 µs982.3 µs

test_nested_schema_inlined

tests/benchmarks/test_nested_benchmark.py

-5%

15.7 ms16.6 ms

test_nested_schema_using_defs

tests/benchmarks/test_nested_benchmark.py

-6%

14.2 ms15 ms

test_arguments

tests/benchmarks/test_micro_benchmarks.py

-7%

23 µs24.7 µs

Commits

Click on a commit to change the comparison range

Base

main

9a25aa6

-0.43%

Pass field_name to validators through ValidationState so functions are called with correct ValidationInfo.field_name

c0f01df

7 months ago

by DouweM

+0.23%

Update test as validate_assignment ValidationInfo now gets a field_name

0fd7ef1

7 months ago

by DouweM

-0.16%

Update tests as ValidationInfo now always gets a field_name

df34451

7 months ago

by DouweM

+0.09%

Only clone the field_name when necessary

e609bb3

7 months ago

by DouweM

-0.07%

Deprecate field_name argument on core_schema.with_info_{before,after,plain,wrap}_validator_function

9bac3bd

7 months ago

by DouweM

+0.07%

Set stacklevel on validator function field_name arg DeprecationWarning

b5cc2e9

7 months ago

by DouweM

+0.35%

Set field_name when validating call arguments

718324d

7 months ago

by DouweM

-0.13%

Add deprecated comment to WithInfoWrapValidatorFunctionSchema.field_name

3d69981

7 months ago

by DouweM

Home Terms Privacy Docs