fix: accept subscript and attribute targets in unpacking, for-loop, and comprehension contexts
#473Comparing
mbeschastn0v:mb/issue-408-unpack-subscript-attr
(51a2d41
) withmain
(10ab8bd
)-1%
- Untouched
- 17
- Skipped
- 15
Benchmarks
32 total
parse_1k_assigns__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark-6%
2.6 ms2.8 ms
end_to_end__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark-2%
43.1 µs44 µs
list_append_str__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark-1%
121.8 ms123 ms
kitchen_sink__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark-1%
64 µs64.6 µs
add_two__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark-1%
11.6 µs11.7 µs
json_dumps__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark+1%
33.2 ms33 ms
list_append__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark-1%
17 µs17.1 µs
list_append_int__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark-1%
49.2 ms49.5 ms
empty_tuples__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark0%
27.7 ms27.8 ms
func_call_kwargs__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark0%
22.2 µs22.2 µs
json_loads__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark0%
51.3 ms51.4 ms
list_comp__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark0%
290.5 µs290.8 µs
dict_comp__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark0%
567 µs566.7 µs
gc_collect__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark0%
61.5 ms61.5 ms
pair_tuples__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark0%
76.2 ms76.2 ms
loop_mod_13__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark0%
326.2 µs326.2 µs
fib__monty
crates/monty-bench/benches/main.rs::benches::criterion_benchmark0%
175.7 ms175.7 ms
The benchmarks below were skipped, so their baseline results are used instead. If they were deleted in your codebase, archive them to remove them from the performance reports.
Learn more about archiving benchmarks
Learn more about archiving benchmarks
kitchen_sink__monty
crates/monty/benches/main.rs::benches::criterion_benchmarkSkipped
64.4 µs*
loop_mod_13__monty
crates/monty/benches/main.rs::benches::criterion_benchmarkSkipped
326.5 µs*
list_append__monty
crates/monty/benches/main.rs::benches::criterion_benchmarkSkipped
16.1 µs*
dict_comp__monty
crates/monty/benches/main.rs::benches::criterion_benchmarkSkipped
620.5 µs*
add_two__monty
crates/monty/benches/main.rs::benches::criterion_benchmarkSkipped
11.1 µs*
json_dumps__monty
crates/monty/benches/main.rs::benches::criterion_benchmarkSkipped
34 ms*
list_comp__monty
crates/monty/benches/main.rs::benches::criterion_benchmarkSkipped
290.9 µs*
empty_tuples__monty
crates/monty/benches/main.rs::benches::criterion_benchmarkSkipped
30.3 ms*
Commits
Click on a commit to change the comparison rangeBase
main
10ab8bd
-0.67%
test: cover scope walks for lambdas inside unpack-target sub-expressions
51a2d41
20 days ago
by mbeschastn0v