BlogDocs

fix: avoid name conflicts (option 2) use __get__ directly to create signal instances(#262)

Closed
Comparing
tlambert03:fix-signal-name-conflict
(
2a99cbe
) with
main
(
d3d558d
)
+10%
IMPROVEMENTS
1
REGRESSIONS
0
UNTOUCHED
65
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Improved

test_emit_time[partial_method-2]
tests/test_bench.py::test_emit_time[partial_method-2]
+10%
67.8 µs
61.6 µs

Passed

test_create_signal_instance
tests/test_bench.py::test_create_signal_instance
+3%
25.9 µs
25.3 µs
test_emit_time[real_func-2]
tests/test_bench.py::test_emit_time[real_func-2]
+3%
64.3 µs
62.7 µs
test_create_signal
tests/test_bench.py::test_create_signal
+2%
75 µs
73.4 µs
test_emit_time[partial-34]
tests/test_bench.py::test_emit_time[partial-34]
+1%
105.5 µs
104.3 µs
test_emit_time[method-34]
tests/test_bench.py::test_emit_time[method-34]
+1%
101.5 µs
100.8 µs
test_emit_time[print-34]
tests/test_bench.py::test_emit_time[print-34]
+1%
271.6 µs
269.9 µs
test_dataclass_setattr[attrs]
tests/test_bench.py::test_dataclass_setattr[attrs]
+1%
763.2 µs
759 µs
test_emit_time[print-50]
tests/test_bench.py::test_emit_time[print-50]
+1%
368.9 µs
366.9 µs
test_emit_time[print-2]
tests/test_bench.py::test_emit_time[print-2]
+1%
83.2 µs
82.8 µs
test_emit_time[print-18]
tests/test_bench.py::test_emit_time[print-18]
+1%
174.2 µs
173.4 µs
test_emit_time[setattr-2]
tests/test_bench.py::test_emit_time[setattr-2]
+1%
52.9 µs
52.7 µs
test_emit_time[setattr-18]
tests/test_bench.py::test_emit_time[setattr-18]
+1%
59.5 µs
59.2 µs
test_emit_time[setitem-18]
tests/test_bench.py::test_emit_time[setitem-18]
0%
66.1 µs
65.8 µs
test_emit_time[function-2]
tests/test_bench.py::test_emit_time[function-2]
0%
61.3 µs
61.1 µs
test_evented_setattr
tests/test_bench.py::test_evented_setattr
0%
25.7 µs
25.6 µs
test_emit_time[function-34]
tests/test_bench.py::test_emit_time[function-34]
0%
83.7 µs
83.4 µs
test_emit_time[setattr-34]
tests/test_bench.py::test_emit_time[setattr-34]
0%
65.5 µs
65.3 µs
test_connect_time[partial-]
tests/test_bench.py::test_connect_time[partial-]
0%
242.7 µs
242.1 µs
test_emit_time[partial-18]
tests/test_bench.py::test_emit_time[partial-18]
0%
82.2 µs
82.1 µs
test_dataclass_setattr[dataclass]
tests/test_bench.py::test_dataclass_setattr[dataclass]
0%
741.3 µs
740.3 µs
test_emit_time[setitem-34]
tests/test_bench.py::test_emit_time[setitem-34]
0%
77.9 µs
77.9 µs
test_connect_time[partial_method-]
tests/test_bench.py::test_connect_time[partial_method-]
0%
274 µs
273.9 µs
test_emit_time[partial_method-34]
tests/test_bench.py::test_emit_time[partial_method-34]
0%
121 µs
121 µs
test_emit_time[partial-50]
tests/test_bench.py::test_emit_time[partial-50]
0%
126.1 µs
126.1 µs
test_emit_time[setattr-50]
tests/test_bench.py::test_emit_time[setattr-50]
0%
71.8 µs
71.8 µs
test_emit_time[partial_method-50]
tests/test_bench.py::test_emit_time[partial_method-50]
0%
151.8 µs
151.8 µs
test_emit_time[setitem-50]
tests/test_bench.py::test_emit_time[setitem-50]
0%
89.2 µs
89.2 µs
test_emit_time[lambda-2]
tests/test_bench.py::test_emit_time[lambda-2]
0%
55.6 µs
55.6 µs
test_connect_time[partial_method-check_types]
tests/test_bench.py::test_connect_time[partial_method-check_types]
0%
280.8 µs
281 µs
test_emit_time[partial_method-18]
tests/test_bench.py::test_emit_time[partial_method-18]
0%
90.8 µs
90.9 µs
test_emit_time[method-50]
tests/test_bench.py::test_emit_time[method-50]
0%
122.1 µs
122.2 µs
test_emit_time[lambda-18]
tests/test_bench.py::test_emit_time[lambda-18]
0%
69.4 µs
69.4 µs
test_evented_creation
tests/test_bench.py::test_evented_creation
0%
1.7 ms
1.7 ms
test_connect_time[function-check_types]
tests/test_bench.py::test_connect_time[function-check_types]
0%
155.3 µs
155.4 µs
test_emit_time[real_func-34]
tests/test_bench.py::test_emit_time[real_func-34]
0%
130.5 µs
130.6 µs
test_emit_time[real_func-18]
tests/test_bench.py::test_emit_time[real_func-18]
0%
96.8 µs
96.9 µs
test_emit_time[lambda-50]
tests/test_bench.py::test_emit_time[lambda-50]
0%
97.2 µs
97.4 µs
test_emit_time[function-18]
tests/test_bench.py::test_emit_time[function-18]
0%
69.3 µs
69.4 µs
test_emit_time[real_func-50]
tests/test_bench.py::test_emit_time[real_func-50]
0%
162.2 µs
162.6 µs
test_dataclass_setattr[pydantic]
tests/test_bench.py::test_dataclass_setattr[pydantic]
0%
847.9 µs
850 µs
test_emit_time[method-18]
tests/test_bench.py::test_emit_time[method-18]
0%
79.9 µs
80.1 µs
test_connect_time[setattr-]
tests/test_bench.py::test_connect_time[setattr-]
0%
60.6 µs
60.8 µs
test_emit_time[function-50]
tests/test_bench.py::test_emit_time[function-50]
0%
97.3 µs
97.5 µs
test_emit_time[lambda-34]
tests/test_bench.py::test_emit_time[lambda-34]
0%
83.4 µs
83.7 µs
test_connect_time[partial-check_types]
tests/test_bench.py::test_connect_time[partial-check_types]
0%
255.4 µs
256.2 µs
test_emit_time[setitem-2]
tests/test_bench.py::test_emit_time[setitem-2]
0%
54.7 µs
54.9 µs
test_connect_time[function-]
tests/test_bench.py::test_connect_time[function-]
0%
140.3 µs
140.8 µs
test_dataclass_setattr[msgspec]
tests/test_bench.py::test_dataclass_setattr[msgspec]
0%
756.6 µs
759.6 µs
test_connect_time[real_func-]
tests/test_bench.py::test_connect_time[real_func-]
0%
122.4 µs
122.9 µs
test_dataclass_group_create[dataclass]
tests/test_bench.py::test_dataclass_group_create[dataclass]
0%
527.9 µs
530.3 µs
test_dataclass_group_create[pydantic]
tests/test_bench.py::test_dataclass_group_create[pydantic]
0%
614.1 µs
617.2 µs
test_connect_time[method-check_types]
tests/test_bench.py::test_connect_time[method-check_types]
-1%
183.4 µs
184.3 µs
test_emit_time[method-2]
tests/test_bench.py::test_emit_time[method-2]
-1%
59.5 µs
59.8 µs
test_dataclass_group_create[msgspec]
tests/test_bench.py::test_dataclass_group_create[msgspec]
-1%
620.9 µs
624.7 µs
test_emit_time[partial-2]
tests/test_bench.py::test_emit_time[partial-2]
-1%
58 µs
58.3 µs
test_connect_time[print-check_types]
tests/test_bench.py::test_connect_time[print-check_types]
-1%
201.6 µs
203.1 µs
test_connect_time[real_func-check_types]
tests/test_bench.py::test_connect_time[real_func-check_types]
-1%
125.5 µs
126.4 µs
test_connect_time[print-]
tests/test_bench.py::test_connect_time[print-]
-1%
143.5 µs
144.7 µs
test_connect_time[setitem-]
tests/test_bench.py::test_connect_time[setitem-]
-1%
61 µs
61.5 µs
test_connect_time[setitem-check_types]
tests/test_bench.py::test_connect_time[setitem-check_types]
-1%
64.9 µs
65.6 µs
test_dataclass_group_create[attrs]
tests/test_bench.py::test_dataclass_group_create[attrs]
-1%
614.6 µs
621.6 µs
test_connect_time[setattr-check_types]
tests/test_bench.py::test_connect_time[setattr-check_types]
-1%
66.2 µs
67 µs
test_connect_time[method-]
tests/test_bench.py::test_connect_time[method-]
-2%
175.2 µs
178.4 µs
test_connect_time[lambda-check_types]
tests/test_bench.py::test_connect_time[lambda-check_types]
-2%
143.5 µs
146.3 µs
test_connect_time[lambda-]
tests/test_bench.py::test_connect_time[lambda-]
-2%
139.3 µs
142.2 µs

Commits

Click on a commit to change the comparison range
base
main
d3d558d
+10%
fix: use __get__ directly to create signal instances
2a99cbe
9 months ago
by tlambert03
ResourcesHomePricingDocsBlogGitHubChangelog
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.