Allow multiple self-dependencies
#338Comparing
konsti/dev/allow-multiple-self-dependencies
(7018db9
) withdev
(b90cd72
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 6
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
large_case_u16_NumberVersion.ron
benches/large_case.rs::benches::bench_nested::large_cases::large_case_u16_NumberVersion.ron0%
25.9 ms
25.8 ms
sudoku-easy
benches/sudoku.rs::benches::bench_solve::sudoku-easy0%
3.9 ms
3.9 ms
sudoku-hard
benches/sudoku.rs::benches::bench_solve::sudoku-hard0%
4.3 ms
4.3 ms
backtracking_ranges
benches/backtracking.rs::benches::bench_group::backtracking_ranges0%
2 s
2 s
backtracking_singletons
benches/backtracking.rs::benches::bench_group::backtracking_singletons0%
4.3 s
4.3 s
backtracking_disjoint_versions
benches/backtracking.rs::benches::bench_group::backtracking_disjoint_versions0%
2.3 s
2.3 s
Commits
Click on a commit to change the comparison rangeBase
dev
b90cd72
0%
Allow multiple self-dependencies
In uv, we don't use the `DependencyConstraints` map, but pass in the dependencies through an iterator. This means there can be duplicate dependencies in the input. This would previously make `merge_dependents` panic if a package dependent on itself twice with the same range:
```toml
[package]
name = "foo"
version = "0.1.0"
dependencies = ["foo", "foo"]
```
The fix is to ignore self-dependencies when merging dependents, given that they are always trivially true or trivially false.
7018db9
7 days ago
by konstin