Comparing
qe-always-create-a-span-for-prisma-engine-regardless-of-itx
(46637e0
) withmain
(dc758d7
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 11
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
build (medium)
query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::schema_builder::build (medium)0%
2.3 ms
2.3 ms
build (small)
query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::schema_builder::build (small)0%
281.6 µs
281.3 µs
medium_read
query-engine/request-handlers/benches/query_planning_bench.rs::benches::criterion_benchmark::medium_read0%
316 µs
315.9 µs
mutation
query-engine/request-handlers/benches/query_planning_bench.rs::benches::criterion_benchmark::mutation0%
6.3 ms
6.3 ms
validate (small)
query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::psl::validate (small)0%
1.8 ms
1.8 ms
deep_read_query
query-engine/request-handlers/benches/query_planning_bench.rs::benches::criterion_benchmark::deep_read_query0%
1.9 ms
1.9 ms
large_read
query-engine/request-handlers/benches/query_planning_bench.rs::benches::criterion_benchmark::large_read0%
1.6 ms
1.6 ms
validate (large)
query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::psl::validate (large)0%
53.5 ms
53.5 ms
validate (medium)
query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::psl::validate (medium)0%
12 ms
12 ms
small_read
query-engine/request-handlers/benches/query_planning_bench.rs::benches::criterion_benchmark::small_read0%
108.7 µs
108.8 µs
build (large)
query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::schema_builder::build (large)-1%
4.7 ms
4.8 ms
Commits
Click on a commit to change the comparison rangeBase
main
dc758d7
0%
qe: always create a span for `prisma:engine` regardless of iTX
Prevent `prisma:engine:response_json_serialization` span from being
orphan when using interactive transactions.
This check made sense in the past in principle when there were no child
spans outside of the iTX runner, and the `prisma:engine` span didn't
cover the whole `Engine::query` method duration, but now it makes more
sense to always create it.
Fixes: https://github.com/prisma/prisma/issues/21402
b3450f5
2 years ago
by aqrln0%
Merge branch 'main' into qe-always-create-a-span-for-prisma-engine-regardless-of-itx
b5bdd13
1 year ago
by Druue0%
qe-wasm: remove unused import
46637e0
1 year ago
by aqrln