chore/find_at_position_spans - Branch - prisma/prisma-engines

chore(fmt/psl): update find at position w/ spans

#4957

Comparing

chore/find_at_position_spans

(

17c65d2

) with

main

(

a2d1c42

)

Untouched: 11

Benchmarks

Passed

mutation

query-engine/request-handlers/benches/query_planning_bench.rs::benches::criterion_benchmark

6.3 ms6.3 ms

small_read

query-engine/request-handlers/benches/query_planning_bench.rs::benches::criterion_benchmark

110.8 µs110.8 µs

large_read

query-engine/request-handlers/benches/query_planning_bench.rs::benches::criterion_benchmark

1.6 ms1.6 ms

validate (small)

query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::psl

2.1 ms2.1 ms

deep_read_query

query-engine/request-handlers/benches/query_planning_bench.rs::benches::criterion_benchmark

2 ms2 ms

build (large)

query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::schema_builder

5.1 ms5.1 ms

build (small)

query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::schema_builder

297.7 µs297.8 µs

validate (medium)

query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::psl

14 ms14 ms

validate (large)

query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::psl

63.5 ms63.6 ms

medium_read

query-engine/request-handlers/benches/query_planning_bench.rs::benches::criterion_benchmark

321.7 µs322 µs

build (medium)

query-engine/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::schema_builder

2.5 ms2.5 ms

Commits

Click on a commit to change the comparison range

Base

main

a2d1c42

+0.14%

Updated pest grammar for empty argument to include the whitespaces up until whatever comes next. This means we have a wider span to use for empty arguments and enables us to check for cursors that are where the ""value"" would be but there is no actual value yet. EnumValuePosition was manually calculating attribute positions, this has been removed - it now defers to the AttributePosition implementation. Updating the positions in `find_at_position` to also include spans Extracted out reference_locations_for_target to separate module in prep for other lsp commands (e.g. rename)

f953663

1 year ago

by Druue

+0.04%

Merge branch 'main' into chore/find_at_position_spans

ef69301

1 year ago

by Druue

-0.14%

Merge branch 'main' into chore/find_at_position_spans

07d4869

1 year ago

by Druue

-0.1%

Merge branch 'main' into chore/find_at_position_spans

17c65d2

1 year ago

by Druue

Home Terms Privacy Docs