aqrln-tuxsotykylou - Branch - prisma/prisma-engines

refactor(qc): remove `ScalarCondition::[Not]InTemplate`

#5735

Comparing

aqrln-tuxsotykylou

(

3b6fbba

) with

aqrln-wuuzunwxxymx

(

fa74f5a

)

Untouched: 11

Skipped: 11

Benchmarks

Skipped (11)

Passed

deep_read_query

query-compiler/core-tests/benches/query_graph_bench.rs::benches::criterion_benchmark

1.8 ms1.8 ms

mutation

query-compiler/core-tests/benches/query_graph_bench.rs::benches::criterion_benchmark

6.4 ms6.4 ms

validate (medium)

query-compiler/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::psl

15.2 ms15.2 ms

validate (large)

query-compiler/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::psl

70.1 ms70.1 ms

large_read

query-compiler/core-tests/benches/query_graph_bench.rs::benches::criterion_benchmark

1.6 ms1.6 ms

validate (small)

query-compiler/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::psl

2.2 ms2.2 ms

build (medium)

query-compiler/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::schema_builder

2.6 ms2.6 ms

build (small)

query-compiler/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::schema_builder

306.6 µs306.7 µs

small_read

query-compiler/core-tests/benches/query_graph_bench.rs::benches::criterion_benchmark

105.1 µs105.2 µs

medium_read

query-compiler/core-tests/benches/query_graph_bench.rs::benches::criterion_benchmark

315.1 µs315.4 µs

build (large)

query-compiler/schema/benches/schema_builder_bench.rs::benches::criterion_benchmark::schema_builder

-2%

5.2 ms5.3 ms

Commits

Click on a commit to change the comparison range

Base

aqrln-wuuzunwxxymx

fa74f5a

-0.18%

refactor(qc): remove `ScalarCondition::[Not]InTemplate` Remove `ScalarCondition::InTemplate` and `ScalarCondition::NotInTemplate` and instead add placeholders as the third variant in `ConditionListValue`. This simplifies the implementation and makes some illegal states unrepresentable (previously it was possible to construct `ScalarCondition::InTemplate`/`ScalarCondition::NotInTemplate` with arbitrary `PrismaValue`s and with field references).

3b6fbba

7 days ago

by aqrln

Home Terms Privacy Docs