haocheng6:14604-fix-str-split-by-empty-string - Branch - pola-rs/polars

Blog Docs

fix(rust): Treat splitting by empty string as iterating over chars(#15922)

Merged

Merging

haocheng6:14604-fix-str-split-by-empty-string

(

b6b24c7

) into

main

(

be09246

)

+17%

IMPROVEMENTS: 1

REGRESSIONS: 0

UNTOUCHED: 33

NEW: 0

DROPPED: 0

IGNORED: 1

Benchmarks

Passing

test_filter1

py-polars/tests/benchmark/test_filter.py::test_filter1

+8%

701.7 µs

652.2 µs

test_groupby_h2oai_q1

py-polars/tests/benchmark/test_group_by.py::test_groupby_h2oai_q1

-3%

1.9 ms

test_groupby_h2oai_q10

py-polars/tests/benchmark/test_group_by.py::test_groupby_h2oai_q10

+1%

6.2 ms

6.1 ms

test_groupby_h2oai_q2

py-polars/tests/benchmark/test_group_by.py::test_groupby_h2oai_q2

-3%

3.9 ms

4 ms

test_groupby_h2oai_q3

py-polars/tests/benchmark/test_group_by.py::test_groupby_h2oai_q3

+3%

2 ms

test_groupby_h2oai_q4

py-polars/tests/benchmark/test_group_by.py::test_groupby_h2oai_q4

1.7 ms

test_groupby_h2oai_q5

py-polars/tests/benchmark/test_group_by.py::test_groupby_h2oai_q5

+1%

1.7 ms

test_groupby_h2oai_q6

py-polars/tests/benchmark/test_group_by.py::test_groupby_h2oai_q6

9.6 ms

test_groupby_h2oai_q7

py-polars/tests/benchmark/test_group_by.py::test_groupby_h2oai_q7

+5%

1.9 ms

test_groupby_h2oai_q8

py-polars/tests/benchmark/test_group_by.py::test_groupby_h2oai_q8

2.3 ms

test_groupby_h2oai_q9

py-polars/tests/benchmark/test_group_by.py::test_groupby_h2oai_q9

+2%

19.4 ms

19 ms

test_write_read_scan_large_csv

py-polars/tests/benchmark/test_io.py::test_write_read_scan_large_csv

31 ms

31.1 ms

test_tpch_q1

py-polars/tests/benchmark/test_tpch.py::test_tpch_q1

+2%

15.3 ms

15.1 ms

test_tpch_q10

py-polars/tests/benchmark/test_tpch.py::test_tpch_q10

+3%

5.6 ms

5.4 ms

test_tpch_q11

py-polars/tests/benchmark/test_tpch.py::test_tpch_q11

-5%

3.1 ms

3.2 ms

test_tpch_q12

py-polars/tests/benchmark/test_tpch.py::test_tpch_q12

+2%

5.3 ms

5.2 ms

test_tpch_q13

py-polars/tests/benchmark/test_tpch.py::test_tpch_q13

-2%

8 ms

8.2 ms

test_tpch_q14

py-polars/tests/benchmark/test_tpch.py::test_tpch_q14

+1%

1.9 ms

test_tpch_q15

py-polars/tests/benchmark/test_tpch.py::test_tpch_q15

+17%

2.1 ms

1.8 ms

test_tpch_q16

py-polars/tests/benchmark/test_tpch.py::test_tpch_q16

+2%

5.4 ms

5.3 ms

test_tpch_q17

py-polars/tests/benchmark/test_tpch.py::test_tpch_q17

-2%

5.9 ms

6 ms

test_tpch_q18

py-polars/tests/benchmark/test_tpch.py::test_tpch_q18

+2%

11 ms

10.8 ms

test_tpch_q19

py-polars/tests/benchmark/test_tpch.py::test_tpch_q19

+1%

6.7 ms

6.6 ms

test_tpch_q2

py-polars/tests/benchmark/test_tpch.py::test_tpch_q2

-1%

3.3 ms

test_tpch_q20

py-polars/tests/benchmark/test_tpch.py::test_tpch_q20

+1%

5.9 ms

5.8 ms

test_tpch_q21

py-polars/tests/benchmark/test_tpch.py::test_tpch_q21

142.6 ms

143 ms

test_tpch_q22

py-polars/tests/benchmark/test_tpch.py::test_tpch_q22

-1%

4.8 ms

test_tpch_q3

py-polars/tests/benchmark/test_tpch.py::test_tpch_q3

+4%

5.1 ms

4.9 ms

test_tpch_q4

py-polars/tests/benchmark/test_tpch.py::test_tpch_q4

-3%

3.8 ms

4 ms

test_tpch_q5

py-polars/tests/benchmark/test_tpch.py::test_tpch_q5

+3%

4.1 ms

4 ms

test_tpch_q6

py-polars/tests/benchmark/test_tpch.py::test_tpch_q6

+1%

1.7 ms

test_tpch_q7

py-polars/tests/benchmark/test_tpch.py::test_tpch_q7

-2%

7.2 ms

7.4 ms

test_tpch_q8

py-polars/tests/benchmark/test_tpch.py::test_tpch_q8

+5%

5.1 ms

4.9 ms

test_tpch_q9

py-polars/tests/benchmark/test_tpch.py::test_tpch_q9

-1%

24.9 ms

25.2 ms

Ignored

test_filter2Ignored

py-polars/tests/benchmark/test_filter.py::test_filter2

+27%

996.9 µs

783 µs

Commits

Click on a commit to change the comparison range

base

main

be09246

fix(rust): Treat splitting by empty string as iterating over chars

c7676e4

3 months ago

by haocheng6

Refactor to avoid use of boxed iterators

b380968

3 months ago

by haocheng6

Refactor to avoid unnecessary filtering

9e91234

3 months ago

by haocheng6

+1%

Address review comments

273b37a

3 months ago

by haocheng6

-1%

Address review comment

5bf814f

3 months ago

by haocheng6

+16%

add missing feature flag for clippy

b6b24c7

3 months ago

by orlp

ResourcesHome Pricing Docs Blog GitHub

Getting StartedSample repository Explore repositories Support

AboutCareers Twitter Discord Contact Us Terms of Service Privacy Policy