fix: SQL interface "off-by-one' indexing error with `GROUP BY` clauses that use position ordinals
#15584MergedComparing
alexander-beedie:fix-sql-ordinal-group-by
(8c9a081
) withmain
(835d198
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 21
- New
- 0
- Dropped
- 0
- Ignored
- 1
Benchmarks
Passed
test_cross_join
py-polars/tests/benchmark/test_release.py::test_cross_join+2%
1.4 ms
1.4 ms
test_min_max_2850
py-polars/tests/benchmark/test_release.py::test_min_max_2850+1%
2.2 ms
2.2 ms
test_windows_not_cached
py-polars/tests/benchmark/test_release.py::test_windows_not_cached+1%
617.2 ms
612.9 ms
test_max_statistic_parquet_writer
py-polars/tests/benchmark/test_release.py::test_max_statistic_parquet_writer+1%
60 ms
59.6 ms
test_h2oai_groupby_q9
py-polars/tests/benchmark/test_group_by.py::test_h2oai_groupby_q90%
4.2 s
4.2 s
test_h2oai_groupby_q7
py-polars/tests/benchmark/test_group_by.py::test_h2oai_groupby_q70%
3.1 s
3.1 s
test_h2oai_groupby_q2
py-polars/tests/benchmark/test_group_by.py::test_h2oai_groupby_q20%
4 s
4 s
test_h2oai_groupby_q5
py-polars/tests/benchmark/test_group_by.py::test_h2oai_groupby_q50%
2.2 s
2.2 s
test_h2oai_groupby_q1
py-polars/tests/benchmark/test_group_by.py::test_h2oai_groupby_q10%
1.5 s
1.5 s
test_categorical_vs_str_group_by
py-polars/tests/benchmark/test_release.py::test_categorical_vs_str_group_by0%
3 ms
3 ms
test_h2oai_groupby_q6
py-polars/tests/benchmark/test_group_by.py::test_h2oai_groupby_q60%
4 s
4 s
test_mean_overflow
py-polars/tests/benchmark/test_release.py::test_mean_overflow0%
425.5 ms
425.5 ms
test_filter1
py-polars/tests/benchmark/test_filter.py::test_filter10%
490.2 ms
490.2 ms
test_h2oai_groupby_q4
py-polars/tests/benchmark/test_group_by.py::test_h2oai_groupby_q40%
1.2 s
1.2 s
test_h2oai_groupby_q3
py-polars/tests/benchmark/test_group_by.py::test_h2oai_groupby_q30%
3.3 s
3.3 s
test_h2oai_groupby_q10
py-polars/tests/benchmark/test_group_by.py::test_h2oai_groupby_q100%
14.1 s
14.1 s
test_read_scan_large_csv
py-polars/tests/benchmark/test_release.py::test_read_scan_large_csv0%
24.2 s
24.2 s
test_h2oai_groupby_q8
py-polars/tests/benchmark/test_group_by.py::test_h2oai_groupby_q8-1%
2.3 s
2.3 s
test_boolean_min_max_agg
py-polars/tests/benchmark/test_release.py::test_boolean_min_max_agg-1%
3.3 ms
3.3 ms
test_cross_join_slice_pushdown
py-polars/tests/benchmark/test_release.py::test_cross_join_slice_pushdown-3%
1.2 ms
1.2 ms
test_sort_nan_1942
py-polars/tests/benchmark/test_release.py::test_sort_nan_1942-5%
400.1 µs
421.4 µs
Ignored
test_filter2Ignored
py-polars/tests/benchmark/test_filter.py::test_filter20%
932.9 ms
932.8 ms
Commits
Click on a commit to change the comparison rangeBase
main
835d198
0%
fix: SQL engine 'off-by-one' indexing error with "GROUP BY" clauses that use position ordinals
8c9a081
9 months ago
by alexander-beedie