yongsk0066:fix/preserve-diagnostics-ontype-save - Branch - oxc-project/oxc

fix(language_server): don't resend diagnostic on save, when `typeAware` is disabled and run is onType

#13604Merged

Comparing

yongsk0066:fix/preserve-diagnostics-ontype-save

(

7f6cfe2

) with

main

(

d3be692

)

Untouched: 37

No successful run was found on main ( 283e127) during the generation of this report, so d3be692 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

This report only contains results for the CPU Simulation instrument. To view results for the Wall Time instrument, click here.

Benchmarks

Passed

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

+1%

11.6 µs11.5 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

+1%

571.7 µs567.7 µs

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 ms2.4 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

133.6 µs133.3 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.7 ms1.7 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

50.4 ms50.3 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

34.4 ms34.4 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

142.1 ms141.9 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

120.5 µs120.4 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.4 ms2.4 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

207 ms206.8 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

713.8 µs713.2 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

85.1 µs85.1 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

77.6 µs77.6 µs

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

733.5 µs733.3 µs

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.8 ms2.8 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

259.4 µs259.3 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

28.2 ms28.2 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

22.6 ms22.6 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

11.5 ms11.5 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.9 ms26.9 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms5.3 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

870.1 µs870.3 µs

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.3 ms4.3 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.3 ms56.3 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4 ms4 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

356.7 µs357 µs

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

30.9 ms31 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20 µs20.1 µs

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.8 ms3.8 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

26.4 ms26.7 ms

Commits

Click on a commit to change the comparison range

Base

main

d3be692

+0.02%

fix(language_server): don't clear diagnostics on save in onType mode When lint.run="onType" and type_aware=false, saving would clear all diagnostics. Now returns None instead of empty Vec to preserve existing diagnostics.

7f6cfe2

2 months ago

by yongsk0066

Home Terms Privacy Docs