fix(language_server): don't resend diagnostic on save, when `typeAware` is disabled and run is onType
#13604MergedComparing
yongsk0066:fix/preserve-diagnostics-ontype-save
(7f6cfe2
) withmain
(d3be692
)0%
- Untouched
- 37
No successful run was found on main ( 283e127) during the generation of this report, so d3be692 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.
Benchmarks
37 total
mangler[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler+1%
11.6 µs11.5 µs
formatter[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter+1%
571.7 µs567.7 µs
linter[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/linter.rs::linter::bench_linter0%
2.4 ms2.4 ms
transformer[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer0%
133.6 µs133.3 µs
semantic[react.development.js]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic0%
1.7 ms1.7 ms
linter[react.development.js]
tasks/benchmark/benches/linter.rs::linter::bench_linter0%
50.4 ms50.3 ms
linter[cal.com.tsx]
tasks/benchmark/benches/linter.rs::linter::bench_linter0%
1.2 s1.2 s
codegen[cal.com.tsx]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen0%
34.4 ms34.4 ms
linter[binder.ts]
tasks/benchmark/benches/linter.rs::linter::bench_linter0%
142.1 ms141.9 ms
codegen[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen0%
120.5 µs120.4 µs
minifier[react.development.js]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier0%
2.4 ms2.4 ms
formatter[cal.com.tsx]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter0%
207 ms206.8 ms
transformer[react.development.js]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer0%
713.8 µs713.2 µs
parser[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/parser.rs::parser::bench_parser0%
85.1 µs85.1 µs
semantic[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic0%
77.6 µs77.6 µs
mangler[binder.ts]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler0%
733.5 µs733.3 µs
mangler[cal.com.tsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler0%
2.8 ms2.8 ms
codegen[react.development.js]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen0%
1.9 ms1.9 ms
mangler[react.development.js]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler0%
259.4 µs259.3 µs
semantic[cal.com.tsx]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic0%
28.2 ms28.2 ms
formatter[binder.ts]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter0%
22.6 ms22.6 ms
formatter[react.development.js]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter0%
11.5 ms11.5 ms
parser[cal.com.tsx]
tasks/benchmark/benches/parser.rs::parser::bench_parser0%
26.9 ms26.9 ms
estree[checker.ts]
tasks/benchmark/benches/parser.rs::parser::bench_estree0%
104.5 ms104.5 ms
lexer[cal.com.tsx]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer0%
5.3 ms5.3 ms
Commits
Click on a commit to change the comparison rangeBase
main
d3be692
+0.02%
fix(language_server): don't clear diagnostics on save in onType mode
7f6cfe2
6 months ago
by yongsk0066