ups/semantics-refs-stack - Branch - oxc-project/oxc

perf(semantic): store unresolved refs in a stack

#4162Merged

Comparing

ups/semantics-refs-stack

(

2203143

) with

main

(

f2b3273

)

+4%

Improvements: 5

Untouched: 24

Benchmarks

Improved

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+4%

136.3 ms130.5 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+4%

33.3 ms32 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+4%

203 ms195.4 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+4%

53 ms51.2 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+3%

212.1 ms205.9 ms

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+3%

66.7 ms65 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+2%

334.6 ms328.4 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+2%

84.6 ms83.3 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+2%

1.4 s1.4 s

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

57.9 ms57.6 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

129 µs128.6 µs

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

248.7 ms248.7 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

104.1 ms104.1 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.5 ms52.5 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

376.4 ms376.4 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

27.3 ms27.3 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

codegen_sourcemap[cal.com.tsx]

tasks/benchmark/benches/codegen_sourcemap.rs::codegen_sourcemap::bench_codegen_sourcemap

35.6 ms35.6 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.6 ms1.6 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77.1 µs77.2 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

252 µs252.3 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 µs22.5 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

773.4 ms777.1 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

-1%

205.2 µs207.5 µs

Commits

Click on a commit to change the comparison range

Base

main

f2b3273

+4.44%

perf(semantic): store unresolved refs in a stack (#4162) This tweaks `SemanticBuilder` logic in order to accumulate unresolved references in a stack, getting rid of the previous index-vector which is not required under the current access pattern. Ref: https://github.com/oxc-project/oxc/pull/4107#issuecomment-2214167393

2203143

2 years ago

by lucab

Home Terms Privacy Docs