ups/linter-perf-no-dupe-keys - Branch - oxc-project/oxc

perf(linter): optimize no-dupe-keys

#4292Merged

Comparing

ups/linter-perf-no-dupe-keys

(

0fdc88b

) with

main

(

c5731a5

)

Untouched: 32

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

57 ms56.3 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

169.7 ms168.8 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

102.6 ms102.3 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

625 ms624.7 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.3 ms26.3 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.5 µs22.5 µs

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

74.7 ms74.7 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.9 ms18.9 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.4 ms103.4 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.3 ms52.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

23.9 ms23.9 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

27.7 ms27.7 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

376 ms376 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.8 ms3.8 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.7 ms15.7 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77.1 µs77.2 µs

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

341.7 ms342 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

56.4 ms56.5 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

75 ms75.1 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

295.5 ms295.9 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

107.7 µs108 µs

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

45.7 ms45.8 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.4 s1.4 s

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

206.4 µs207.1 µs

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

171.9 ms172.7 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

777.9 ms781.6 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

231.1 µs233 µs

Commits

Click on a commit to change the comparison range

Base

main

c5731a5

-0.05%

perf(linter): optimize no-dupe-keys (#4292) This tweaks the `no-dupe-keys` lint in order to try to optimize it. The lints reliably shows up in both CPU and memory profiling, due to the cost of allocating/growing the hashmap and hashing into it. This PR tries to tackle both by skipping trivial cases and by pre-allocating a larger hashmap.

0fdc88b

1 year ago

by lucab

Home Terms Privacy Docs