refactor(linter): remove AstKind for SimpleAssignmentTarget
#12401Comparing
taearls:07_19_refactor_remove_ast_kind_from_simple_assignment_target
(2701bb7
) withmain
(977d3ba
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 34
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
linter[react.development.js]
tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[react.development.js]+2%
53.4 ms
52.1 ms
transformer[cal.com.tsx]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[cal.com.tsx]+1%
26.8 ms
26.4 ms
linter[binder.ts]
tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[binder.ts]+1%
146.4 ms
144.5 ms
semantic[react.development.js]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[react.development.js]+1%
1.7 ms
1.7 ms
formatter[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[RadixUIAdoptionSection.jsx]0%
308 µs
306.7 µs
semantic[binder.ts]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[binder.ts]0%
4.3 ms
4.3 ms
lexer[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[RadixUIAdoptionSection.jsx]0%
20.9 µs
20.9 µs
codegen[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[RadixUIAdoptionSection.jsx]0%
127.9 µs
127.6 µs
linter[cal.com.tsx]
tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[cal.com.tsx]0%
1.2 s
1.2 s
formatter[binder.ts]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[binder.ts]0%
20.6 ms
20.6 ms
isolated-declarations[vue-id.ts]
tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations::isolated-declarations[vue-id.ts]0%
57.5 ms
57.5 ms
transformer[react.development.js]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[react.development.js]0%
714.7 µs
714.3 µs
formatter[cal.com.tsx]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[cal.com.tsx]0%
162.3 ms
162.2 ms
semantic[cal.com.tsx]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[cal.com.tsx]0%
28 ms
28 ms
semantic[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[RadixUIAdoptionSection.jsx]0%
77.2 µs
77.2 µs
lexer[react.development.js]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[react.development.js]0%
384.1 µs
384 µs
codegen[binder.ts]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[binder.ts]0%
4.2 ms
4.2 ms
minifier[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[RadixUIAdoptionSection.jsx]0%
79.9 µs
79.9 µs
lexer[binder.ts]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[binder.ts]0%
930 µs
929.8 µs
codegen[cal.com.tsx]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[cal.com.tsx]0%
36.8 ms
36.8 ms
parser[react.development.js]
tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[react.development.js]0%
1.3 ms
1.3 ms
parser[binder.ts]
tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[binder.ts]0%
3.3 ms
3.3 ms
estree[checker.ts]
tasks/benchmark/benches/parser.rs::parser::bench_estree::estree[checker.ts]0%
104.7 ms
104.7 ms
lexer[cal.com.tsx]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[cal.com.tsx]0%
5.8 ms
5.8 ms
minifier[cal.com.tsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[cal.com.tsx]0%
38.7 ms
38.7 ms
parser[cal.com.tsx]
tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[cal.com.tsx]0%
26.8 ms
26.8 ms
codegen[react.development.js]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[react.development.js]0%
1.9 ms
1.9 ms
linter[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[RadixUIAdoptionSection.jsx]0%
2.5 ms
2.5 ms
minifier[binder.ts]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[binder.ts]0%
4.8 ms
4.9 ms
formatter[react.development.js]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[react.development.js]0%
10.3 ms
10.3 ms
minifier[react.development.js]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[react.development.js]0%
2.7 ms
2.7 ms
transformer[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[RadixUIAdoptionSection.jsx]0%
134 µs
134 µs
parser[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[RadixUIAdoptionSection.jsx]0%
84.2 µs
84.3 µs
transformer[binder.ts]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[binder.ts]0%
1.7 ms
1.7 ms
Commits
Click on a commit to change the comparison rangeBase
main
977d3ba
-19%
fix compile errors
e5af71a
6 days ago
by taearls+19%
fix semantic tests
5320f56
6 days ago
by taearls0%
update snapshot
4400cd3
5 days ago
by taearls0%
get tests to pass for func_names
c428239
5 days ago
by taearls0%
remove extra line in builder.rs
131b592
3 days ago
by taearls0%
remove comments
70efcc1
3 days ago
by taearls0%
Merge branch 'main' into 07_19_refactor_remove_ast_kind_from_simple_assignment_target
742f0f1
2 days ago
by taearls0%
simplify code changes
1a16647
2 days ago
by taearls0%
get namespace tests to pass with minimal changes
448156c
2 days ago
by taearls0%
get prefer_jest_mocked tests passing
bb21c45
2 days ago
by taearls0%
get no_accumulating_spread tests to pass
614d972
2 days ago
by taearls0%
simplify code changes
9e3c68a
2 days ago
by taearls0%
get exhaustive_deps tests passing with minimal changes
d08bc62
2 days ago
by taearls0%
get more tests passing
49aaa26
2 days ago
by taearls0%
get prefer_for_of tests to pass
05b2971
2 days ago
by taearls0%
get no_accessor_recursion tests to pass
15b618a
2 days ago
by taearls0%
get prefer_array_find tests passing
d234ba5
1 day ago
by taearls0%
fix some lint warnings
d446ad0
1 day ago
by taearls0%
fix lint errors
6eb760f
23 hours ago
by taearls0%
fix lint errors
cb842b4
23 hours ago
by taearls0%
fix lint error
87810ac
23 hours ago
by taearls0%
revert unnecessary change
5f12906
19 hours ago
by taearls0%
check for update expression in javascript checker
d3a6f38
19 hours ago
by taearls0%
get more conformance tests passing
0b7effb
18 hours ago
by taearls0%
get more conformance tests passing
ee51dd1
18 hours ago
by taearls0%
add identifier reference to NeedsParentheses for TSTypeAssertion
0c73fcc
18 hours ago
by taearls0%
Merge branch 'main' into 07_19_refactor_remove_ast_kind_from_simple_assignment_target
ea7b5a4
2 hours ago
by taearls0%
fix(formatter): add assignment expression parentheses for TypeScript cast expressions
After SimpleAssignmentTarget removal from AstKind, TypeScript cast expressions
(TSAsExpression, TSSatisfiesExpression, TSTypeAssertion) were missing parentheses
when used as assignment targets.
Fixed by adding AssignmentExpression and AssignmentTargetWithDefault to the
parentheses logic for:
- ts_as_or_satisfies_needs_parens() (line 697)
- TSTypeAssertion needs_parentheses() (line 432)
This fixes formatting for cases like:
- (a as any) = value
- (<number>x) = value
- ({ a: (b as any) = 2000 } = x)
Result: TypeScript prettier conformance improved from 242/573 to 243/573
0926bde
1 hour ago
by taearls0%
update prettier ts snapshot
190928f
59 minutes ago
by taearls0%
undo unneeded changes in func_names rule
8a13aa2
52 minutes ago
by taearls0%
simplify logic in id_length eslint rule
207cd7f
44 minutes ago
by taearls0%
simplify no_import_assign changes
138924e
34 minutes ago
by taearls0%
address lint error
033b12b
31 minutes ago
by taearls0%
simplify logic in no_unused_private_class_members
1f4b5a7
19 minutes ago
by taearls0%
make simpler change in no_commonjs
ed7597d
15 minutes ago
by taearls0%
simplify changes in prefer_jest_mocked
2701bb7
12 minutes ago
by taearls