optimize-expect - Branch - oxc-project/oxc

perf(parser): optimize expect() to reduce branch misprediction

#14242Merged

Comparing

optimize-expect

(

430bbaa

) with

main

(

a7e8662

)

Untouched: 37

Benchmarks

Passed

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+2%

32.2 ms*31.6 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

+1%

26.8 ms*26.6 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

+1%

3.3 ms*3.3 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

+1%

11.6 µs*11.5 µs

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms*1.3 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20 µs*19.9 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

581.3 µs*580.7 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4 ms*4 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.6 ms1.6 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.8 ms*2.8 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.6 ms*1.6 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.4 ms*56.3 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

711.8 µs*711.7 µs

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

211.4 ms*211.4 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.9 ms*3.9 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms*1.7 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms*104.5 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

12.1 ms*12.1 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms*5.3 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

724.2 ms724.2 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

870.2 µs*870.2 µs

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

87.9 ms87.9 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

23.7 ms*23.7 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

721.1 µs*721.2 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.8 ms*26.8 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.8 ms*1.8 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.5 ms*2.5 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.2 ms*4.2 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

118.9 µs*118.9 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

356.7 µs*356.9 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

134.3 µs*134.3 µs

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

32.7 ms32.7 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

254.4 µs*254.7 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72 µs*72.1 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

34.1 ms*34.1 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

26.4 ms*26.5 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

-2%

85.1 µs*86.6 µs

Commits

Click on a commit to change the comparison range

Base

main

a7e8662

+0.07%

perf(parser): optimize expect() to reduce branch misprediction Split the error handling path from the hot path in expect() and expect_without_advance() functions to improve branch prediction. The CPU can now better predict the common success path. Changes: - Add #[cold] #[inline(never)] handle_expect_failure() for error handling - Refactor expect() to inline success path and separate error path - Add #[inline] to expect_without_advance() for consistency - Maintain same behavior while improving performance This addresses the high branch misprediction shown by callgrind profiling. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

430bbaa

2 months ago

by Boshen

Home Terms Privacy Docs