no-yan:refactor/only-used-in-recursion - Branch - oxc-project/oxc

refactor(linter): improve recursive argument handling and diagnostics creation

#6513Merged

Comparing

no-yan:refactor/only-used-in-recursion

(

3bf0015

) with

main

(

39c2e66

)

Untouched: 29

Benchmarks

Passed

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

99.7 µs98.4 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

158.7 µs158.3 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.3 µs24.2 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

80.2 µs80.2 µs

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

27.3 ms27.3 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

80.2 ms80.2 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.8 ms72.8 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.7 ms19.7 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 ms22.4 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

19.6 ms19.6 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.7 ms17.7 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

31.2 ms31.2 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

516.6 ms516.6 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

108.7 ms108.7 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25 ms25 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.8 ms2.8 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.3 ms13.3 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

402.9 ms402.9 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

405.4 ms405.4 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

54 ms54 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.8 ms118.9 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.4 ms7.4 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

49.4 ms49.4 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

62.9 ms63 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 s2.5 s

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

35.9 ms36.4 ms

Commits

Click on a commit to change the comparison range

Base

main

39c2e66

+0.02%

refactor(linter): extract create_diagnostic function for clarity This refactor moves the logic for generating diagnostics into a separate create_diagnostic function. This improves readability and helps encapsulate the diagnostic creation logic away from the core recursive argument check.

3bf0015

1 year ago

by no-yan

Home Terms Privacy Docs