oxc-project
oxc
BlogDocsChangelog

fix(linter): prevent underflow in count_comment_lines for JSX files

#15026Merged
Comparing
ityuany:fix/count-comment-lines-underflow
(
27134a3
) with
main
(
47a616f
)
CodSpeed Performance Gauge
0%
Untouched
4
Skipped
33

Benchmarks

Skipped (33)

mangler[cal.com.tsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler
Skipped
2.8 ms*
mangler[react.development.js]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler
Skipped
262.2 µs*
mangler[binder.ts]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler
Skipped
747.7 µs*
minifier[cal.com.tsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier
Skipped
35.5 ms*
minifier[react.development.js]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier
Skipped
2.5 ms*
minifier[binder.ts]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier
Skipped
4 ms*
mangler[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler
Skipped
12.9 µs*
semantic[binder.ts]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic
Skipped
4.1 ms*
semantic[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic
Skipped
71.4 µs*
semantic[react.development.js]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic
Skipped
1.6 ms*
semantic[cal.com.tsx]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic
Skipped
26.4 ms*
formatter[binder.ts]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter
Skipped
24 ms*
formatter[cal.com.tsx]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter
Skipped
213.2 ms*
formatter[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter
Skipped
583.1 µs*
formatter[react.development.js]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter
Skipped
12.2 ms*
parser[binder.ts]
tasks/benchmark/benches/parser.rs::parser::bench_parser
Skipped
3.3 ms*
estree[checker.ts]
tasks/benchmark/benches/parser.rs::parser::bench_estree
Skipped
104.5 ms*
parser[react.development.js]
tasks/benchmark/benches/parser.rs::parser::bench_parser
Skipped
1.3 ms*
parser[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/parser.rs::parser::bench_parser
Skipped
87.4 µs*
parser[cal.com.tsx]
tasks/benchmark/benches/parser.rs::parser::bench_parser
Skipped
26.7 ms*
codegen[react.development.js]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen
Skipped
1.9 ms*
codegen[cal.com.tsx]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen
Skipped
34.6 ms*
codegen[binder.ts]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen
Skipped
4.3 ms*
codegen[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen
Skipped
120.8 µs*
lexer[react.development.js]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer
Skipped
354.3 µs*
lexer[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer
Skipped
20 µs*
lexer[cal.com.tsx]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer
Skipped
5.3 ms*
lexer[binder.ts]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer
Skipped
863.3 µs*
transformer[react.development.js]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer
Skipped
715.7 µs*
transformer[binder.ts]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer
Skipped
1.7 ms*
transformer[cal.com.tsx]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer
Skipped
26.4 ms*
isolated-declarations[vue-id.ts]
tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations
Skipped
56.4 ms*
transformer[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer
Skipped
134.5 µs*

Passed

linter[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/linter.rs::linter::bench_linter
CodSpeed Performance Gauge
0%
730.8 µs729.9 µs
linter[binder.ts]
tasks/benchmark/benches/linter.rs::linter::bench_linter
CodSpeed Performance Gauge
0%
49.2 ms49.2 ms
linter[react.development.js]
tasks/benchmark/benches/linter.rs::linter::bench_linter
CodSpeed Performance Gauge
0%
19.2 ms19.2 ms
linter[cal.com.tsx]
tasks/benchmark/benches/linter.rs::linter::bench_linter
CodSpeed Performance Gauge
0%
477.3 ms477.4 ms

Commits

Click on a commit to change the comparison range
Base
main
47a616f
+0.09%
fix(linter): prevent integer underflow in count_comment_lines for JSX comments When processing JSX inline comments like `{/* comment */}` with the eslint/max-lines rule using skipComments: true, the count_comment_lines function would calculate start_line > end_line, causing integer underflow. This resulted in: - Debug mode: panic with "attempt to subtract with overflow" - Release mode: wrapping to usize::MAX, incorrect line count Fix by using saturating_sub which: - Prevents panic in all build modes - Returns 0 for inline comments (logically correct) - Maintains correct behavior for multi-line comments Added test case to prevent regression.
cccadd9
15 days ago
by ityuany
-0.07%
clippy fix, improve test coverage
27134a3
13 days ago
by camc314
© 2025 CodSpeed Technology
Home Terms Privacy Docs