ityuany:fix/count-comment-lines-underflow - Branch - oxc-project/oxc

fix(linter): prevent underflow in count_comment_lines for JSX files

#15026Merged

Comparing

ityuany:fix/count-comment-lines-underflow

(

27134a3

) with

main

(

47a616f

)

Untouched: 4

Skipped: 33

No successful run was found on main ( 8d8d508) during the generation of this report, so 47a616f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (33)

Passed

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

730.8 µs729.9 µs

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

49.2 ms49.2 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

19.2 ms19.2 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

477.3 ms477.4 ms

Commits

Click on a commit to change the comparison range

Base

main

47a616f

+0.09%

fix(linter): prevent integer underflow in count_comment_lines for JSX comments When processing JSX inline comments like `{/* comment */}` with the eslint/max-lines rule using skipComments: true, the count_comment_lines function would calculate start_line > end_line, causing integer underflow. This resulted in: - Debug mode: panic with "attempt to subtract with overflow" - Release mode: wrapping to usize::MAX, incorrect line count Fix by using saturating_sub which: - Prevents panic in all build modes - Returns 0 for inline comments (logically correct) - Maintains correct behavior for multi-line comments Added test case to prevent regression.

cccadd9

15 days ago

by ityuany

-0.07%

clippy fix, improve test coverage

27134a3

13 days ago

by camc314

Home Terms Privacy Docs