hashbang - Branch - oxc-project/oxc

fix(parser): hashbang comment should not keep the end newline char

#5844Merged

Comparing

hashbang

(

42dcadf

) with

main

(

65a1734

)

Untouched: 29

Benchmarks

Passed

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+2%

1.3 s1.3 s

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

46.9 ms46.8 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

23.8 µs23.8 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

161 µs160.7 µs

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

72.5 ms72.4 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

98.8 µs98.6 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

79.8 µs79.7 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 s2.4 s

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

20.7 ms20.7 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

20.6 ms20.6 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.5 ms3.5 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

51 ms51 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.2 ms7.2 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.7 ms24.7 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

77.1 ms77.1 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.4 ms5.4 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.4 ms17.4 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13 ms13 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

107.3 ms107.3 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

365.9 ms365.9 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

53.3 ms53.3 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

392.6 ms392.6 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.8 ms21.8 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

655.4 ms655.5 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

130.1 ms130.1 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.5 ms61.5 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

21 ms21.1 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-1%

3.7 ms3.7 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

30.8 ms31.2 ms

Commits

Click on a commit to change the comparison range

Base

main

65a1734

+0.02%

fix(parser): hashbang comment should not keep the end newline char (#5844) Previously it included a newline in the value ``` "hashbang": { "type": "Hashbang", "start": 0, "end": 16, "value": "/usr/bin/node\n" }, ``` This change will also make the lexer emit a `\n` token, which will make comment position detection correct.

42dcadf

1 year ago

by Boshen

Home Terms Privacy Docs