fix/minifier-regexp-validation - Branch - oxc-project/oxc

fix(minifier): validate RegExp patterns before marking as pure

#18125

Comparing

fix/minifier-regexp-validation

(

8563299

) with

main

(

a89b245

)

Untouched: 42

Skipped: 3

No successful run was found on main ( 8d292b7) during the generation of this report, so a89b245 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (3)

Passed

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

135.5 µs135.1 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.1 µs21 µs

formatter[next.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2.8 ms2.8 ms

formatter[core.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2 ms2 ms

formatter[index.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

4.6 ms4.6 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

251.2 µs250.9 µs

formatter[Search.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

1.9 ms1.9 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

62.7 µs62.6 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.3 ms1.3 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

721.4 µs720.9 µs

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25.4 ms25.3 ms

formatter[App.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

49 ms49 ms

formatter[types.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

14.8 ms14.8 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57 ms57 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

358.3 µs358.2 µs

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

49.6 ms*49.6 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

3.1 ms3.1 ms

formatter[errors.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

789.7 µs789.5 µs

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

885.2 µs885 µs

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.1 ms3.1 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

743.9 µs*743.8 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

492.6 ms*492.6 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

21.2 ms21.2 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

13 µs13 µs

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.2 ms1.2 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.3 ms4.3 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

105.1 ms105.1 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

19.7 ms*19.7 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.8 ms2.8 ms

formatter[handle-comments.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

3.5 ms3.5 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

33.8 ms33.8 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

439.2 µs439.5 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4 ms4 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

700.5 µs702.2 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.5 ms2.5 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

80.3 µs80.6 µs

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

121.9 µs122.5 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

26.4 ms26.7 ms

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-2%

35.7 ms36.4 ms

Commits

Click on a commit to change the comparison range

Base

main

a89b245

-0.08%

fix(minifier): validate RegExp patterns before marking as pure Invalid RegExp patterns like `RegExp("[")` or invalid flags like `RegExp("a", "xyz")` throw SyntaxError at runtime, so they should not be removed by the minifier. This change uses `oxc_regular_expression` to validate patterns at compile time: - Valid patterns are marked as pure and can be removed when unused - Invalid patterns or non-literal arguments are kept Fixes #18050 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

8563299

2 hours ago

by Boshen

Home Terms Privacy Docs