fix/formatter-union-type-comments - Branch - oxc-project/oxc

fix(formatter): relocate leading comments for single-element union/intersection types

#18083

Comparing

fix/formatter-union-type-comments

(

d6bdb9d

) with

main

(

a95b9bb

)

Untouched: 38

Skipped: 7

No successful run was found on main ( 312da18) during the generation of this report, so a95b9bb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (7)

Passed

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+2%

26.7 ms26.1 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

+2%

4.3 ms4.2 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

8.6 µs8.6 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

80.9 µs80.7 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.3 ms1.3 ms

formatter[App.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

48.9 ms48.9 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

135.4 µs135.3 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.6 ms2.6 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

21.3 ms21.3 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.8 ms56.7 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4.1 ms4.1 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.2 ms1.2 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

105.1 ms105.1 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25.3 ms25.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

formatter[types.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

14.7 ms14.7 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

715.4 µs715.5 µs

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

3.1 ms3.1 ms

formatter[index.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

4.6 ms4.6 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.1 ms3.1 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

884.8 µs885 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

33.8 ms33.8 ms

formatter[core.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2 ms2 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

532.4 µs532.8 µs

formatter[handle-comments.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

3.5 ms3.5 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.2 ms2.2 ms

formatter[errors.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

790.2 µs791 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

358 µs358.3 µs

formatter[Search.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

1.9 ms1.9 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21 µs21 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

62.4 µs62.5 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

220.3 µs220.6 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

436.2 µs437.1 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

37.5 ms37.6 ms

formatter[next.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2.8 ms2.8 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-2%

120 µs122 µs

Commits

Click on a commit to change the comparison range

Base

main

a95b9bb

+0.04%

fix(formatter): relocate leading comments for single-element union/intersection types For type alias declarations like `type A = /*1*/ | C`, Prettier relocates the leading comment from before the `|`/`&` operator to after the identifier, producing `type A /*1*/ = C;` instead of `type A = /*1*/ C;`. This fix handles the comment relocation for single-element union and intersection types, but skips complex nested cases (parenthesized types or same-type nesting) which have different comment handling rules. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

d6bdb9d

3 days ago

by Boshen

Home Terms Privacy Docs